From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42671C433E0 for ; Fri, 15 Jan 2021 15:09:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1454D23884 for ; Fri, 15 Jan 2021 15:09:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732596AbhAOPJJ (ORCPT ); Fri, 15 Jan 2021 10:09:09 -0500 Received: from relay.smtp-ext.broadcom.com ([192.19.232.172]:41212 "EHLO relay.smtp-ext.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729568AbhAOPJI (ORCPT ); Fri, 15 Jan 2021 10:09:08 -0500 Received: from bld-lvn-bcawlan-34.lvn.broadcom.net (bld-lvn-bcawlan-34.lvn.broadcom.net [10.75.138.137]) by relay.smtp-ext.broadcom.com (Postfix) with ESMTP id 7AD972435A; Fri, 15 Jan 2021 07:08:07 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 relay.smtp-ext.broadcom.com 7AD972435A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com; s=dkimrelay; t=1610723287; bh=17aCG3PbjBsTi6eKwhku2AiY0ZV4VTUvwU5ztGM7hss=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=IxBEJdxZDjnprWsJ3SbEzuBPb+kposF2ZJqZcbE+88NgPFXEIn1JgxotM9j63Ucnq TdL3mhg8kxfd66pcgc2CBI771OmnBuwo669x0sucuTL820TcyhTBXT89DKiJPTVy/0 rlenY0BPHXXnY/ae/DtN777wEz/Teu/S+ZJLqHA0= Received: from [10.230.40.117] (unknown [10.230.40.117]) by bld-lvn-bcawlan-34.lvn.broadcom.net (Postfix) with ESMTPSA id C264B187289; Fri, 15 Jan 2021 07:08:04 -0800 (PST) Subject: Re: [PATCH v2] brcmfmac: add support for CQM RSSI notifications To: Andrew Zaborowski Cc: =?UTF-8?Q?Alvin_=c5=a0ipraga?= , Arend van Spriel , Franky Lin , Hante Meuleman , Chi-hsien Lin , Wright Feng , Chung-hsien Hsu , Kalle Valo , "linux-wireless@vger.kernel.org" , "brcm80211-dev-list.pdl@broadcom.com" , "SHA-cyfmac-dev-list@infineon.com" , "linux-kernel@vger.kernel.org" References: <20210114163641.2427591-1-alsi@bang-olufsen.dk> <2adec5d6-fbc9-680c-01d6-25f83327bf21@broadcom.com> From: Arend van Spriel Message-ID: <6a87845e-3f9d-2921-051a-d1fe7d27cbd3@broadcom.com> Date: Fri, 15 Jan 2021 16:08:02 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/15/2021 3:51 PM, Andrew Zaborowski wrote: > On Fri, 15 Jan 2021 at 15:12, Arend Van Spriel > wrote:> >> + Johannes >> - netdevs >> >> On 1/14/2021 5:36 PM, 'Alvin Šipraga' via BRCM80211-DEV-LIST,PDL wrote: >>> Add support for CQM RSSI measurement reporting and advertise the >>> NL80211_EXT_FEATURE_CQM_RSSI_LIST feature. This enables a userspace >>> supplicant such as iwd to be notified of changes in the RSSI for roaming >>> and signal monitoring purposes. >> >> The more I am looking into this API the less I understand it or at least >> it raises a couple of questions. Looking into nl80211_set_cqm_rssi() [1] >> two behaviors are supported: 1) driver is provisioned with a threshold >> and hysteresis, or 2) driver is provisioned with high and low threshold. > > Right. > >> >> The second behavior is used when the driver advertises >> NL80211_EXT_FEATURE_CQM_RSSI_LIST *and* user-space provides more than >> one RSSI threshold. > > Or, when the driver doesn't implement set_cqm_rssi_config (the old > method). So the driver can stop supporting set_cqm_rssi_config when > it implements set_cqm_rssi_range_config. Argh. Totally overlooked these were two different callbacks. In that case it is easy to determine what is being requested. Thanks, Arend