From: Jens Axboe <axboe@kernel.dk>
To: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: WARNING in __flush_work
Date: Wed, 30 Jan 2019 08:53:33 -0700 [thread overview]
Message-ID: <6a87f3b6-3a5e-cf96-69f4-0172a89c8897@kernel.dk> (raw)
In-Reply-To: <4d633ac8-2340-8759-f2a6-a147dafe3339@I-love.SAKURA.ne.jp>
On 1/30/19 6:56 AM, Tetsuo Handa wrote:
> From fd653e8dd0d5368cd0cd9ccd89cf3001e4584f8a Mon Sep 17 00:00:00 2001
> From: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
> Date: Wed, 30 Jan 2019 22:21:45 +0900
> Subject: [PATCH] block: pass no-op callback to INIT_WORK().
>
> syzbot is hitting flush_work() warning caused by commit 4d43d395fed12463
> ("workqueue: Try to catch flush_work() without INIT_WORK().") [1].
> Although that commit did not expect INIT_WORK(NULL) case, calling
> flush_work() without setting a valid callback should be avoided anyway.
> Fix this problem by setting a no-op callback instead of NULL.
>
> [1] https://syzkaller.appspot.com/bug?id=e390366bc48bc82a7c668326e0663be3b91cbd29
Applied, thanks.
--
Jens Axboe
prev parent reply other threads:[~2019-01-30 15:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-29 16:43 syzbot
2019-01-30 13:56 ` Tetsuo Handa
2019-01-30 15:53 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a87f3b6-3a5e-cf96-69f4-0172a89c8897@kernel.dk \
--to=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®