From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AAFC846EC81 for ; Fri, 21 Aug 2026 12:07:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787314058; cv=none; b=QDx78JWNPafdG3quxou9jz6UON/M0T08iy0pze/7+vBlMywnGjtRXzbpQTp8fukXbq5c+R+snSb8LKo41en+TX3Ja3911QOo4HDq7L2u2Tze1N0PILL5PJFoTu/47+MNdXuDVF/TTwTwA2puyg7Oub+YqC68166srgcqVFlNlxo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787314058; c=relaxed/simple; bh=WND98xi4kcaiDMab/piGwPQUDbHFz1joQ5NWcGKi8PA=; h=Message-ID:Date:From:To:Cc:Subject:In-Reply-To:References: Content-Type:MIME-Version; b=m0IHNr0eYBjZMnJxmmOh6ErCvuoFwn1gLpjQkSbZhZCllBtGahsi/owDGic7MRpH/BnyJ98tAhScuK8+fJDdPI8RaIsN5XS4YqSw4U4zew+/Dk4V9dxE/qi+TGSqG6nJFaU0EyFTXR/GHNmg4ORl5vydD1ui/qKY67rHZ5SA0ts= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UflpmWm0; arc=none smtp.client-ip=209.85.214.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UflpmWm0" Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-2d53197d8b5so9853365ad.3 for ; Fri, 21 Aug 2026 05:07:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787314054; x=1787918854; darn=vger.kernel.org; h=mime-version:content-transfer-encoding:content-type:references :in-reply-to:subject:cc:to:from:date:message-id:from:to:cc:subject :date:message-id:reply-to:content-type; bh=41yW1mpvijPpCXEZxWND4UtxVbGlZc+eTbFwWYCv4fg=; b=UflpmWm0WoeYEc+fINZoCJ6gn+hF53GDGBvZmFA3IKgpX5kckLHfCTjLbQQAmH1ALt SfOkkryycQD3+iQQW6l9wMPk6yQwdTJdpBL08MO8gZ1qT4XCSog9UHYIB0LF+YzFcnK8 qoIW8c4A/30tkLgAPmYQzdyZ/6ZRoGFNhcBnd+vTayEepLhRMjDtv20jNub6DogRH/gI hMnrQRL7SH4NpFUIPliNzKNbJgeJe0F/N4dtKl2y+7CsKUziZw997A0OM0PEH6Lh1Z0G qZL3PlCwrBP7sRYDLnYJjTFhryj+99AM9Q/7rSCIP5ubzkL9ASwGF0tCQbqMVYiyA/J9 1/uA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787314054; x=1787918854; h=mime-version:content-transfer-encoding:content-type:references :in-reply-to:subject:cc:to:from:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=41yW1mpvijPpCXEZxWND4UtxVbGlZc+eTbFwWYCv4fg=; b=rofHPl+sGd2gcyhChZA0PAltkOXAvnNB5We71p0J7062ASFmZHFjIToYivyL4VZMAD gkad0jIo8fl3G+P3jzCR14M6HD/PTry7HgjLh0Nhz7088ZPeU9YgIYmEim/jspYOsJC9 JS2TERJS+60nMvymwChzzQOWCCVmumC+4gWUdm6E1tRzKK4N4ms75l9h+em+koT7zz+6 3jiRG1eN0LYS9xj3MaxkC0xzNfC0SM7N4mRk+5gidcLePaDKm1UlR52NVxDkfBHsyOeO Pow4wFx7B4slcjQARSgArVqm89B5np0TVOAxy89/OSPRw+yiQFrpe10K6HAp4aCu3nqm nIYw== X-Forwarded-Encrypted: i=1; AHgh+RrSiQ7O2OXhyzZZuwQZAxyJEyoASFXkw4MYFbL/CALaZDduDW4GoxAsW/0dh2f2+19+CjYjOb3WYNngiS8=@vger.kernel.org X-Gm-Message-State: AFuF++lj9laimMWuKDKg51+R9cgCb5Y1F3uOALy+hpYoSsDyRmEkNF3E bYXVL1W6ZT0I9Q7j+NvcAJnoNbYQO0NcfFMimuZR8AVCvGQxtRFav1o/ X-Gm-Gg: AR+sD10X+Cv//qnrVLJ80Y+6FYrnbeVXViI0ffh6RQMIy8b/VK8Y0cMR31wGrrj2ZuV zx1ls6/blhk6KjPZFzF+ex/KBkHl5dPr5VOG7rsgONryLHtu9m5q+K2ViZPZix+cLj4x+Kt2aGj TnZjgBI8vDP4YN/2TF6IubglocB75//URS5oiWYIksBp4DK3NCilSkIQwzMyJ1OQ7CFkbT2WGnN 4QMbQY8Emg5EAg1W7QowBxVKrp2L5cOLGzjeX8HNUsPBb7BeUeAfmucSbP4yqcNu4uUXRF7bH1M 0kdmraEyTfiXm/2J5Df1t7mreRWOKgOkpXpUOEEmyt4VF52olaKRACbZoQNzwmfC221lkZdM1/i KFUretU/aV2QRLxPAWBkqHsYqguHJOvLJXSXp7OfZfE3uMZdMud7CY7lXj1LwZw+/hdXE+A/Xou wdK5iSG6KK2deDpYsmENmIAgXOj7c6otGQcYJwQAN4ePfq4gAYdxUqR95vjYPK7q8M6PAd92TPG El4ikEmEvvcnFgZYG19pUEe4zwJENzNzisoERJQeFWyNNvW3l4z0g== X-Received: by 2002:a17:90b:3142:b0:37f:e177:f58 with SMTP id 98e67ed59e1d1-395c35e27c2mr10129319a91.9.1787314053985; Fri, 21 Aug 2026 05:07:33 -0700 (PDT) Received: from [127.0.1.1] (ec2-99-79-140-187.ca-central-1.compute.amazonaws.com. [99.79.140.187]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-395c4baa594sm2918858a91.17.2026.08.21.05.07.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Aug 2026 05:07:33 -0700 (PDT) Message-ID: <6a883f85.f375f8af.234495.358a@mx.google.com> Date: Fri, 21 Aug 2026 05:07:33 -0700 (PDT) From: hanzhijian To: Dan Carpenter Cc: Greg Kroah-Hartman , Viresh Kumar , Johan Hovold , Alex Elder , greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: greybus: bootrom: fix potential NULL dereference In-Reply-To: References: <20260821113540.1989561-1-hanzhijian1991@gmail.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Fri, Aug 21, 2026 at 02:53:13PM +0300, Dan Carpenter wrote: > You're using the word "potential" but the commit message correctly > explains why a NULL dereference is impossible. Don't say potentially > for things which are impossible. > > A lot of people would argue that the original code is easy to follow... > It's not really fragile either... You're right on all counts. The commit message contradicts itself, and the refactor does make the error path harder to follow than the original if/else. I'll drop this patch. Thanks for the review. hanzhijian