From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DB428377ECA for ; Sun, 23 Aug 2026 17:05:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787504752; cv=none; b=J3k3rHxjxlamL6+/nWaKQfi9pPLTZFAHxtO2RI82A2r+aeqLtZ0S1uyAgjaH1HlzspkNg+eHe6nsgGHWi9XldCbjKXkLVB1G8TrfhnCDYp4mAQSse4ppoTAbOp3y9xe0O7YsuTz4CInqWoMo4+ZRDikLMzmVj6fzGNtkrch7+do= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787504752; c=relaxed/simple; bh=utqAG8IpZT2OD3cxKw9dTNa1SvE5/d2khch5E9xzmAo=; h=Message-ID:MIME-Version:From:To:Cc:Date:Subject:Content-Type; b=ggS8ff5OxZizQ8iiqX839a0WH8aY7WSCpDucmqnZs67RYHxxfxhGjQYmtJ6b4wlpcBKQDkHn9CSlbaGiReSBYR+jndHk9SRRjmFMBgJXQHzofS9dm69sZdidpUzaZMt05UhyIZB2v/QwEGNmHEq7ZfYdauE1kQmVPQkDkoJ94vw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MikGS4Uw; arc=none smtp.client-ip=209.85.214.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MikGS4Uw" Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-2d53197d8b5so26529355ad.3 for ; Sun, 23 Aug 2026 10:05:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787504748; x=1788109548; darn=vger.kernel.org; h=content-transfer-encoding:content-type:subject:date:cc:to:from :mime-version:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=ycrEoSFi2Doqs8i2kG7/3ZEIzApD/ac127xAYSYntJ4=; b=MikGS4UwlPt3GgX2793U+OZpQWQ5fJdzZyfItRTjHodKuVL9teBHbNMZXQ5nA9rDH6 lgwqSLehPQRqGMtIa+/2WDXmhMRuZiORuLw+ZCD7pHp/tEgKT7DE9+h/4FpK/Kh2u/CL YHts9bgsPFCPvzJ9ycoRXHW0W5bXj2SQ9Ee4jC4zdXr6A75fVi5Rcu8cBhm1EeP69ZIF OsOqkDlbsAXa5o23+xzUiNJM3xnJfbLsuE2dJewNGYpCazd0Nrp2yK8EhIl4elgJ5AT9 X+jozh/FJrZjrP4+hGC8aKNS0Fod8+/vMy9kPYKmRydSxXeNt9az+QmUoYZt+m/jiA0w Z+1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787504748; x=1788109548; h=content-transfer-encoding:content-type:subject:date:cc:to:from :mime-version:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=ycrEoSFi2Doqs8i2kG7/3ZEIzApD/ac127xAYSYntJ4=; b=mkB8rSfbjEPJHnIo0TzPVGiMklr5Z37KHwjZqAbT1fZPt9gtps2urwDYuk/CMx/Gcj 7dwjRzRxZPEqAdKKZVB9k8AsfWiU/r5aLHbNCT0iBjCeZ7QTuDdUqPyKppJ6n5Y9lxi3 4nR72t01OFA6RmVuNWxXg6dsYXSc1UKb7QJx9mR4Uu9X7oErewk9o+iUztz74xSFMuhx 37C/KMkQXepVinR79dsZKn3t5SQUZaMwN8nl4mzcNoRq5oggwRKMpf7b9jDR+TKCXwWU jxSV+zaPcUhLZJ9cAWN+nUU6J2299uoY3XnosFaaUyWsw69JHxZGkDonIqetucP8HeEo HqbQ== X-Gm-Message-State: AFuF++mMd5eCgxsI6G5gFWtcJLJRCivO3L1rRgLnV/uqLORILCFke3L4 EHIL9o8oUuWtXzaq45o48o33yZTq4r801kD2F9FiybNXxftKYWf4pfzT/pN3LtP7 X-Gm-Gg: AR+sD12HpCr4lEs5AzePw+XgG+KQN/xR7svHg7K/uyqD4FumeaX4Lju54be/k7odOIW hLG1e6q/qtZHC+5TxDkU1HUjKrTPYkz9eA2IjKEgK/AJnolAUsJ0EyLR91ApV1KqX5+gSBdi1GN EzqLKrD4G7YQVbFj9xe2r7eQTd4kQNipS4moip+ZscdYgpfstIvTqxGzTM/aCInWPiolGoGOLb/ 5AtSi4eSkzG5zlGVp0vtReJ9RLaPbFwrPbLCpXvoYsSMgT/HOQ/ko/OSB26L/GBPQ5vp6zlYGbq X+IXnqUIsAnTBO37t/mwaZQERhFKp8kkAFMOQmc6EDkkEqdSuuEkArIhvBAIc3cbO7FiVkFraKx u3qjS3HanlUhm9UyunrolvWFSCyCHBoAURVmuq5qL4qjZYLer4PWPuf2v8xMuOloSvxhBifLS2J b+P/ppqZAqI5eTaAXN30eCPFuvqZUhiIJHk/eohS4gErbSNBZg6mLsGZ5FfN+XALMyYGb4dh6lT 2KZfyZa7vek7rQ/ZVKcVI6dvjDdUmvbFBbN3K24STutX/t/7VLhYkFj X-Received: by 2002:a17:902:ec86:b0:2c6:9f66:d573 with SMTP id d9443c01a7336-2d64ae3ac9emr358931945ad.2.1787504747624; Sun, 23 Aug 2026 10:05:47 -0700 (PDT) Received: from manush ([2406:7400:94:a5e3:6c88:cdf4:5469:310]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-327f9209fafsm30744997eec.23.2026.08.23.10.05.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Aug 2026 10:05:47 -0700 (PDT) Message-ID: <6a8b286b.c86fb4cb.27e0b8.ee64@mx.google.com> X-Mailer: git-send-email-equivalent-ps1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: "Manush Prajwal" To: arnd@arndb.de, gregkh@linuxfoundation.org, fancer.lancer@gmail.com Cc: linux-kernel@vger.kernel.org Date: 23 Aug 2026 22:35:46 +0530 Subject: [PATCH v2] misc: eeprom: idt_89hpesx: fix fwnode leak in idt_get_fw_data() Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable device_for_each_child_node() takes a reference on each fwnode it=0D=0A= returns, which the loop body must release before it stops iterati= ng.=0D=0AWhen idt_ee_match_id() finds a matching EEPROM child, th= e loop breaks=0D=0Aout immediately without calling fwnode_handle_= put() on that fwnode,=0D=0Aleaking the reference.=0D=0A=0D=0ARewo= rk the loop around device_for_each_child_node_scoped() instead of= =0D=0Aadding a manual fwnode_handle_put(), so the reference is re= leased=0D=0Aautomatically on every exit path (the early break as = well as normal=0D=0Aloop completion), per Markus Elfring's review= of v1.=0D=0A=0D=0ASigned-off-by: Manush Prajwal =0D=0A---=0D=0Av2: Use device_for_each_child_node_sco= ped() instead of a manual=0D=0A fwnode_handle_put() before the= break, and use my full name in=0D=0A Signed-off-by, per Marku= s Elfring's review.=0D=0A=0D=0A drivers/misc/eeprom/idt_89hpesx.c= | 2 +-=0D=0A 1 file changed, 1 insertion(+), 1 deletion(-)=0D=0A= =0D=0Adiff --git a/drivers/misc/eeprom/idt_89hpesx.c b/drivers/mi= sc/eeprom/idt_89hpesx.c=0D=0Aindex e056d2dea..a1b2c3d4e 100644=0D=0A= --- a/drivers/misc/eeprom/idt_89hpesx.c=0D=0A+++ b/drivers/misc/e= eprom/idt_89hpesx.c=0D=0A@@ -1080,7 +1080,7 @@ static void idt_ge= t_fw_data(struct idt_89hpesx_dev *pdev)=0D=0A struct device *dev= =3D &pdev->client->dev;=0D=0A struct fwnode_handle *fwnode;=0D=0A= =0D=0A- device_for_each_child_node(dev, fwnode) {=0D=0A+ device_f= or_each_child_node_scoped(dev, fwnode) {=0D=0A ee_id =3D idt_ee= _match_id(fwnode);=0D=0A if (ee_id)=0D=0A break;=0D=0A--=0D=0A= 2.46.2.windows.1