From: Colin Ian King <colin.king@canonical.com>
To: Martin Varghese <martin.varghese@nokia.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: re: net: UDP tunnel encapsulation module for tunnelling different
Date: Tue, 25 Feb 2020 23:04:56 +0000 [thread overview]
Message-ID: <6a8cabb8-e371-d119-c2e6-d495eca016b7@canonical.com> (raw)
Hi,
Static analysis with Coverity detected an issue in function
bareudp_xmit_skb with the return of an uninitialized value in variable
err in the following commit:
commit 571912c69f0ed731bd1e071ade9dc7ca4aa52065
Author: Martin Varghese <martin.varghese@nokia.com>
Date: Mon Feb 24 10:57:50 2020 +0530
net: UDP tunnel encapsulation module for tunnelling different
protocols like MPLS, IP, NSH etc.
The analysis is as follows:
var_decl: Declaring variable err without initializer.
301 int err;
302
...
344 free_dst:
345 dst_release(&rt->dst);
Uninitialized scalar variable (UNINIT)
uninit_use: Using uninitialized value err.
346 return err;
347 }
and also in function bareudp6_xmit_skb:
var_decl: Declaring variable err without initializer.
364 int err;
365
...
404
405 free_dst:
406 dst_release(dst);
Uninitialized scalar variable (UNINIT)
uninit_use: Using uninitialized value err.
407 return err;
408 }
Colin
next reply other threads:[~2020-02-25 23:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-25 23:04 Colin Ian King [this message]
2020-02-26 4:10 ` Varghese, Martin (Nokia - IN/Bangalore)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a8cabb8-e371-d119-c2e6-d495eca016b7@canonical.com \
--to=colin.king@canonical.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.varghese@nokia.com \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®