From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f72.google.com (mail-ot1-f72.google.com [209.85.210.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 42F3913B58C for ; Wed, 26 Aug 2026 02:11:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.72 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787710295; cv=none; b=ZOkP0rKL5N66POsMVsU0U0GAUr2jOuHDxPHPhrXkErMyPGtXwVvnfZpll7lf9X/+ZsJ5nH4xEXldkE9pKp/mXZkPt3IIJ/zps2GSbLJhHy1E4EQi42rCrO38nuSL77TRB9w7CVxG2Tt1lGwOOW0s/Zi9YtQkxYiFnyQ2Bg+DXJQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787710295; c=relaxed/simple; bh=DDQWIs4pSEcFnATeRxocvv6bK0LVmtNd3T4WOZQ+1aI=; h=MIME-Version:Date:In-Reply-To:Message-ID:Subject:From:To: Content-Type; b=uxaH4/ucI7e/GZSfl/Gl/eYOvSz1aiHodV/pm/pN2cV+KQZmHucGG6OSdTkQ/TReOmd/syhnFQ27EUkjWr0I57pN+8xaG24swkGKN43k8XkojAYgfNwQf3i+5VFIbBwdgqUpD1mOo8YeE2jGCpXzrgAo+0249nkMn25AtDXK7Jc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=syzkaller.appspotmail.com; spf=pass smtp.mailfrom=M3KW2WVRGUFZ5GODRSRYTGD7.apphosting.bounces.google.com; arc=none smtp.client-ip=209.85.210.72 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=syzkaller.appspotmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=M3KW2WVRGUFZ5GODRSRYTGD7.apphosting.bounces.google.com Received: by mail-ot1-f72.google.com with SMTP id 46e09a7af769-7e9fc6dc091so436583a34.2 for ; Tue, 25 Aug 2026 19:11:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787710293; x=1788315093; h=content-type:to:from:subject:message-id:in-reply-to:date :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=685loeL+lP6YgKqD9nxfiNvX0N3Sj3UsVE7ze98CB6g=; b=UzCCpCIjMplE/6+ZWbwJ58YL1W+UWY7iIc94QYi+UxyrDmnowaT6pYIthGervBQexy dZbkfEYnwwDxE5d1AWDz8ARs8AYB675zS/OSljzCEWnMRMnXJ5cvCJ94exUnsGV9Z3vN el8xz1at2vLH8xj5G1tgtYKUz1iaRWCprqS92Zm+fJrVv9fVDnkQ5s1LiDShuUMztScM m5oFgYxNM7Z/P4GDFmOMDiK3KGp8gRro9AqJrUte2xZajAV0gHR7eN6+lc1aln/HsVPr AsSUCOxzm69/8oT/AG1p8Fcxw+7Ksf6s2dymTw8WZZ0+NFGGne90yUW1C171rNo9cZqA J1yg== X-Gm-Message-State: AFuF++kCYe8ts3BstPuRIa723ZqDvFSI3ly2WFE5ARnTGiWKORpUiApm B0dViZm9gNOuFQWTAsqT9XkhWA5FyED35lTlIuH3/31UJgWSFrCOFU+oNQ9JzsdwW9UI9sKocOV 3MPgbKlJNOb6NQceQZjr2y2f84CTcbnGBW/NioQtXVeFzAHWXTinU5vfhikU= Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Received: by 2002:a05:6820:80c1:b0:6b1:11ab:e947 with SMTP id 006d021491bc7-6b1a0589746mr3589105eaf.36.1787710293287; Tue, 25 Aug 2026 19:11:33 -0700 (PDT) Date: Tue, 25 Aug 2026 19:11:33 -0700 In-Reply-To: <6a7e2ce8.f70deec7.2acc03.000c.GAE@google.com> X-Google-Appengine-App-Id: s~syzkaller X-Google-Appengine-App-Id-Alias: syzkaller Message-ID: <6a8e4b55.a5a502ce.31d34.0124.GAE@google.com> Subject: Forwarded: Re: [syzbot] [kernel?] WARNING: kobject bug in goku_remove From: syzbot To: linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com Content-Type: text/plain; charset="UTF-8" For archival purposes, forwarding an incoming command email to linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com. *** Subject: Re: [syzbot] [kernel?] WARNING: kobject bug in goku_remove Author: chenglingfei@foxmail.com #syz test: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 3aa1dcaa4f6f5ae08936491e08bd456f331f2d40 diff --git a/drivers/usb/gadget/udc/goku_udc.c b/drivers/usb/gadget/udc/goku_udc.c index ac2a984c2f87..827f698bf222 100644 --- a/drivers/usb/gadget/udc/goku_udc.c +++ b/drivers/usb/gadget/udc/goku_udc.c @@ -20,6 +20,7 @@ // #define VERBOSE /* extra debug messages (success too) */ // #define USB_TRACE /* packet-level success messages */ +#include #include #include #include @@ -1701,7 +1702,7 @@ static irqreturn_t goku_irq(int irq, void *_dev) static void gadget_release(struct device *_dev) { - struct goku_udc *dev = dev_get_drvdata(_dev); + struct goku_udc *dev = container_of(_dev, struct goku_udc, gadget.dev); kfree(dev); } @@ -1714,12 +1715,14 @@ static void goku_remove(struct pci_dev *pdev) DBG(dev, "%s\n", __func__); - usb_del_gadget_udc(&dev->gadget); + if (dev->added) + usb_del_gadget(&dev->gadget); BUG_ON(dev->driver); #ifdef CONFIG_USB_GADGET_DEBUG_FILES - remove_proc_entry(proc_node_name, NULL); + if (dev->proc_created) + remove_proc_entry(proc_node_name, NULL); #endif if (dev->regs) udc_reset(dev); @@ -1736,6 +1739,8 @@ static void goku_remove(struct pci_dev *pdev) dev->regs = NULL; INFO(dev, "unbind\n"); + + usb_put_gadget(&dev->gadget); } /* wrap this driver around the specified pci device, but @@ -1751,16 +1756,13 @@ static int goku_probe(struct pci_dev *pdev, const struct pci_device_id *id) if (!pdev->irq) { printk(KERN_ERR "Check PCI %s IRQ setup!\n", pci_name(pdev)); - retval = -ENODEV; - goto err; + return -ENODEV; } /* alloc, and start init */ dev = kzalloc_obj(*dev); - if (!dev) { - retval = -ENOMEM; - goto err; - } + if (!dev) + return -ENOMEM; pci_set_drvdata(pdev, dev); spin_lock_init(&dev->lock); @@ -1771,6 +1773,8 @@ static int goku_probe(struct pci_dev *pdev, const struct pci_device_id *id) /* the "gadget" abstracts/virtualizes the controller */ dev->gadget.name = driver_name; + usb_initialize_gadget(&pdev->dev, &dev->gadget, gadget_release); + /* now all the pci goodies ... */ retval = pci_enable_device(pdev); if (retval < 0) { @@ -1815,21 +1819,19 @@ static int goku_probe(struct pci_dev *pdev, const struct pci_device_id *id) #ifdef CONFIG_USB_GADGET_DEBUG_FILES - proc_create_single_data(proc_node_name, 0, NULL, udc_proc_read, dev); + dev->proc_created = !!proc_create_single_data(proc_node_name, 0, NULL, + udc_proc_read, dev); #endif - retval = usb_add_gadget_udc_release(&pdev->dev, &dev->gadget, - gadget_release); + retval = usb_add_gadget(&dev->gadget); if (retval) goto err; + dev->added = 1; return 0; err: - if (dev) - goku_remove (pdev); - /* gadget_release is not registered yet, kfree explicitly */ - kfree(dev); + goku_remove(pdev); return retval; } diff --git a/drivers/usb/gadget/udc/goku_udc.h b/drivers/usb/gadget/udc/goku_udc.h index 70023d401079..f815f38304f6 100644 --- a/drivers/usb/gadget/udc/goku_udc.h +++ b/drivers/usb/gadget/udc/goku_udc.h @@ -247,7 +247,9 @@ struct goku_udc { got_region:1, req_config:1, configured:1, - enabled:1; + enabled:1, + added:1, + proc_created:1; /* pci state used to access those endpoints */ struct pci_dev *pdev; @@ -286,4 +288,3 @@ struct goku_udc { xprintk(dev , KERN_WARNING , fmt , ## args) #define INFO(dev,fmt,args...) \ xprintk(dev , KERN_INFO , fmt , ## args) -