From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f44.google.com (mail-lf1-f44.google.com [209.85.167.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E4B1D8C1F for ; Thu, 15 May 2025 01:23:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747272185; cv=none; b=nCt2TEqlzLBKkbbjMJjjuaSvUITCVJDLWLzvim4LDUGmE4sNWJoLM2IxrDNub5MWpIS+K9q+uQoVvtQi3RsXoB4vapletqzdQOZqTRD2XQiOq13RYPkqHudLsAiFbP2M/r0HhcRJV8y9YFt6DdbJZRPbSfcZdD8aXTSPWTC1Yzo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747272185; c=relaxed/simple; bh=pGj0cEG5wc65zR8K0SxXkU2TKD17QpcnRbobuZ2pGe0=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=ihkFApTanAVNsUI9xnncO8Sgq7TG2AVbM12O3r28F+XvYqRsC3nlxsxnWwcQd+EinpBpBcJBXws0Xw+3eHKghF3WO48JagJl6PwqVlGonarOhH6smsuI7yyqr0rbl6exlORVK74fj+mi/0S2Ehd3t49oJ9xOpkAH4M8PRGvAB6Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dubeyko.com; spf=pass smtp.mailfrom=dubeyko.com; dkim=pass (2048-bit key) header.d=dubeyko-com.20230601.gappssmtp.com header.i=@dubeyko-com.20230601.gappssmtp.com header.b=s03GqgLW; arc=none smtp.client-ip=209.85.167.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dubeyko.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=dubeyko.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=dubeyko-com.20230601.gappssmtp.com header.i=@dubeyko-com.20230601.gappssmtp.com header.b="s03GqgLW" Received: by mail-lf1-f44.google.com with SMTP id 2adb3069b0e04-54e9021d2b5so1767610e87.1 for ; Wed, 14 May 2025 18:23:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dubeyko-com.20230601.gappssmtp.com; s=20230601; t=1747272181; x=1747876981; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=pGj0cEG5wc65zR8K0SxXkU2TKD17QpcnRbobuZ2pGe0=; b=s03GqgLWydhoHBGZy+LbMJbHU4JizUc+29DVve7mKQdSHcJIdk5qXtmPAAzhC4E8NH XiQ3AvuHiQaKVVHyDxBmjZzOtK6b4vG9nYRWqhMJhnfs1j9i7DWNA47igGjDgIuYKaQy csbyOPQaQWDYND0d2ta0wamOp+6OGSypLt8JIvIdDiWk1zvRS2A7lB1Y/MHifvHfKba4 QnZhqvzvu7t7ot4Js1Sei6tT+Gdn0uGlWmTKZV7/J90EjIqC0utLgCZ73gw42vSSq7sO RtKLGN/B6K/r1tlJzdL96nsnfRmAKiVAFtovh7/kiw5s6J+VOp4hkR3d89xUnnB5Gg/u 8JKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747272181; x=1747876981; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=pGj0cEG5wc65zR8K0SxXkU2TKD17QpcnRbobuZ2pGe0=; b=IiuEfbYSfXxdUm4uzBbPzTIsthxXgJP4n7+1S4JUhWEPfjqTCi7XBJ0wY8E78wwlla KCvhCKM7iEwoJSnGsP0BhtD8Ke4KEkdrtwDFu5oF6/pC0tIX5Abs5Uqe0IJvyb/Fy2Vi NaQLlGB1A7qqITvS2rJCUHpqj9swyK+jizWltjTUmB+/Im5Rq7eineLHfpV3vCVbCw3y 4Riys5WeuGszfvcHLP1VMkdlDbhnLERPTmcABbQWz14Y6RahqLgdnqINHYEaOjlcmocY oAhrvtXhe7ZR0mZLBHQVhlYzXi/J3qfCpbrwDi8Uo6VBYiOsqLXB60lWsIRqgQ2dxoYh aZIA== X-Forwarded-Encrypted: i=1; AJvYcCVK+hCITQeQWAiq0nf1be8sRR+MJjagoFaAlZ0NO3bem0T5DBejpjundK9/xpUNZLXU23PwpACVR772ODI=@vger.kernel.org X-Gm-Message-State: AOJu0YznS+iQNn1w4zAr6FcTTvRK+sV+j6gCeMv2K9GqqooKYantb9Vj 61SdBjapVjrQNgk2x/hLZkRT58OfyQ9d1CjeEml65NW7RXNfQPuwIvLmm+p8/ZWSGG5rJM+fVBx uj8s= X-Gm-Gg: ASbGncvQ7FW48FBj1C2nTTwjPFkdSM90trvhR4J14KM+REoCyvxKM22QTwdXYt2ZdFr KsU5Og9hrmnclgYCwhda7Ci5pe/MUAA+0KLhfUdvFjU6VStDU2wRpZih5/QsK15kMIEOYvNa0y4 VewWN9pujdNm68+lIDvWft9LcaEu8jnRni6qOF2kIjLTAZUvc2OpUxASliobpllz5n0CfV7HLNp xivmV75kFDC5UeaW6ZHQRNmmD6betUergn28gWhpivpnzXj0hGruHjKKx1GMnU/cv/zJ+6Q8Cb3 VCDV8lmgzPRvxEBSN1C7qQzQFHhrMShsl9ermGCLx6V//x8n5+afUA== X-Google-Smtp-Source: AGHT+IEinenTYCOal04RXE8A9a0KVTDkVV4cPi1jtVXojhXDm6vALnC5HQDQ/gSdC3zTEm4/4BHAeg== X-Received: by 2002:a05:6512:6096:b0:54a:cc10:1050 with SMTP id 2adb3069b0e04-550db931e0bmr514727e87.15.1747272180380; Wed, 14 May 2025 18:23:00 -0700 (PDT) Received: from [10.24.138.144] ([91.230.138.172]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-54fc64bfb55sm2453549e87.180.2025.05.14.18.22.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 May 2025 18:22:59 -0700 (PDT) Message-ID: <6a8e52d5019df1af7fd99dcf42467ece28b5c858.camel@dubeyko.com> Subject: Re: =?UTF-8?Q?=E5=9B=9E=E5=A4=8D=3A?= [PATCH] hfs: export dbg_flags in debugfs From: Viacheslav Dubeyko To: =?UTF-8?Q?=E6=9D=8E=E6=89=AC=E9=9F=AC?= , "glaubitz@physik.fu-berlin.de" Cc: "linux-fsdevel@vger.kernel.org" , "linux-kernel@vger.kernel.org" Date: Wed, 14 May 2025 18:22:57 -0700 In-Reply-To: References: <20250507145550.425303-1-frank.li@vivo.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.1 (by Flathub.org) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Sun, 2025-05-11 at 10:45 +0000, =E6=9D=8E=E6=89=AC=E9=9F=AC wrote: > Hi Slava, >=20 > > Frankly speaking, if we would like to rework the debugging > > framework in HFS/HFS+, then I prefer to switch on pr_debug() and to > > use dynamic debug framework of Linux kernel [1]. It will provide > > the more flexible solution. >=20 > I'll try it. Sounds good! As far as I can see, it should be pretty simple fix. And I think we we need to unify the code for HFS and HFS+. I am considering to introduce HFS folder in include/linux where we can gather small duplicated code patterns of HFS/HFS+. However, for more complex duplicated code patterns, maybe, we need to consider of introduction an fs/hfs_common module or shared HFS subsystem. >=20 > By the way, I plan to export disk, mem and some statistics related > information to debugfs, just like f2fs does. Any suggestions? >=20 I think there is no troubles with it. But could you please share which particular stats would you like to keep in debugfs? Which in-core and on-disk objects fields will be stored into debugfs? Thanks, Slava.