From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f69.google.com (mail-ot1-f69.google.com [209.85.210.69]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 416B71D63E4 for ; Wed, 26 Aug 2026 03:10:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.69 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787713808; cv=none; b=Ue98REuaz8EjCWl8ErpaCASt4SBcfoDj6k8O+Y6+q337Yl/o/6MSs7ymyLcSBPHKOoOXc26StLcF3rBnyTalBjfuoPK9OdOxkFqFDoe9ZyfhI7cNz0Fkc9LiqtvnXC2OpM9vtop0LYhIpy5uwKZvrfdVBPocPynwMEKgosLHuag= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787713808; c=relaxed/simple; bh=9hYALRiPKY1IdWLm/nI3yIjdu/Yuc/Ghv+U92Rpu4yA=; h=MIME-Version:Date:In-Reply-To:Message-ID:Subject:From:To: Content-Type; b=XtqxZb5doTFHpxRPKgyJs4aQDOnLK/XoAVNdJIwrxfeqjg4d95j/Do/5cJPiUIa50HANXG33huf005VFjcCNDBmrvEPYq4TEJuexrMvSMETT+84C/QQgbSroQnbjGX6Z6pKzGGIMMweBUOODQpfqaaVkTzRs5rUQNLKo84SzFUQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=syzkaller.appspotmail.com; spf=pass smtp.mailfrom=M3KW2WVRGUFZ5GODRSRYTGD7.apphosting.bounces.google.com; arc=none smtp.client-ip=209.85.210.69 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=syzkaller.appspotmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=M3KW2WVRGUFZ5GODRSRYTGD7.apphosting.bounces.google.com Received: by mail-ot1-f69.google.com with SMTP id 46e09a7af769-7ee1e335245so658834a34.1 for ; Tue, 25 Aug 2026 20:10:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787713806; x=1788318606; h=content-type:to:from:subject:message-id:in-reply-to:date :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=xUP/9NrUg9KLMbVcYRNMDcFiUjxQPKoU3gp/xsa4z1Q=; b=VNUYCYFzsC1R9eHBuxisHB3VjO4JsZZpeNecULbiT8vxulf54Ov2hVF0Jt/j4lG4A8 p8FdBITZ32x+RwE0CeFiWLA0ivqf/WH7e6wRtYrhlqPq8zF6o+dbnc1v2CAh9dGRyzLc II0D/daApSmo7eMN0l1l/kkWo8rIbI84LepEQqfdASJtRXt7VvzASOweDvchC03RUuVI mLoJk2XuEqObWk7uA3c9VZjbkiF4P83j2v9zn9ZzFsW7lJEIQxgOcvYDqgLhL/HAuPjH eqHUEuWGWf84GGVKdcWyyGDgiu8GZGIiU6nQF13sD12xD53QCQvGboxpPjWlILz3p6ny jJmA== X-Gm-Message-State: AFuF++mmRBjxwolvzapwfiMQHIFErSbK2f8uYZEXqxsLyspQfJdFVNoz pmSSMwqPe5hr9NqN9PL33WEmCexSxJ/VTHbA6mW/f5S2W+OqjhH32AtTnsjhSZOpAIVegmh7hBz H28p9oMODJLZFng9BPir0SH0oc0TfZYkE87aCW3qFgEuZ6gEsYtIMIGKW0VQ= Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Received: by 2002:a05:6820:151c:b0:6b1:4147:4e16 with SMTP id 006d021491bc7-6b1a048b9cfmr3964787eaf.22.1787713806194; Tue, 25 Aug 2026 20:10:06 -0700 (PDT) Date: Tue, 25 Aug 2026 20:10:06 -0700 In-Reply-To: <6a7e2ce8.f70deec7.2acc03.000c.GAE@google.com> X-Google-Appengine-App-Id: s~syzkaller X-Google-Appengine-App-Id-Alias: syzkaller Message-ID: <6a8e590e.91706f20.ef82.0012.GAE@google.com> Subject: Forwarded: Re: [syzbot] [kernel?] WARNING: kobject bug in goku_remove From: syzbot To: linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com Content-Type: text/plain; charset="UTF-8" For archival purposes, forwarding an incoming command email to linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com. *** Subject: Re: [syzbot] [kernel?] WARNING: kobject bug in goku_remove Author: chenglingfei@foxmail.com #syz test: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 3aa1dcaa4f6f5ae08936491e08bd456f331f2d40 diff --git a/drivers/usb/gadget/udc/goku_udc.c b/drivers/usb/gadget/udc/goku_udc.c index ac2a984c2f87..7af6da63e83b 100644 --- a/drivers/usb/gadget/udc/goku_udc.c +++ b/drivers/usb/gadget/udc/goku_udc.c @@ -20,6 +20,7 @@ // #define VERBOSE /* extra debug messages (success too) */ // #define USB_TRACE /* packet-level success messages */ +#include #include #include #include @@ -1052,8 +1053,6 @@ static inline const char *dmastr(void) #ifdef CONFIG_USB_GADGET_DEBUG_FILES -static const char proc_node_name [] = "driver/udc"; - #define FOURBITS "%s%s%s%s" #define EIGHTBITS FOURBITS FOURBITS @@ -1701,7 +1700,7 @@ static irqreturn_t goku_irq(int irq, void *_dev) static void gadget_release(struct device *_dev) { - struct goku_udc *dev = dev_get_drvdata(_dev); + struct goku_udc *dev = container_of(_dev, struct goku_udc, gadget.dev); kfree(dev); } @@ -1714,12 +1713,13 @@ static void goku_remove(struct pci_dev *pdev) DBG(dev, "%s\n", __func__); - usb_del_gadget_udc(&dev->gadget); + if (dev->added) + usb_del_gadget(&dev->gadget); BUG_ON(dev->driver); #ifdef CONFIG_USB_GADGET_DEBUG_FILES - remove_proc_entry(proc_node_name, NULL); + proc_remove(dev->proc_entry); #endif if (dev->regs) udc_reset(dev); @@ -1736,6 +1736,8 @@ static void goku_remove(struct pci_dev *pdev) dev->regs = NULL; INFO(dev, "unbind\n"); + + usb_put_gadget(&dev->gadget); } /* wrap this driver around the specified pci device, but @@ -1748,19 +1750,19 @@ static int goku_probe(struct pci_dev *pdev, const struct pci_device_id *id) unsigned long resource, len; void __iomem *base = NULL; int retval; +#ifdef CONFIG_USB_GADGET_DEBUG_FILES + char proc_node_name[64]; +#endif if (!pdev->irq) { printk(KERN_ERR "Check PCI %s IRQ setup!\n", pci_name(pdev)); - retval = -ENODEV; - goto err; + return -ENODEV; } /* alloc, and start init */ dev = kzalloc_obj(*dev); - if (!dev) { - retval = -ENOMEM; - goto err; - } + if (!dev) + return -ENOMEM; pci_set_drvdata(pdev, dev); spin_lock_init(&dev->lock); @@ -1771,6 +1773,8 @@ static int goku_probe(struct pci_dev *pdev, const struct pci_device_id *id) /* the "gadget" abstracts/virtualizes the controller */ dev->gadget.name = driver_name; + usb_initialize_gadget(&pdev->dev, &dev->gadget, gadget_release); + /* now all the pci goodies ... */ retval = pci_enable_device(pdev); if (retval < 0) { @@ -1815,21 +1819,21 @@ static int goku_probe(struct pci_dev *pdev, const struct pci_device_id *id) #ifdef CONFIG_USB_GADGET_DEBUG_FILES - proc_create_single_data(proc_node_name, 0, NULL, udc_proc_read, dev); + snprintf(proc_node_name, sizeof(proc_node_name), "driver/goku_udc-%s", + pci_name(pdev)); + dev->proc_entry = proc_create_single_data(proc_node_name, 0, NULL, + udc_proc_read, dev); #endif - retval = usb_add_gadget_udc_release(&pdev->dev, &dev->gadget, - gadget_release); + retval = usb_add_gadget(&dev->gadget); if (retval) goto err; + dev->added = 1; return 0; err: - if (dev) - goku_remove (pdev); - /* gadget_release is not registered yet, kfree explicitly */ - kfree(dev); + goku_remove(pdev); return retval; } diff --git a/drivers/usb/gadget/udc/goku_udc.h b/drivers/usb/gadget/udc/goku_udc.h index 70023d401079..0ca2d49d25ba 100644 --- a/drivers/usb/gadget/udc/goku_udc.h +++ b/drivers/usb/gadget/udc/goku_udc.h @@ -247,7 +247,12 @@ struct goku_udc { got_region:1, req_config:1, configured:1, - enabled:1; + enabled:1, + added:1; + +#ifdef CONFIG_USB_GADGET_DEBUG_FILES + struct proc_dir_entry *proc_entry; +#endif /* pci state used to access those endpoints */ struct pci_dev *pdev; @@ -286,4 +291,3 @@ struct goku_udc { xprintk(dev , KERN_WARNING , fmt , ## args) #define INFO(dev,fmt,args...) \ xprintk(dev , KERN_INFO , fmt , ## args) -