From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C80DF12F585 for ; Fri, 29 May 2026 02:16:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=198.175.65.21 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780021006; cv=fail; b=hkkhpNIfcbE4b/54IAFtpc2giHQBp4ABmMPhMtnTBAPYQNwbkOfe3vPAz0XOs0m2VaF3XlDFzDt4TOW6lPNctc/SHS2xXpfZXvAnFAfLPMq1Yk+iLu0ipZKUp7sHNbxUUpsrMSY3PCMK8Nv/FC1AEEMGY3xvxfTBuvMJL65KU18= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780021006; c=relaxed/simple; bh=az7Zxxp5Qre8ipMxn1BtvmDrfg8ak6fy7z8EQnIlNI4=; h=Message-ID:Date:Subject:To:CC:References:From:In-Reply-To: Content-Type:MIME-Version; b=P5RsyDnD06Q8+sfPQvwsDH40xLKKAiaXwYh/n7Vx1c6GItDqn8rprWPw9k48dX2WbEvpJu30QD94zOii6ZyzTN2B+dnfTCF5LP/Vsqke7Di2SUXKvJOnauggHuaywLv+SENH9KzpTU3WIsPL2BIT6rYt6Py6z8gsZ6NwuqxTiQk= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=dEDhil/8; arc=fail smtp.client-ip=198.175.65.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="dEDhil/8" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1780021004; x=1811557004; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=az7Zxxp5Qre8ipMxn1BtvmDrfg8ak6fy7z8EQnIlNI4=; b=dEDhil/8c47bj57LHraNpSjXOe97n0vM1kRm8Ir1aC36ub22/AxJyjqq mludysrPBuymEXcy7SG417rm/lvrslHFn+mFV/+GYqhVcqK83/vowK+e7 iW4bAn8Uruu2CKgzFp6q3oXMTfAxnEmDXXZhCZRcqmp4KG9+LAXCtZTYH LmkuvntdHjTe1q0DHm2N1QDTdl8w+Jcga5os32nMorS05ey2+r2BwDiXj FlgfXg2CWTcOwLRQDkPMEh0H2d//5ePdVh8gvmAWPFP8CDKaiGLsU0lz9 s14fVZswmOv7FoyliLjD+PH3V0mP1sUEWsud4CVV1bS3YAZs3DxkXt2ST g==; X-CSE-ConnectionGUID: d7K/P0YIQ0iiHRRechojDg== X-CSE-MsgGUID: u/OKHUO4REGRX7FBEeTsVA== X-IronPort-AV: E=McAfee;i="6800,10657,11800"; a="80770510" X-IronPort-AV: E=Sophos;i="6.24,174,1774335600"; d="scan'208";a="80770510" Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by orvoesa113.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 May 2026 19:16:44 -0700 X-CSE-ConnectionGUID: 386ORauNSNO/T993mLWGnA== X-CSE-MsgGUID: asojna4nRZy95k0ffRNTlg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.24,174,1774335600"; d="scan'208";a="244535401" Received: from orsmsx901.amr.corp.intel.com ([10.22.229.23]) by fmviesa004.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 May 2026 19:16:44 -0700 Received: from ORSMSX902.amr.corp.intel.com (10.22.229.24) by ORSMSX901.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Thu, 28 May 2026 19:16:43 -0700 Received: from ORSEDG902.ED.cps.intel.com (10.7.248.12) by ORSMSX902.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37 via Frontend Transport; Thu, 28 May 2026 19:16:43 -0700 Received: from CO1PR03CU002.outbound.protection.outlook.com (52.101.46.46) by edgegateway.intel.com (134.134.137.112) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Thu, 28 May 2026 19:16:43 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Kn6IQhGk153fhzwoZ3FC7LqhDa3YPMzW/YC9htNE1MNAgog5EqiN7mzFaohHbaBklosvv2IkgH/9y2Oz/4PB8dPpJ8YKR16z691uV66lEmPiuJZPLdLhOrVX52pj+AqXIIc925xHn1c3N8LhP3HxnXNpceKiruPnjECNaMlDsDetblV89wK8kdOnC+JqIbrhlt7/61aFVG7F/3yt3pVyKkd9SV97DMz/QhOtD94F5sMlJ0xT7EHMyTV3VT5ahz2pZFXk6GuGTIVE8ygrECWEp2N7S06DnFIjNx4S8Wkp0RhPgGIGR89Pm5VYPyJTvnvTw4lclq8A3XtQXrRyEUOhjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eOguKf4J+e/XkAm/w3XumNCfYRVFCHNkiF8ihjyb59U=; b=C8+DNix+VKNrGXKyZFb+58NDlKTVE67df+MvsyA3oDQrX2w61bk68LcPwHAmPKDkuj7jufNIfmaIYYz/WkWFNBixzLWPp0pHwFsTTF7SauqpNVxXhAat+dO6OSRiCofmJnywIxeXbKD4Dp/a4uTDmQJD4H4HT57f1Cl3Rys3rpKs/N/yGSfs8PaauYcQ1GLeIhq3q119NBR9KLUYM2HeIZjNu9qqXC2Ag095GfJa8hHCSO9tXxTfABGl18a15EsfI8kMsIiozz8gBkJLN8ehz8UlEDQZ7PQkvrOr+m/rLCZdmQKY48OSTSUD2tdIzQWB3mvcsmiMLaLxsUYdexA3Yg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH7PR11MB6005.namprd11.prod.outlook.com (2603:10b6:510:1e0::19) by IA1PR11MB7892.namprd11.prod.outlook.com (2603:10b6:208:3fc::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.71.13; Fri, 29 May 2026 02:16:40 +0000 Received: from PH7PR11MB6005.namprd11.prod.outlook.com ([fe80::4f64:b0b5:4ed2:39ae]) by PH7PR11MB6005.namprd11.prod.outlook.com ([fe80::4f64:b0b5:4ed2:39ae%6]) with mapi id 15.21.0071.011; Fri, 29 May 2026 02:16:40 +0000 Message-ID: <6a91c0bf-466a-4c1d-a3dc-f81653c62832@intel.com> Date: Fri, 29 May 2026 10:16:32 +0800 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 1/6] x86/resctrl: Parse ACPI ERDT table and map RMDD domains by L3 cache ID To: "Luck, Tony" CC: , , , , , , , , , , , References: <44d0db816f964ffb51367cbf0a4bb982786cac8c.1779872016.git.yu.c.chen@intel.com> Content-Language: en-US From: "Chen, Yu C" In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: TP0P295CA0048.TWNP295.PROD.OUTLOOK.COM (2603:1096:910:3::19) To PH7PR11MB6005.namprd11.prod.outlook.com (2603:10b6:510:1e0::19) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH7PR11MB6005:EE_|IA1PR11MB7892:EE_ X-MS-Office365-Filtering-Correlation-Id: 7c070123-71c8-45ea-e2f9-08debd2851a3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|366016|1800799024|56012099006|4143699003|11063799006|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: OjSg7cpDfpLvD+3uyLr4GNWgilXXud6wL/wD7TqSNiXFQkzg+Eilz8JyxvPmdsHUi8R8mRSvgYWbe2bV4SOV3dAP7vCYOUeA+IlApQU3qdYN6cvH5sZi2aYR/AJPy++eDZeKIIvoXazKXi+7lpTGFZx1uqk/1AXz7etcAfmnVyJMtaUYUwaxOXcvJtv6ssuoeH508oSNCGLyeA7IseT2Y1EYp0brONVfbdTzvYCAfGFZ31swbXzPLgr9AGRGAZk76siFn8fMlUy/chkYe4Zj1VKTlUDuduubrcMovnkwhN++TYL/mdd/D4N8SgAFs+YxK3deH6p/R2pXEx8ibnzaxlFleHuZ9wG6elKyE8btYpIKs05tybl/x+J1eQXe9VqgIWdFudUC23uy/kux2I8mKmj5+P9ufanspXkSehSoZo+UAI14dLTI+ysfKwJeG5dVlsJ4Gi/enYjbUKKFqXX+kcDhvLo96LQ/JcEZJo5AKdmrFzR87W/JluVmBboKyuPt00M9XLqvcnRzt5Ale6fVR8w3IpTlbVz21l6JiSom7k+hakPEPjHbbL/JbEOqQT++90eFstThXvjJ4Izi1E0jLgmSkXvZoX2R/He5hEkZDYUPJwsich0zxYMC8Sp5Vv0lMe044wLqkWlgiq9HyYKn9i57DWYFgL/w+HwD9D79JMVaPZ62cqQ8wvLeTUhJ+x7wPES0YeHpjAelNCQQ0oHukQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH7PR11MB6005.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(7416014)(366016)(1800799024)(56012099006)(4143699003)(11063799006)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WXRqTldtbEt2QVhhMkhzaVphV3hWV1RzNWMyM0YvcFlWRElONFN0L3lDdTBS?= =?utf-8?B?OEFleFByMk9zeDkrdmZxSlhaWGpqaEdyOGhBZ0djN3dKd2VwSzBXRlMxNms3?= =?utf-8?B?b1FVakhuYWR4Q3dad0JZMnNUelBiQXA3b3VJb2RIYk04TjlNdll6VWIyZDl2?= =?utf-8?B?UHlIc3h4YWhkVEIzdDkxODl1NHhxREN6emZwNDFObVZBOWR0Zi9QSk9YSlJp?= =?utf-8?B?WFdXLytYU3pFbHBxKzhDQ0dPTmFCVW5xQk5uZkFyamw5c0R4cTh5U1llUHZV?= =?utf-8?B?d0NFU1p0S1NDam1iZVJmMjZEM1FRWS9sdmNjWmIvNDdrQWtQbHFLRWVzYkxh?= =?utf-8?B?MEp1MlRDRXo5U2pSS2M5WThONklRQnZjaVlUZ2lORlhaa1hQY2FCUXZjZ1BD?= =?utf-8?B?Rk5zZm9UbVlBQXpIVC9MOGl5TlR0Qkh4MENwUTZZeVk5OGkwazlJcm14MU9u?= =?utf-8?B?MjcxVVN4SlN3SWNGaEppSlV2RXVNcGZDekozdVBycVZqeTZDMGdJVWd4dkxh?= =?utf-8?B?d083TlpXbWxXS2gvTWNDTDEzTFdSNXd0Qi9zZFVYTDB1enJXbVVwOU1EN3g5?= =?utf-8?B?cTltbXZ5b0RUY0p3Tmd6bnFSVnpNZHUvcGhhYmhZM0x4TDlZVThRVFM0V1Zx?= =?utf-8?B?YjZ4bDd6NVd0NzMvSWR5b0U1N2xLemhFdVR6NnA5N3g4Q1Y1Q0ZzdmptMHYr?= =?utf-8?B?ZkY2R2JJcys2cVY2Y1RuaEZMMFc0MjIrZnFqaThjL21vOHpWbHgvNnZUbUVw?= =?utf-8?B?aytrb0hDL0dOUUZmZHQxYnh0anRKMXZxdU84Sk5HUE96S2tSTHZqcU51TldB?= =?utf-8?B?cDh2Sy9NWnpqeDFYRm9RNkhCOWFXT0VYanVMVW5NZmZtc1dJTmx1UEQzN2pq?= =?utf-8?B?aVJNZEI1N1B5Q0pwb1pTdDZKUnRYaXhIS2VwQUZDYi94UHd4d2p5d2laVGRM?= =?utf-8?B?MWQrNWdoczJSSnNKUVFFc3QxclRQL0k4R2RDWEFnRGZxb2RNR1VySHJVd0Ja?= =?utf-8?B?QjYvczA4cVFLdDQ0UkpXN05NNGJSZElRTGRnbXlRNFo3N25XOEs3MHNUWjEz?= =?utf-8?B?THYreE1palhhQW51UVVRMzA2QWdCRFdTL2VwZjl6b1VsYlJsWkpzd2xLK24r?= =?utf-8?B?S1dxZUp3dUZQcnhZcmlyOUdNQmhJbElTZERLMDlSSjNVL1N2Z3FVSnpMazNp?= =?utf-8?B?N3EyMzA5QnhMQkNnUEtWOTlzVnVPeVZnZTBVZGlxMlZhbHNHYUlHMlM1OHNN?= =?utf-8?B?ZDk2REZ2Y2grQTBPZDc3NGpwRVBKOGtFR0lKakloUkwxV0luQ3pzdmNhOHdv?= =?utf-8?B?TVAyY0ZQMitkbVZ2SFhqYjlQNnBUUnFpaE1lendNSVVEYVVDRzZlNzZ6bGpw?= =?utf-8?B?eS9jVnk3ci9QM3JiWmtCMjFYcStBcU1IeXBNVGVDR2c1UnNFWXcraU13Tjlj?= =?utf-8?B?YjBDbFEvK0RCRzg3aEtmcGR6U2V1cm1sYnF2cXJTRUNDaHRWTDNiVUpUVnFr?= =?utf-8?B?dDdBZHdPQk9kQ0JKWlVMZXhwR25xbUxaQmhYVEg0dUovM3I1QlJnVHhOWkRZ?= =?utf-8?B?YjR2c21tdWtXcXAzLzZwNGRiazQ5bzRCTStjL01aMmx4ZE41cjBvRTRXblhD?= =?utf-8?B?cFZsRmxIenBOMHhFOGNTMDFwK242VjRqNGVKZjBFMi9vQ0RUYzdCK0JyVXhS?= =?utf-8?B?N0JxR3NIc0hDd1BxOFJLQ3JidWh2VWMxdHJIRWxaTXFZa0FmclVWWnlJY1FV?= =?utf-8?B?emI4UXJyejRNUlZZUVl3bTFtOXJjdDF0blB1WTFzQitIZENJaEtCSnkwQ01G?= =?utf-8?B?YlJ0cGhlWXp4RXBBZ3QxcXNBWXBSSmJHOWhsSExDSmFQamIzMGxuMWtWZ29C?= =?utf-8?B?endYRHlUNzhQUVpKQ2FRc3I2b1BZbGhZUmlOb2dueE9ORnZVU3Vzb0RvRWR1?= =?utf-8?B?MVBPMCt1MmwxTHFtQnRQQVFrSEFnemxZckhDZE0rMlVKaEZCQjZrZDZZWm91?= =?utf-8?B?Q0RLZ2JhVmx4ZHNIYUlUZm5IQ2hmREpOWXpReW0xcXpyYUtLRWRHUXBBc0xq?= =?utf-8?B?bVpseC9vY1kyQlZLM2JOQThGd20wSjArUzFXMDBBQUNKNFFtemdVOWRaTHVN?= =?utf-8?B?TVl4RjllUmpQd3FlemhWY1hLN21ha2xEbEFKWmIxNDhxWmVEN2plZGt6dlo3?= =?utf-8?B?UFoxMm8xWGYvT08yU0sxNDdCYlMyUGNpMUcydHhpbEpBSVdqMVJEYnVHNDk4?= =?utf-8?B?NFhWSGZJMnR5ZEFmdEIwUlg3SXlsZHd4Z0ZPMVRvZE51UGRGV04rQmFCdUZ2?= =?utf-8?B?MWV6aG0vQ3cwb0FadW95T056dXRYeUZJRHllWlc2L2hUM0trS0VSZz09?= X-Exchange-RoutingPolicyChecked: Vb4d0zFmMN27tqMA3bxxVmUE6+8U1Dmllm4K+CNSuXGVqn/e6AnG5fB1bwi2mDaz0Tl1ls4sen/QpstKlDZbh9bmY5pK1/fVHQKM278QlSE/KXXlSHttFClfSISmYdu1zD12/xFBabKySFHHTSx9ocdpSU7GNCCVbYSgWj2gA5Mfr+iMntc4jOd1jiiK34uHGR39uYgxVA44UxZWCAjkx2Opo8pwyNDWs21SaEiOYg8/rYisADFGWYzT/n+FwWp3JfCzcFvXTCtPXVrPpHwzuktP2/pY+VXE+xB9R0Ce5Lyg/0LtG1E/EUwslB3V5Jow1DeMY6haFrn5eW5xtg+TVQ== X-MS-Exchange-CrossTenant-Network-Message-Id: 7c070123-71c8-45ea-e2f9-08debd2851a3 X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB6005.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 May 2026 02:16:40.3051 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: fCnU97fv0GRfhLq1/PUewgGk22S3oQ3U69fShCO92nosDw8Up1dllyBTWw3JdQQ1ggOff9lJHnvJueg4yYMglw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB7892 X-OriginatorOrg: intel.com On 5/29/2026 4:21 AM, Luck, Tony wrote: > On Wed, May 27, 2026 at 05:26:54PM +0800, Chen Yu wrote: >> +static __init int get_l3_cache_id_from_cacd(struct acpi_erdt_cacd *cacd) >> +{ >> + int num_ids, cpu, online_cpu = -1, cache_id = -1, tmp; >> + struct cacheinfo *ci; >> + >> + if (cacd->header.length < sizeof(*cacd) + sizeof(cacd->X2APICIDS[0])) { >> + pr_warn(FW_BUG "Invalid x2apicid CACD table\n"); >> + return -1; >> + } >> + >> + num_ids = (cacd->header.length - sizeof(*cacd)) / sizeof(cacd->X2APICIDS[0]); >> + >> + guard(cpus_read_lock)(); > > This file should #include (maybe some other headers > too) to follow the "include-what-you-use" best practice (which is only > lightly enforced in the kernel - but saves pain when some refactor > breaks your code because the implicit chain of includes is changed). > Thanks Tony, will fix this. Appreciate the guidance on IWYU. thanks, Chenyu