From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 566A3C0015E for ; Mon, 17 Jul 2023 15:26:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231508AbjGQP0h (ORCPT ); Mon, 17 Jul 2023 11:26:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57552 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231671AbjGQP0Q (ORCPT ); Mon, 17 Jul 2023 11:26:16 -0400 Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id D9FFF30D7 for ; Mon, 17 Jul 2023 08:25:24 -0700 (PDT) Received: from loongson.cn (unknown [10.20.42.43]) by gateway (Coremail) with SMTP id _____8CxtPBTXbVkDv4FAA--.16296S3; Mon, 17 Jul 2023 23:25:07 +0800 (CST) Received: from [10.20.42.43] (unknown [10.20.42.43]) by localhost.localdomain (Coremail) with SMTP id AQAAf8BxB81NXbVkeaUxAA--.64669S3; Mon, 17 Jul 2023 23:25:05 +0800 (CST) Message-ID: <6a92cbb7-e98b-e93c-6e62-ceddd0dfbc06@loongson.cn> Date: Mon, 17 Jul 2023 23:24:13 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 00/11] drm: kunit: Switch to kunit actions Content-Language: en-US To: Maxime Ripard , David Airlie , Daniel Vetter , Maarten Lankhorst , Thomas Zimmermann , Emma Anholt Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org References: <20230710-kms-kunit-actions-rework-v1-0-722c58d72c72@kernel.org> From: suijingfeng In-Reply-To: <20230710-kms-kunit-actions-rework-v1-0-722c58d72c72@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CM-TRANSID: AQAAf8BxB81NXbVkeaUxAA--.64669S3 X-CM-SenderInfo: xvxlyxpqjiv03j6o00pqjv00gofq/ X-Coremail-Antispam: 1Uk129KBj93XoW7tr15Ww45XF4xCryruFW7Awc_yoW8tFyrpr 43JFy3trW8tFsxJwnxuw40y3Wfua1kt34Svr97Zw15Ars0yF9xArn3Kw15WFW5GrWrZrn2 vw1ftry3C3WDAFXCm3ZEXasCq-sJn29KB7ZKAUJUUUUx529EdanIXcx71UUUUU7KY7ZEXa sCq-sGcSsGvfJ3Ic02F40EFcxC0VAKzVAqx4xG6I80ebIjqfuFe4nvWSU5nxnvy29KBjDU 0xBIdaVrnRJUUUPSb4IE77IF4wAFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2 IYs7xG6rWj6s0DM7CIcVAFz4kK6r1Y6r17M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48v e4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Jr0_JF4l84ACjcxK6xIIjxv20xvEc7CjxVAFwI 0_Jr0_Gr1l84ACjcxK6I8E87Iv67AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVCY1x0267AK xVWxJr0_GcWln4kS14v26r126r1DM2AIxVAIcxkEcVAq07x20xvEncxIr21l57IF6xkI12 xvs2x26I8E6xACxx1l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj6xIIjxv20xvE14v26r12 6r1DMcIj6I8E87Iv67AKxVWxJVW8Jr1lOx8S6xCaFVCjc4AY6r1j6r4UM4x0Y48IcVAKI4 8JMxk0xIA0c2IEe2xFo4CEbIxvr21lc7CjxVAaw2AFwI0_JF0_Jw1l42xK82IYc2Ij64vI r41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1l4IxYO2xFxVAFwI0_JF0_Jw1lx2IqxVAqx4xG67 AKxVWUJVWUGwC20s026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r1q6r43MIIY rxkI7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6xkF7I0E14 v26r1j6r4UMIIF0xvE42xK8VAvwI8IcIk0rVWUJVWUCwCI42IY6I8E87Iv67AKxVWxJVW8 Jr1lIxAIcVC2z280aVCY1x0267AKxVW8JVW8JrUvcSsGvfC2KfnxnUUI43ZEXa7IU8oGQD UUUUU== Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 2023/7/10 15:47, Maxime Ripard wrote: > Hi, > > Since v6.5-rc1, kunit gained a devm/drmm-like mechanism that makes tests > resources much easier to cleanup. > > This series converts the existing tests to use those new actions were > relevant. Is the word 'were' here means that 'where' relevant ? Or it is means that it were relevant, after applied you patch it is not relevant anymore ? > Let me know what you think, > Maxime > > Signed-off-by: Maxime Ripard > --- > Maxime Ripard (11): > drm/tests: helpers: Switch to kunit actions > drm/tests: client-modeset: Remove call to drm_kunit_helper_free_device() > drm/tests: modes: Remove call to drm_kunit_helper_free_device() > drm/tests: probe-helper: Remove call to drm_kunit_helper_free_device() > drm/tests: helpers: Create an helper to allocate a locking ctx > drm/tests: helpers: Create an helper to allocate an atomic state a helper or an helper ? Should this two patch be re-titled as following ? I search it on the internet[1], mostly using a helper. drm/tests: helpers: Create a helper to allocate a locking ctx drm/tests: helpers: Create a helper to allocate an atomic state [1] https://www.a-or-an.com/a_an/helper Sorry about the noise if I'm wrong. > drm/vc4: tests: pv-muxing: Remove call to drm_kunit_helper_free_device() > drm/vc4: tests: mock: Use a kunit action to unregister DRM device > drm/vc4: tests: pv-muxing: Switch to managed locking init > drm/vc4: tests: Switch to atomic state allocation helper > drm/vc4: tests: pv-muxing: Document test scenario > > drivers/gpu/drm/tests/drm_client_modeset_test.c | 8 -- > drivers/gpu/drm/tests/drm_kunit_helpers.c | 112 ++++++++++++++++++++++- > drivers/gpu/drm/tests/drm_modes_test.c | 8 -- > drivers/gpu/drm/tests/drm_probe_helper_test.c | 8 -- > drivers/gpu/drm/vc4/tests/vc4_mock.c | 5 ++ > drivers/gpu/drm/vc4/tests/vc4_test_pv_muxing.c | 115 +++++++++--------------- > include/drm/drm_kunit_helpers.h | 7 ++ > 7 files changed, 162 insertions(+), 101 deletions(-) > --- > base-commit: 06c2afb862f9da8dc5efa4b6076a0e48c3fbaaa5 > change-id: 20230710-kms-kunit-actions-rework-5d163762c93b > > Best regards,