From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 980AC4EF13F for ; Thu, 17 Sep 2026 17:16:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789665416; cv=none; b=e+QMZtMS7E0hgOPurEkkLHQ5/YPgqcmU1uZN8JTX3etearJhvs8CW6Zv/KFwrcUvwCg/minJ6O/Q7ZORSwHeYr473AHalXldU8KSww9nyRPHX97C3yfki6NUTnch8yqBSMFEsC4cn2TS1RQD1vubOKAnMQmj++znWB9VY08FGTw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789665416; c=relaxed/simple; bh=yMFfWGZ+PoRdGpMVU94qylirYpyWyHJ+HDsE48mS7L8=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=FMD/8MCxif6/dxkF3X8Cdp2TwsU/GJrgLehFxfDs+OWhhDrZ8uyNIK46x5YefDcnf5dnh3N/JPrK3nmhqLW7mrNG7tyj2WDEc0floJPd65TJzBihiQ/Gu009wgqohcFA4aryWnw/aq4Wr5zv7DCfPgPYs40YHcAGJz6NVrtUlEU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Xu9MhY/k; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=CrhSFGZb; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Xu9MhY/k"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="CrhSFGZb" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1789665412; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uC98k1DYNd0VN7AyfHY1vWTx0QXpdNax6z4iHwpWNLQ=; b=Xu9MhY/kOVKXC+9wySmIjRXmxhr89Ts+V8KS54D1v1ZbBe7KJvgKkIxGoKg419QV2oo3t1 v+JRU5dGlXaeWcjZJTtn97Ynv3KGD7g76OP7ubgBrNeRdSui5xT1M/9xqqLePWuZWijodn /pBCPcPn8oX/PPbj/h8fvw15hNmbRG0= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-554-JAqJfbLcOzKSY0d_sbvDJQ-1; Thu, 17 Sep 2026 13:16:51 -0400 X-MC-Unique: JAqJfbLcOzKSY0d_sbvDJQ-1 X-Mimecast-MFC-AGG-ID: JAqJfbLcOzKSY0d_sbvDJQ_1789665411 Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-90e7de22fddso21138516d6.3 for ; Thu, 17 Sep 2026 10:16:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1789665411; x=1790270211; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:content-type :references:in-reply-to:date:cc:to:from:subject:message-id:from:to :cc:subject:date:message-id:reply-to:content-type; bh=uC98k1DYNd0VN7AyfHY1vWTx0QXpdNax6z4iHwpWNLQ=; b=CrhSFGZbN8lyNYVZ2WfZ3829RDkLCUUNPmb2jLchkf/2/e7OtzX+e5cyifVbPoWQse rukkruRgZJCKfHxSR9PaDwV/o2Km8b9fwa274/nTH+Kbx+jR8K1WLPJH3A36KQjrcOLZ 9re03Ohc5Zyhn13PLNucNGvqFdZrTlEfGGBmumUxiXnodm5pqDEa12b1vQ1qbgDv3DU+ yoNbJYX6IsgC5NurQPallQ+XId3ZFVHFBxxbAvyksUrSkQOy5mqm+z1gFMrY4CROgJvA CLeqGDEq7QlFH72qINw6FA6JmdiSzwlKCOYfbJvtcV52Fqx5RteDkxay0MNzUYh3r+Xd AOug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789665411; x=1790270211; h=mime-version:user-agent:content-transfer-encoding:content-type :references:in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=uC98k1DYNd0VN7AyfHY1vWTx0QXpdNax6z4iHwpWNLQ=; b=Y+T1+v3ifmnQGSEkXJXh8eUz7bMC6w/1YxjFWtLs4Yb/JRhTGPCUfUEKvqcf1EwMxf VJRo+hMj4jFIQGHEPyIyr/OUCqxviKa9NTI8eubd9vD3vU6r6VJcVjxbc6ELQe0ZJy+3 b6rcK/0XsemwXVdEvYj9pPmPglOUFKWy8V5gazOPoDJzC8h7IGEZlm/RDNdfg5mNnSR4 1tmZbzaC7ya979XNQO83v7DnZd6h8sI68DDaQwga4fFqJqVYK5k6RBDpnhK7rxankF+j jPsTWPbZgFIVaA6HWTTHYFVg3yDTBdJcDqMSUjwD/7RkPRlw1hecYy0JMxXFbhE55yov EH2A== X-Forwarded-Encrypted: i=1; AKwUvBwxYiYqJTrBBZ7NXbBtUEwqoHh3DcZ+FGjhIngJ5/Bha4GVzHJwzZE/GYJiKh6PyTT92xr3KPdLK/bBx1g=@vger.kernel.org X-Gm-Message-State: AFuF++ng5PNmDhOKbXncqSD7iupHgEvyp0TnB1IsvNytgMXwUCVFAiEI ZFbxwFTckYgzdT7ACFabanIc8is3zouE29+PxvM+02FZeKRZx9nG+kmx846kTTfr737UwBlEvWT ijvs41HKezZoK+hshphvT0pkvwsH/bQYq1qs1tUJRzi62HI18/c4PL8Y/RTZzSwM5rA== X-Gm-Gg: AYBFou0SfhgTWMyV7SzPLGEhQC0IxHiZbBNVH3/yefY1tUUq29WGdfatGWuBXyngh8g T4s9pR57W0ptlOC2RxLpTB9dfEL4hum5Kz6U4RVR4dqInfUb5e72f3MQCmnIQHaa5RnGW87TvQZ ZDk3/J6Wlhsn7g2Xcv3BUUnWRMEpAlb3v/+1pbFrMHFDFzyvEFJ+SnLz2dvk1A4bixFDCDt94w2 5sYxVyyLLDrCw9TZAaPN2CJlGjoFvw/qyUKKqGMDCSaqshuuRKF5d2TiuD89cRDW3vHhe5x7Kb0 QM1sBI0r3cRgYcMp89TrcH+PU9mvL1ggTNIiH/hTdkrHSK+l/7kiuK1Q7QRwT/otxfknW8Tw X-Received: by 2002:a05:6214:2a45:b0:8ef:4ed2:316 with SMTP id 6a1803df08f44-9123d70ceabmr135427066d6.1.1789665410471; Thu, 17 Sep 2026 10:16:50 -0700 (PDT) X-Received: by 2002:a05:6214:2a45:b0:8ef:4ed2:316 with SMTP id 6a1803df08f44-9123d70ceabmr135426346d6.1.1789665409997; Thu, 17 Sep 2026 10:16:49 -0700 (PDT) Received: from [192.168.8.4] ([100.0.180.93]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-91252d2b826sm2374926d6.47.2026.09.17.10.16.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Sep 2026 10:16:48 -0700 (PDT) Message-ID: <6a934ca2b3caeb20f1b3d2e9d71e987d5d78af15.camel@redhat.com> Subject: Re: [PATCH] drm/nouveau: Fix bridge reference leak in nv1a_ram_new() From: lyude@redhat.com To: Wentao Liang , airlied@gmail.com Cc: dakr@kernel.org, dri-devel@lists.freedesktop.org, helgaas@kernel.org, linux-kernel@vger.kernel.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, nouveau@lists.freedesktop.org, okaya@codeaurora.org, simona@ffwll.ch, tzimmermann@suse.de, stable@vger.kernel.org Date: Thu, 17 Sep 2026 13:16:47 -0400 In-Reply-To: <20260916180036.2090118-1-vulab@iscas.ac.cn> References: <20260916180036.2090118-1-vulab@iscas.ac.cn> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.3 (3.58.3-1.fc43) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Reviewed-by: Lyude Paul Will push to drm-misc-fixes in just a moment On Wed, 2026-09-16 at 18:00 +0000, Wentao Liang wrote: > pci_get_domain_bus_and_slot() takes a reference to the PCI device, > which is never released once the memory size has been read from its > config space.=C2=A0 Drop the reference before returning. >=20 > Fixes: 2fa6d6cdaf283c05 ("drm/nouveau: deprecate > pci_get_bus_and_slot()") > Cc: stable@vger.kernel.org > Signed-off-by: Wentao Liang > --- > =C2=A0drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramnv1a.c | 2 ++ > =C2=A01 file changed, 2 insertions(+) >=20 > diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramnv1a.c > b/drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramnv1a.c > index 18241c6ba5fa..4d52a158f320 100644 > --- a/drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramnv1a.c > +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramnv1a.c > @@ -51,6 +51,8 @@ nv1a_ram_new(struct nvkm_fb *fb, struct nvkm_ram > **pram) > =C2=A0 mib =3D ((mem >> 4) & 127) + 1; > =C2=A0 } > =C2=A0 > + pci_dev_put(bridge); > + > =C2=A0 return nvkm_ram_new_(&nv04_ram_func, fb, > NVKM_RAM_TYPE_STOLEN, > =C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0 mib * 1024 * 1024, pram); > =C2=A0}