From: "Manush Prajwal" <manushprajwal555@gmail.com>
To: gregkh@linuxfoundation.org
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: axis-fifo: fix underflow of tx_fifo_depth in size check
Date: 1 Sep 2026 19:50:09 +0530 [thread overview]
Message-ID: <6a96df18.ba0ac10c.150968.da3c@mx.google.com> (raw)
On Tue, Sep 01, 2026 at 10:06:00AM +0530, Greg KH wrote:
> So this is just a bug in the device tree?
>
> How was this found and tested?
You're right, and I should have said this up front instead of making
you ask.
This was found by static source review with AI assistance (Claude),
not from a real fault report, fuzzing, or anything hit on actual
hardware. It was checked with checkpatch --strict and verified to
apply cleanly against a fresh clone, but it was never build-tested
against a real kernel build or run on axis-fifo hardware.
On reflection your first question is the real issue: tx-fifo-depth
comes from the devicetree, which is trusted input describing the
hardware, not attacker-controlled data crossing a security boundary.
A DT that lies about the FIFO depth is a bug in that DT, not
something the driver needs to defend against. I don't think this
patch is worth carrying -- happy to drop it.
> Did you forget to add an Assisted-by: tag for this patch?
Yes -- I should have disclosed the AI assistance in the commit
message itself rather than leaving it for you to notice and ask
about. Apologies for that, and thank you for calling it out
directly.
Manush
next reply other threads:[~2026-09-01 14:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-01 14:20 Manush Prajwal [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-09-01 3:01 Manush Prajwal
2026-09-01 4:35 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a96df18.ba0ac10c.150968.da3c@mx.google.com \
--to=manushprajwal555@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®