Re: [syzbot] WARNING in usb_composite_setup_continue

[syzbot <syzbot+a83a5a1ba9ff57935171@syzkaller.appspotmail.com>]

Hello,

syzbot has tested the proposed patch but the reproducer is still triggering an issue:
WARNING in usb_composite_setup_continue

------------[ cut here ]------------
usb_composite_setup_continue: Unexpected call
WARNING: drivers/usb/gadget/composite.c:2743 at usb_composite_setup_continue+0x2be/0x3a0 drivers/usb/gadget/composite.c:2743, CPU#0: file-storage/5924
Modules linked in:
CPU: 0 UID: 0 PID: 5924 Comm: file-storage Not tainted syzkaller #0 PREEMPT(full) 
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 08/05/2026
RIP: 0010:usb_composite_setup_continue+0x2c5/0x3a0 drivers/usb/gadget/composite.c:2743
Code: e5 40 89 ee e8 8c 5c 30 fa 40 84 ed 0f 84 35 fe ff ff e9 08 ab 78 f9 e8 69 62 30 fa 48 8d 3d 82 75 76 09 48 c7 c6 40 b7 d9 8c <67> 48 0f b9 3a e9 d6 fd ff ff e8 4c 62 30 fa 48 89 da 48 b8 00 00
RSP: 0018:ffffc900026dfc88 EFLAGS: 00010093
RAX: 0000000000000000 RBX: ffff888013232528 RCX: 0000000000000001
RDX: ffff88802cce4b00 RSI: ffffffff8cd9b740 RDI: ffffffff9151ff30
RBP: 0000000000000000 R08: 0000000000000005 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000000 R12: 0000000000000293
R13: ffff8880132326c8 R14: ffff888030b52f10 R15: dffffc0000000000
FS:  0000000000000000(0000) GS:ffff888123b6f000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007f1070be0d58 CR3: 000000002a5ba000 CR4: 00000000003526f0
Call Trace:
 <TASK>
 handle_exception drivers/usb/gadget/function/f_mass_storage.c:2549 [inline]
 fsg_main_thread+0x171e/0x8aa0 drivers/usb/gadget/function/f_mass_storage.c:2587
 kthread+0x373/0x450 kernel/kthread.c:436
 ret_from_fork+0x730/0xd60 arch/x86/kernel/process.c:158
 ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:245
 </TASK>
----------------
Code disassembly (best guess):
   0:	e5 40                	in     $0x40,%eax
   2:	89 ee                	mov    %ebp,%esi
   4:	e8 8c 5c 30 fa       	call   0xfa305c95
   9:	40 84 ed             	test   %bpl,%bpl
   c:	0f 84 35 fe ff ff    	je     0xfffffe47
  12:	e9 08 ab 78 f9       	jmp    0xf978ab1f
  17:	e8 69 62 30 fa       	call   0xfa306285
  1c:	48 8d 3d 82 75 76 09 	lea    0x9767582(%rip),%rdi        # 0x97675a5
  23:	48 c7 c6 40 b7 d9 8c 	mov    $0xffffffff8cd9b740,%rsi
* 2a:	67 48 0f b9 3a       	ud1    (%edx),%rdi <-- trapping instruction
  2f:	e9 d6 fd ff ff       	jmp    0xfffffe0a
  34:	e8 4c 62 30 fa       	call   0xfa306285
  39:	48 89 da             	mov    %rbx,%rdx
  3c:	48                   	rex.W
  3d:	b8                   	.byte 0xb8


Tested on:

commit:         edc15184 usb: typec: hd3ss3220: Add support for supply..
git tree:       https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
console output: https://syzkaller.appspot.com/x/log.txt?x=12544749580000
kernel config:  https://syzkaller.appspot.com/x/.config?x=ec55b50193b453ea
dashboard link: https://syzkaller.appspot.com/bug?extid=a83a5a1ba9ff57935171
compiler:       gcc (Debian 14.2.0-19) 14.2.0, GNU ld (GNU Binutils for Debian) 2.44
patch:          https://syzkaller.appspot.com/x/patch.diff?x=146bccf9580000