From: Dmitry Safonov <dima@arista.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: linux-kernel@vger.kernel.org, Bob Gilligan <gilligan@arista.com>,
David Ahern <dsahern@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Dmitry Safonov <0x7f454c46@gmail.com>,
Eric Dumazet <edumazet@google.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Francesco Ruggeri <fruggeri05@gmail.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Salam Noureddine <noureddine@arista.com>,
linux-crypto@vger.kernel.org
Subject: Re: [v2 PATCH] crypto: api - Add __crypto_alloc_tfmgfp
Date: Thu, 15 Jun 2023 17:19:01 +0100 [thread overview]
Message-ID: <6aa4521f-e5d2-ed12-ab49-1132409ab358@arista.com> (raw)
In-Reply-To: <ZIrTQ1tN5LMuRB/5@gondor.apana.org.au>
On 6/15/23 10:00, Herbert Xu wrote:
[..]
>
> Good catch. Though I'd rather add the gfp argument to a separate
> function because I'm in the process of replacing ciphers with
> something that uses the new crypto_types API.
>
> Once that happens ciphers will switch over to the normal cloning
> call and this can be removed.
LGTM, thanks!
>
> ---8<---
> Use it straight away in crypto_clone_cipher(), as that is not meant to
> sleep.
>
> Fixes: 51d8d6d0f4be ("crypto: cipher - Add crypto_clone_cipher")
> Signed-off-by: Dmitry Safonov <dima@arista.com>
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
>
> diff --git a/crypto/api.c b/crypto/api.c
[..]
Thanks,
Dmitry
next prev parent reply other threads:[~2023-06-15 16:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-14 17:46 [PATCH-next 0/3] crypto: cmac - clone fixes Dmitry Safonov
2023-06-14 17:46 ` [PATCH-next 1/3] crypto: api - Remove crypto_init_ops() Dmitry Safonov
2023-06-15 23:31 ` Eric Biggers
2023-06-14 17:46 ` [PATCH-next 2/3] crypto: api - Provide gfp mask for tfm allocation Dmitry Safonov
2023-06-15 9:00 ` [v2 PATCH] crypto: api - Add __crypto_alloc_tfmgfp Herbert Xu
2023-06-15 16:19 ` Dmitry Safonov [this message]
2023-06-20 16:59 ` Dmitry Safonov
2023-06-15 23:38 ` [PATCH-next 2/3] crypto: api - Provide gfp mask for tfm allocation Eric Biggers
2023-06-16 0:25 ` Herbert Xu
2023-06-14 17:46 ` [PATCH-next 3/3] crypto: cipher - On clone do crypto_mod_get() Dmitry Safonov
2023-06-23 8:23 ` [PATCH-next 0/3] crypto: cmac - clone fixes Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6aa4521f-e5d2-ed12-ab49-1132409ab358@arista.com \
--to=dima@arista.com \
--cc=0x7f454c46@gmail.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=ebiederm@xmission.com \
--cc=edumazet@google.com \
--cc=fruggeri05@gmail.com \
--cc=gilligan@arista.com \
--cc=herbert@gondor.apana.org.au \
--cc=kuba@kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=noureddine@arista.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®