From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5ACC3C761A6 for ; Wed, 22 Mar 2023 09:36:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230497AbjCVJgj (ORCPT ); Wed, 22 Mar 2023 05:36:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37688 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230461AbjCVJgg (ORCPT ); Wed, 22 Mar 2023 05:36:36 -0400 Received: from aposti.net (aposti.net [89.234.176.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B6A8A5C9C7; Wed, 22 Mar 2023 02:36:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=crapouillou.net; s=mail; t=1679477152; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NnyeTjIgdueY7mjaENj/U4VyZ8m5JbQk88eP7+Y+NYk=; b=XEBl/Oy+30xBpk7zkIKXfBH3r4Zsd8JBd5MdDsEVQYxh2vKgxB8R2ndtqH2nlcQgqN4GQF Bi8jtOEwXG/+cGXZpLiK+VcMgibiJqllPJIdJ003fjFCNHzxzawEWPh2gUGBxNOtYmD9nZ AzrbSKfSj6knaFwpPsSW6miXEqX/xHE= Message-ID: <6aa6d80cb587c98dba5c04b47cd78f93bb3bafec.camel@crapouillou.net> Subject: Re: [PATCH] mmc: jz4740: Use dev_err_probe() From: Paul Cercueil To: Sergei Shtylyov , ye.xingchen@zte.com.cn, ulf.hansson@linaro.org Cc: linux-mips@vger.kernel.org, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Date: Wed, 22 Mar 2023 10:25:50 +0100 In-Reply-To: References: <202303221707010277273@zte.com.cn> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le mercredi 22 mars 2023 =C3=A0 12:18 +0300, Sergei Shtylyov a =C3=A9crit= =C2=A0: > On 3/22/23 12:07 PM, ye.xingchen@zte.com.cn=C2=A0wrote: >=20 > > From: Ye Xingchen > >=20 > > Replace the open-code with dev_err_probe() to simplify the code. > >=20 > > Signed-off-by: Ye Xingchen > > --- > > =C2=A0drivers/mmc/host/jz4740_mmc.c | 5 +---- > > =C2=A01 file changed, 1 insertion(+), 4 deletions(-) > >=20 > > diff --git a/drivers/mmc/host/jz4740_mmc.c > > b/drivers/mmc/host/jz4740_mmc.c > > index 698450afa7bb..a6ad03b24add 100644 > > --- a/drivers/mmc/host/jz4740_mmc.c > > +++ b/drivers/mmc/host/jz4740_mmc.c > > @@ -232,10 +232,7 @@ static int > > jz4740_mmc_acquire_dma_channels(struct jz4740_mmc_host *host) > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0if (!IS_ERR(host->dma_t= x)) > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0return 0; > >=20 > > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0if (PTR_ERR(host->dma_tx) != =3D -ENODEV) { > > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0dev_err(dev, "Failed to get dma tx-rx channel\n"); > > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0return PTR_ERR(host->dma_tx); > > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0} > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0return dev_err_probe(dev, PT= R_ERR(host->dma_tx), "Failed to > > get dma tx-rx channel\n"); >=20 > =C2=A0=C2=A0 I'm afraid this makes the following code unreachable... Also, this is not a probe(), so I don't see a point of using dev_err_probe() here. Cheers, -Paul >=20 > >=20 > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0host->dma_tx =3D dma_re= quest_chan(mmc_dev(host->mmc), "tx"); > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0if (IS_ERR(host->dma_tx= )) { >=20 > MBR, Sergey