From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1212334FF58 for ; Tue, 6 Jan 2026 18:40:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767724852; cv=none; b=QKORB7E5C5K05yHQCeK43J6R8pFuKNZsYhOGO7ylE62fV7kMo0RPQ93o0q2sO3ahbJbLfyH0dsbmysTp45G1yXavbS9/dpCf52rZFOsMepav8AVfss7JVQ54XKUbqn8y0DrVJ870SkHirthv+kma1C3eD3cBa6gIHPtt7IdJqQk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767724852; c=relaxed/simple; bh=++DQGKnOZXg8YlFGgSsaTnIuRLTvbA/gdMLcbw0EMEM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=CBu6GYKp4khu8rG35HO42ddpa5eWuOrVIJjvmGE44jGi1WvpZiK4RRbJvBs+eVvlbCu7vDLthCMMM0Gr8/Lrw31aihISvMh/igIMw6oh0YIRRoYPBUpKgchxwX5zJT8R9GyELAJIbxeFOI90+en8KgqasLfeYP1BizgP+JAliLY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=m2ftelMR; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=LE5Iqfqu; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="m2ftelMR"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="LE5Iqfqu" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 606AgWNT1462298 for ; Tue, 6 Jan 2026 18:40:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 5PxAPouMyA//31qIYJm+rklBoskPqlYIqSfK+Bd0RZ4=; b=m2ftelMRML/dFZvl ht2KIE6bYMfPbyV+j9Wm/WIqiBh6MuAaKMwUl8CnHzk5AkFvA4SoSohfNPfa2Thh rKDkMYCx7+vWS3QqsTbmHquAoIaMnj4mYeErzGEsa21OpVVSSpd8XxNyIDaMj97Y OfUdQpMIiQl7mwyVJJoTHH1ie+a9iYnVx1WDBAN/epH8rjuEYuW9saUtbPkOjkMP qdhrU14zP+6bTKqifZw54iBJIqOBtJ3wzyx6dBm5zk7ERYJzQ1L4DFu2/ZCGWvNc holB8CgEM6ZSAatXT2br+vup262IRixQILXlE82dV+3d7CVY4NxwUIgLGcSXcaK4 fPohzw== Received: from mail-dl1-f70.google.com (mail-dl1-f70.google.com [74.125.82.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bh0vm1dfd-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 06 Jan 2026 18:40:50 +0000 (GMT) Received: by mail-dl1-f70.google.com with SMTP id a92af1059eb24-12055b90b7bso2460020c88.0 for ; Tue, 06 Jan 2026 10:40:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1767724850; x=1768329650; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=5PxAPouMyA//31qIYJm+rklBoskPqlYIqSfK+Bd0RZ4=; b=LE5Iqfqu3CvAz97I/A/aVD5ymgxZ4fL8E1s+h9fW+nm9Sgq437VGjm21QTVjfbIk8q KhmF8jkzM09zCbA8GqAn44mI32X+NU4oIL4J8d5cXXWAvXzhYFSH5K5/qrVGPFenTBVE BvXwbHJCofprgHxyfZ9dZcpTKPKnPHaQgdMSIlIy/zha/biEIgrCW1LGHhiNLivFmkiw 6ba0RYB5kU9GqOKrnWEwY6USNnk6TXUFXJcUs21pOlvZyWuujqrhMsP22dwQQ+4x7nCl 7uD4OW3flv0DeYZKl/BD+gThuy6eBUiywvlA8JDxvQUVZ/erxW9pMAGFHmHPhRsSg7UK W6+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767724850; x=1768329650; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=5PxAPouMyA//31qIYJm+rklBoskPqlYIqSfK+Bd0RZ4=; b=RBfhJnsLnimW2I56wUu4HIyW3aa8o4s9X2pufzvs9yBgjrIp+JR91qTuD/6Rd7sswA wF5dkI8TYFRrz2AIBeXfK1UubK4lq0Y4AggwcrVR5xpDaLnSk/ujjkFWIjDqIapdO6h7 aoqTbsTOI01q30t+PZLY/sy2CGwNNK8b3yb8Qu/408j4wytg2cEjucqlpdwMKQDO1oNZ k1SQcxRYmVi0uzM14k93qNJyrK/0uW0yijhr8NQLVMDd4DVZlrYacIhg9OT96jsszW+U ZOTLkT2L+oHXt/u8e+gH0uioe2DnvNVq6YqWQuYecFBQD+ER9j5VgUV7IHMuscTF87zd cmIg== X-Forwarded-Encrypted: i=1; AJvYcCXSZ4WTPs03Bj8x3AcOY2U555uD5de2gtWejdBwUxR4DFpi5SlgHO/nXHwHIXytb0glCSiAN0ViPMpDuU8=@vger.kernel.org X-Gm-Message-State: AOJu0YzmcX1tBF6eieA4jmQv8t+kg2am76VG+aF9yGPX5uBjJVMkHtg0 HqaYqHtQ5FIXIjKR4UID8qB+aNJ75k7TVirKy3MeeN8zc3FlEk1ZGu/PsYNM5HIXD0MATiUYfQL UGvnnFikOVJIMK8rXUDaqBub6Bhvz70vK/1v1bwPRkkmbD7DoVsq8PIaRYlK9E5JYSL8= X-Gm-Gg: AY/fxX7o/3Lrt0oMTkLjKGsA4Lqv9UiB2Upu8UtcghtfBVdzrEkHAQyZKAojsR9s0Rs E08CL4Bd+lZPG1K4mBlNLeCr785UZ0NyWI5alf/JPlaklwcnFZsJfXN3BFKNvZcEKoaV2y8tCMa RQrUcUDMqRUaYkN+ObWpBazlr7JahgpzzHfoMJ1nvCQ2yO8annqhGUlkix+nTMa4CgTGOfhYdis X3uxMVekPt+2bg2Fu4srbJhUzVD4dXFQWmaqXm95naw1T59Aui1xWOdXXP7Ciu7YCIdpowpYYpP oAZlF79Tez5yZWV1pE/mCtoGWDTJYoKsIFomYN04nDxzz52brEZa0KF90WJ9IijqQaLyF+okNFt 6pcH2w3owE7mesaM/HkddNFr0iZfla9vhuGrYLFeCh8yeE22A7ZEhMhezLmiAwXSMtg== X-Received: by 2002:a05:7022:418a:b0:11e:70d8:5dbb with SMTP id a92af1059eb24-121f188e0a6mr3234850c88.7.1767724849587; Tue, 06 Jan 2026 10:40:49 -0800 (PST) X-Google-Smtp-Source: AGHT+IGSlzX+i3g8MbsJ2Eno/vHUKFXWMpqLnsUNOpaetZ9ZfpcQ9g/t+UHkyP6dmuOdvPwPx2CiQA== X-Received: by 2002:a05:7022:418a:b0:11e:70d8:5dbb with SMTP id a92af1059eb24-121f188e0a6mr3234816c88.7.1767724848999; Tue, 06 Jan 2026 10:40:48 -0800 (PST) Received: from [10.62.37.112] (i-global254.qualcomm.com. [199.106.103.254]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-121f243ed62sm6788547c88.5.2026.01.06.10.40.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 06 Jan 2026 10:40:48 -0800 (PST) Message-ID: <6aa8ffc4-2fe5-44ad-8ac8-581e0697360f@oss.qualcomm.com> Date: Tue, 6 Jan 2026 10:40:46 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 7/7] arm64: dts: qcom: sm8750: Add support for camss To: Krzysztof Kozlowski , Hangxiang Ma Cc: Loic Poulain , Robert Foss , Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Todor Tomov , Vladimir Zapolskiy , Mauro Carvalho Chehab , Bryan O'Donoghue , linux-i2c@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, jeyaprakash.soundrapandian@oss.qualcomm.com References: <20251126-add-support-for-camss-on-sm8750-v1-0-646fee2eb720@oss.qualcomm.com> <20251126-add-support-for-camss-on-sm8750-v1-7-646fee2eb720@oss.qualcomm.com> <20251127-steadfast-red-koel-8c9bc8@kuoka> Content-Language: en-US From: Vijay Kumar Tumati In-Reply-To: <20251127-steadfast-red-koel-8c9bc8@kuoka> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=Pa3yRyhd c=1 sm=1 tr=0 ts=695d5732 cx=c_pps a=SvEPeNj+VMjHSW//kvnxuw==:117 a=JYp8KDb2vCoCEuGobkYCKw==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=jRZ_Em-5SMcKJbQpHL4A:9 a=QEXdDO2ut3YA:10 a=Kq8ClHjjuc5pcCNDwlU0:22 X-Proofpoint-GUID: vOZV7qcL2tvLweCal117CbjEyg5hIs7n X-Proofpoint-ORIG-GUID: vOZV7qcL2tvLweCal117CbjEyg5hIs7n X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTA2MDE2MiBTYWx0ZWRfX8s7BvonD3wCD qMVwxR+XfkIP1lOylE+012dgLfg00qDF6U5ofe6tVYezfiH07GC0oSMQ+fJ12gaSPFeZcfL+VzH 5WdlhNdVzXK450Eq1AgarK84Eew7KZmNWDRPpPUJx8k6B6rNRDQKIu9i4a7mTDM7ifx0MS5FfhX DZGl/kF9Iv7w/e7mWGqUizVsY4wUXVHPn9huppfiLEfZ7OgdhoKTbaMx7FpLtoE11c3uwqO1S5D 738WEn+y7s2ZHmzNJoRJahVpZxAnQdYmeD4VFK0fmuyHt+S4Od4Rf6Y2/24bJmYtQd4zoegbQ8g Ca7rjq9Y8BCVaFdwgVad33dH4mtKQ+OTHghtoYp+Ef+734wrKccMQhQAgu+M90rzcNpKEAsNo51 JUjyffCeSPx65VMraca9r6/e+8A3dwGPo66lC4g6HsnsV/oknIfY338P7vp27YVbhnMAf5JnCqd aXx5Puxmh0+alistbgw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-06_01,2026-01-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 clxscore=1015 priorityscore=1501 lowpriorityscore=0 spamscore=0 adultscore=0 suspectscore=0 phishscore=0 malwarescore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601060162 On 11/27/2025 12:12 AM, Krzysztof Kozlowski wrote: > On Wed, Nov 26, 2025 at 01:38:40AM -0800, Hangxiang Ma wrote: > + >> + cci1_1_default: cci1-1-default-state { >> + sda-pins { >> + pins = "gpio111"; >> + function = "cci_i2c_sda"; >> + drive-strength = <2>; >> + bias-pull-up; >> + }; >> + >> + scl-pins { >> + pins = "gpio164"; >> + function = "cci_i2c_scl"; >> + drive-strength = <2>; >> + bias-pull-up; >> + }; >> + }; >> + >> + cci1_1_sleep: cci1-1-sleep-state { >> + sda-pins { >> + pins = "gpio111"; >> + function = "cci_i2c_sda"; >> + drive-strength = <2>; >> + bias-pull-down; >> + }; >> + >> + scl-pins { >> + pins = "gpio164"; >> + function = "cci_i2c_scl"; >> + drive-strength = <2>; >> + bias-pull-down; >> + }; >> + }; >> + >> + cci2_0_default: cci2-0-default-state { >> + sda-pins { >> + pins = "gpio112"; >> + function = "cci_i2c_sda"; >> + drive-strength = <2>; >> + bias-pull-up; >> + }; >> + >> + scl-pins { >> + pins = "gpio153"; >> + function = "cci_i2c_scl"; >> + drive-strength = <2>; >> + bias-pull-up; >> + }; >> + }; >> + >> + cci2_0_sleep: cci2-0-sleep-state { >> + sda-pins { >> + pins = "gpio112"; >> + function = "cci_i2c_sda"; >> + drive-strength = <2>; >> + bias-pull-down; >> + }; >> + >> + scl-pins { >> + pins = "gpio153"; >> + function = "cci_i2c_scl"; >> + drive-strength = <2>; >> + bias-pull-down; >> + }; >> + }; >> + >> + cci2_1_default: cci2-1-default-state { >> + sda-pins { >> + pins = "gpio119"; >> + function = "cci_i2c_sda"; >> + drive-strength = <2>; >> + bias-pull-up; >> + }; >> + >> + scl-pins { >> + pins = "gpio120"; >> + function = "cci_i2c_scl"; >> + drive-strength = <2>; >> + bias-pull-up; >> + }; >> + }; >> + >> + cci2_1_sleep: cci2-1-sleep-state { >> + sda-pins { >> + pins = "gpio119"; >> + function = "cci_i2c_sda"; >> + drive-strength = <2>; >> + bias-pull-down; >> + }; >> + >> + scl-pins { >> + pins = "gpio120"; >> + function = "cci_i2c_scl"; >> + drive-strength = <2>; >> + bias-pull-down; >> + }; >> + }; >> + }; >> + >> + cci0: cci@ac7b000 { > Looks completely mis-ordered/sorted. What are the nodes above and below? Hi Krzysztof, sorry, not sure how you mean exactly. The ones above are the pinctrl nodes. Each CCI has two masters using two GPIOs each, one for clk and one for data. The ones below are the actual CCI HW nodes that make use of the pinctrls. I believe this is inline with previous generations. Have I missed something? Thanks. > > >> + compatible = "qcom,sm8750-cci", "qcom,msm8996-cci"; >> + reg = <0x0 0x0ac7b000 0x0 0x1000>; > Best regards, > Krzysztof >