From: "Nguyen, Anthony L" <anthony.l.nguyen@intel.com>
To: "alex.dewar90@gmail.com" <alex.dewar90@gmail.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"Kirsher, Jeffrey T" <jeffrey.t.kirsher@intel.com>,
"intel-wired-lan@lists.osuosl.org"
<intel-wired-lan@lists.osuosl.org>,
"kuba@kernel.org" <kuba@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Topel, Bjorn" <bjorn.topel@intel.com>
Subject: Re: [PATCH] i40e: Fix use of uninitialized variable
Date: Thu, 17 Sep 2020 21:11:32 +0000 [thread overview]
Message-ID: <6aaa242f49ccd3824fe4cbb38bada7ccf9add979.camel@intel.com> (raw)
In-Reply-To: <20200916204943.41017-1-alex.dewar90@gmail.com>
On Wed, 2020-09-16 at 21:49 +0100, Alex Dewar wrote:
> In i40e_clean_rx_irq_zc(), the variable failure is only set when a
> condition is met, but then its value is used unconditionally. Fix
> this.
>
> Addresses-Coverity: 1496986 ("Uninitialized value")
> Fixes: 8cbf74149903 ("i40e, xsk: move buffer allocation out of the Rx
> processing loop")
> Signed-off-by: Alex Dewar <alex.dewar90@gmail.com>
Thanks for the patch Alex, however, Dan Carpenter has already submitted
a patch for the same reported issue:
https://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200916143228.GA764370@mwanda/
Thanks,
Tony
prev parent reply other threads:[~2020-09-17 21:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-16 20:49 Alex Dewar
2020-09-17 21:11 ` Nguyen, Anthony L [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6aaa242f49ccd3824fe4cbb38bada7ccf9add979.camel@intel.com \
--to=anthony.l.nguyen@intel.com \
--cc=alex.dewar90@gmail.com \
--cc=bjorn.topel@intel.com \
--cc=davem@davemloft.net \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®