From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F68FC433EF for ; Mon, 4 Jul 2022 10:27:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233782AbiGDK1J (ORCPT ); Mon, 4 Jul 2022 06:27:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50592 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233627AbiGDK0o (ORCPT ); Mon, 4 Jul 2022 06:26:44 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5EB3AFD35; Mon, 4 Jul 2022 03:25:53 -0700 (PDT) Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id 3A57B6601638; Mon, 4 Jul 2022 11:25:51 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1656930351; bh=Wx8uEDF1bProsm5cSCfro4wBLSi7HbQPJbpg+8HNAJk=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=d7/YGXQUpzeLCBjzJEd++c3yKJJusG7XpqrSsyP1cydEw53cmzb/alYIBHozWE92z n0xh+tfKBjvPaJGRGp4SdksyaKV+/nusg//K71k4wsmExcHaTKA64lP91jf57qkJjU beXodcg28++Vk6lGybLoeGHIKfSsVYf/7jRZOQPg6JCpUhZE/Rn/xpFFisEvp5rCql ZtUN6wxxt5gacUsmYzREI4n+Oz3Y8WrIBWeAFHuU4S3G9qQLPf24EkHq/iPxbP3jBl j0ZHUdpvbMYQIHTOzOisvblwj/qFN6SSHs/tcpg9FG4N0UBsbLZ1/KznRsIODrYrN5 ThyL3ne2mewzg== Message-ID: <6aafec78-2699-0cc9-bd2a-5ccd39262e38@collabora.com> Date: Mon, 4 Jul 2022 12:25:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH v1 02/16] dt-bindings: memory: mediatek: Update condition for mt8195 smi node Content-Language: en-US To: Tinghan Shen , Yong Wu , Joerg Roedel , Will Deacon , Rob Herring , Krzysztof Kozlowski , Matthias Brugger , Chun-Jie Chen , Weiyi Lu Cc: iommu@lists.linux-foundation.org, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Project_Global_Chrome_Upstream_Group@mediatek.com References: <20220704100028.19932-1-tinghan.shen@mediatek.com> <20220704100028.19932-3-tinghan.shen@mediatek.com> From: AngeloGioacchino Del Regno In-Reply-To: <20220704100028.19932-3-tinghan.shen@mediatek.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Il 04/07/22 12:00, Tinghan Shen ha scritto: > The max clock items for the dts node with compatible > 'mediatek,mt8195-smi-sub-common' should be 3. > > However, the dtbs_check of such node will get following message, > arch/arm64/boot/dts/mediatek/mt8195-evb.dtb: smi@14010000: clock-names: ['apb', 'smi', 'gals0'] is too long > From schema: Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.yaml > > Remove the last 'else' checking to fix this error. > > Signed-off-by: Tinghan Shen > --- > .../memory-controllers/mediatek,smi-common.yaml | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.yaml b/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.yaml > index a98b359bf909..e5f553e2e12a 100644 > --- a/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.yaml > +++ b/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.yaml > @@ -143,7 +143,15 @@ allOf: > - const: gals0 > - const: gals1 > > - else: # for gen2 HW that don't have gals > + - if: # for gen2 HW that don't have gals > + properties: > + compatible: > + enum: > + - mediatek,mt2712-smi-common MT6795 also doesn't have any GALS, please add it in here. Regards, Angelo > + - mediatek,mt8167-smi-common > + - mediatek,mt8173-smi-common > + > + then: > properties: > clocks: > minItems: 2