From: Andrew Lunn <andrew@lunn.ch>
To: Yeounsu Moon <yyyynoom@gmail.com>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v3 2/2] net: dlink: handle copy_thresh allocation failure
Date: Tue, 16 Sep 2025 21:36:28 +0200 [thread overview]
Message-ID: <6ab6f484-5ad0-4135-97cd-e5b0af6f691f@lunn.ch> (raw)
In-Reply-To: <20250916183305.2808-3-yyyynoom@gmail.com>
On Wed, Sep 17, 2025 at 03:33:05AM +0900, Yeounsu Moon wrote:
> The driver did not handle failure of `netdev_alloc_skb_ip_align()`.
> If the allocation failed, dereferencing `skb->protocol` could lead to a
> NULL pointer dereference.
>
> This patch adds proper error handling by falling back to the `else` clause
> when the allocation fails.
>
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> Tested-on: D-Link DGE-550T Rev-A3
> Signed-off-by: Yeounsu Moon <yyyynoom@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2025-09-16 19:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-16 18:33 [PATCH net v3 0/2] net: dlink: handle copy_thresh allocation Yeounsu Moon
2025-09-16 18:33 ` [PATCH net v3 1/2] net: dlink: fix whitespace around function call Yeounsu Moon
2025-09-17 23:06 ` Jakub Kicinski
2025-09-24 16:38 ` Yeounsu Moon
2025-09-24 23:12 ` Jakub Kicinski
2025-09-16 18:33 ` [PATCH net v3 2/2] net: dlink: handle copy_thresh allocation failure Yeounsu Moon
2025-09-16 19:36 ` Andrew Lunn [this message]
2025-09-17 23:09 ` Jakub Kicinski
2025-09-24 16:36 ` Yeounsu Moon
2025-09-24 23:11 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ab6f484-5ad0-4135-97cd-e5b0af6f691f@lunn.ch \
--to=andrew@lunn.ch \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=yyyynoom@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®