From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CBB5433A711 for ; Tue, 3 Mar 2026 11:31:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772537502; cv=none; b=i8rPiOaBWBB4B/EVqUbqLBxBtRVkU99/v/5Wa2VdKvl2v1D7+Ml1JZh1ayenvIkiUNxpqKy2hFdu3WW+3Qxexhf0PhzyzHiGJdDACcpWYkWCGA5EvkyeVG+jBDiJyF4023mCr9AbPIIwPYIzn8pfrOzi+KmvXXqLab08BiDkDnQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772537502; c=relaxed/simple; bh=crYuknviy4WZt4lwM1uh4JnMMJVyUHcQI5pren86pIo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=WOwFzhn+bNA8u+mYQpBx4Bee4CMAnd7NObMVTA0yjnOCMKWOBkXXNteuophjBoo8sDLGmsv7riJK8geXSRRCLq+qdvO+SzqflJi5tyxjd7Z5XB2tB3gOCnrSL5EEUBIAJpD705OQ8OA1bvOibjU5QrxZWejgbfQzEz3kt4aStC0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=HvsaaNV8; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=NvbHfG3B; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="HvsaaNV8"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="NvbHfG3B" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6239moLU2614205 for ; Tue, 3 Mar 2026 11:31:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= xCspUN4yg0mBW2cs+CDIhav3u7fqfrGMD0xfZQLCXOU=; b=HvsaaNV809YcloPc /gVJlsOWBMcblTwXm6VtPoXk+l/8YPomA2GM3VyV3teOabdcXQbWKSdeEAcSM4hY ZOAe2FtNDeLAFwyYSdIhEaalRTmH1WQajdhw5lZQAUPsQ5OL0bVKVlP6dzUm4Hcy n4tmIQ+FvTAr8oRkYOeQwWaGU4MO0UcxSIUNVnifnWF5a7DXi9QdGpgWa4lt7ZAg yWm7iSBEPukRiRYILrxB9hscc1ATVmGKXit+WTeDoIxsEwv3dJZPwQeaj83CVhn7 tvbQNZWCj2V4wmZ1LTl2GJM8Ojnuppm1eLfWtiJHojmJJgLM7yTj7fHuQLt3VRoo YuD+3A== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cnvxf8dnu-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 03 Mar 2026 11:31:38 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-8cb399597fbso374793985a.3 for ; Tue, 03 Mar 2026 03:31:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772537498; x=1773142298; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=xCspUN4yg0mBW2cs+CDIhav3u7fqfrGMD0xfZQLCXOU=; b=NvbHfG3B3UB81X+eLnmDmeJ/czmfodRg9mHp13PEPpVES0Du/eSJsRZ9oclLpuWV3k y4cyp9x6ZtJWS80g8flpRSdcNRppEmgRCAQoepU/9E0dGzbfRvMXjzcGOHIcHnVxGw6f amEY1k0AtV0UZdW1kWoTOBJGPwEZrAHJuk2lsWGVPX9+NX2J9+znMRfTsXPtn0j04/pu aSjPg9KYugXso6lkj0DZR8qP/xwXmvhSBqYQkzIibkPNxrqO6y1Q3WR5kmJMdQj4bjWu 0Bs054lm2OzNpWyp6mZxpc7tHxx5i/YZ6+++5n+xVaUKq6KwRJF1pesKNV+SgE9Lduo2 XhBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772537498; x=1773142298; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=xCspUN4yg0mBW2cs+CDIhav3u7fqfrGMD0xfZQLCXOU=; b=e4BWXwpJj9JJKmy3e/+JgIOr4LMFYYQ9Sw0jq1zPv3mTRqCQ6PiOTLusNMy8HVXlHJ /frF44qUeiaT5gSlrrWW+WLtBmnhM95Ws11nweHEcJfemaoY5ED2ll8wn4gNTUeQFN/9 /UaYvZ6X5yhnPXDA+buwksVMaUvPWDHp30oK3A6ulYMKepD5TZ5r9W1JxVgWJ3HWVxzv bRqGGy5FUOqdOwaj8T9N3pPZV42Mx7gV5ObmmE2tsyCZqDfEUeKqP9gxaUNP7PLJuAm6 T79ZJqs6Ge4rxxfIjagzq1KZ3mGkUod4fesBUAvDPxqLjzxXg8AaD0Q5pJMpHA+caidi WpiA== X-Forwarded-Encrypted: i=1; AJvYcCWcJF6+XROgXCoa32q5HqtjeaPyodlZhOKvV15JGewY4nU4/Rd/bsRf+Uh2PQTLsV1AqS3miqaTSGtrt7c=@vger.kernel.org X-Gm-Message-State: AOJu0YxlMEbeumcth2NS5laSXS3pLDkW3BvHr3/WXfFRMZyvqVrVqg/u wzSieS6a1a/DuoqNR0B0QWaqabfHKoCTw0clRHIkAiPluc+K9o24g/8cuzedN+h7HME/WyA39N4 bO/bcsSoeBWXjLFngEJ56QDSWV2nQKdR3a3F9SL6W5b8qdOin2p7LX+Njtlal2GY15W8= X-Gm-Gg: ATEYQzz29/w/tq22LvurY43YytBCCFk+ldGgzF3vWOEMxSg4xS2yVHJIf/dHw3IO+29 TWsIV5/Q3yjShZM9nVHZ0gb1cNvIVG+3XokNCoEvBJkQ4anqbwKoc2JdJ3wCPaAM8HoKtUPCsEb kjsV3KxpzEjTIQnCjt7ItBEpvxxD7hVTrCdfvbHbUs3yk71cc68TBRw5wShvpIEwM46Ia/rd3WJ E+wT3Z9owtozRaSmx2Nqa+9C+fpZNyShljIFiyDMdmLo0NdJDke5y1BJz4Ig6+HwlcX47amg31J 9gTtwNBxtBvDs6b8ekOsngdTWYGEtcY6V339nTr0N+MqyDYdWQQB2BpDQyw68+CghM5MVRNx7TU 6XmqnSKeW24Ps5HBODdw/0dYWkbi7djaK9KLKuAdUjadfMowICPoUKTiPTkZENbOOnOoNslXZ/B XQ+ic= X-Received: by 2002:a05:620a:4155:b0:8b2:ea2d:a5 with SMTP id af79cd13be357-8cbc8f2348bmr1560294185a.7.1772537498037; Tue, 03 Mar 2026 03:31:38 -0800 (PST) X-Received: by 2002:a05:620a:4155:b0:8b2:ea2d:a5 with SMTP id af79cd13be357-8cbc8f2348bmr1560290885a.7.1772537497512; Tue, 03 Mar 2026 03:31:37 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b935ae61474sm582362166b.44.2026.03.03.03.31.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Mar 2026 03:31:37 -0800 (PST) Message-ID: <6ab7b752-f906-4897-9aa9-12af636a9ee3@oss.qualcomm.com> Date: Tue, 3 Mar 2026 12:31:34 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] phy: qcom: qmp-combo: Move pipe_clk on/off to common To: Val Packett , Vinod Koul , Kishon Vijay Abraham I , Bjorn Andersson , Wesley Cheng , Neil Armstrong Cc: Dmitry Baryshkov , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260228220634.22778-2-val@packett.cool> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260228220634.22778-2-val@packett.cool> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzAzMDA4OSBTYWx0ZWRfX21/WJwGufRcE aZj+dDf99eNbivtCUOxua6TRjxJWIoSYuIFWw8MM+kf8ziSWL8phIsaBizMeuTWflNN5bM4iGja 7zZT/29hiUZ3fqvp9M4/FQgXlB5IsRj9PMaQciSbBBViSv1pVKEhPhzsbC4dujxS3Y0AXq6b+Vj TuQLtvx/QfYpz4VCCdg/MnQ3BS+MGv0j0jnmlx/G9YMq3WvTxep7JOR2ZrEGYBoeoCPteBsJnTv sTfMb9TsjJjT66taTAjdM6WY0tWBS9RscJcdIN8nsyZ8soiiPlFXTsfB6HzdfucOLvbUOn1UZ60 uL/8uTqHG3m/COaO2LUmYpiXNWI1Sg0/XqZB7QxQRRKP8YAXtAiqWSgzgkexvbu8mskwBBlnelw LgkAN4pgp1mC/T8Olen61VfNvtUWeMgSM5XV3fQHiey+REIDQv7yQRRJeydoHu0RLm82ibYuqZR tAiVa2gORfSLcPTsU6w== X-Proofpoint-ORIG-GUID: LYMLSIEr7_dursAb0tFLCxtfWUSUEOQz X-Authority-Analysis: v=2.4 cv=S+HUAYsP c=1 sm=1 tr=0 ts=69a6c69a cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=WxJYI2yInr4zNcYYujUA:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-GUID: LYMLSIEr7_dursAb0tFLCxtfWUSUEOQz X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-02_05,2026-03-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 malwarescore=0 lowpriorityscore=0 bulkscore=0 suspectscore=0 clxscore=1015 spamscore=0 priorityscore=1501 adultscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603030089 On 2/28/26 11:05 PM, Val Packett wrote: > Keep the USB pipe clock working when the phy is in DP-only mode, because > the dwc controller still needs it for USB 2.0 over the same Type-C port. > > Tested with the BenQ RD280UA monitor which has a downstream-facing port > for data passthrough that's manually switchable between USB 2 and 3, > corresponding to 4-lane and 2-lane DP respectively. > > Note: the suspend/resume callbacks were already gating the enable/disable > of this clock only on init_count and not usb_init_count! > > Signed-off-by: Val Packett > --- > See https://lore.kernel.org/all/389ca5d3-a698-4dac-911c-39ba057e3d17@oss.qualcomm.com/ for more info. > BTW https://lore.kernel.org/all/20260205160240.748371-2-loic.poulain@oss.qualcomm.com/ helped with coldplug. I think that's a fluke, you shouldn't see any real-world impact from that patch Reviewed-by: Konrad Dybcio Konrad