From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: ARC-Seal: i=1; a=rsa-sha256; t=1516284325; cv=none; d=google.com; s=arc-20160816; b=GidEKbpKd3aVDCJSW+4bobSjieW/YbcyUuBMC3cpOd9RN1kZiGblbHHuFQ4Nmfzv5R bD4u5oDztHvzG//sdRNfVUjPP0DZlPwU1CF8XQjhyhq+Ni+VydtuUTpvpnpYoVyficiN 9FGGbf2ZkuK/x5zmj6araIkCcIlNIkAB+wXLgN0zSd5AFQ5Tr36KyDoQRV90ryxNwot4 gcOv+LgvoGB6fTo8ldKXlS7X5fRpmDFP80B6/c05gyaq992T5esViKeY0bS2AXHAi/iD YF37OmfUD9qfZ8r9waczVoI4cVWCCO1l6uz9nK/gYF20KUSPCI7Juy4+zm/k9fVtVypm Y49A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-language:content-transfer-encoding:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject:reply-to :dkim-signature:arc-authentication-results; bh=aOd6maXCuq3Wc0G6JfhTzP5OI0qzZIEI8OgOPZEvY/g=; b=fsnLZ1mwcKM7t8LJAbvfThjN9J1U/AoTuajhAjFm4KYuAWtX+AY/WFgffHZkoCyK0E QvQrNhQKpJwYq06qt/xVccIvrnEsRLy6nQGvRBzX+EN15H4VkJlkC8M1Bibs462UPFAt aPxjzuXSN+GYy6hrN9ivBHJ0YfsMSZkOi8KlvjZXUQrBic3ASuvcBNfErlT+mOK6wXmR NDrAnKv9jBVzoUKzLrlsswe7vDLeqc+CBtWtCXg/0nk9x1N45BZY7TB8jf4TgxW/fKOH z4jrxls8Irkk/NCUtpBERC2dpKfaQbC56elCfJa1idoWdIluGzcuupHom6SU4+3rNDK4 d7/w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=I00dqKAG; spf=pass (google.com: domain of tcminyard@gmail.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=tcminyard@gmail.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gmail.com Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=I00dqKAG; spf=pass (google.com: domain of tcminyard@gmail.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=tcminyard@gmail.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gmail.com X-Google-Smtp-Source: ACJfBos37TlDhWkMZ25tO2U2XrLfvZzd+JqXYwLaWkKiSNrvXTr0daSzhVuN/qFG9OPhnOCO7+2mMg== Reply-To: minyard@acm.org Subject: Re: [PATCH -next] ipmi/powernv: Fix error return code in ipmi_powernv_probe() To: Alexey Kardashevskiy , Wei Yongjun , Corey Minyard , Arnd Bergmann , Greg Kroah-Hartman , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman Cc: openipmi-developer@lists.sourceforge.net, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org References: <1516188311-144227-1-git-send-email-weiyongjun1@huawei.com> From: Corey Minyard Message-ID: <6ab96d83-5ec3-e882-7bfc-fe072c101666@gmail.com> Date: Thu, 18 Jan 2018 08:05:22 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-GB X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1589838321056978223?= X-GMAIL-MSGID: =?utf-8?q?1589939353780835705?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On 01/17/2018 10:04 PM, Alexey Kardashevskiy wrote: > On 17/01/18 22:25, Wei Yongjun wrote: >> Fix to return a negative error code from the request_irq() error >> handling case instead of 0, as done elsewhere in this function. >> >> Signed-off-by: Wei Yongjun > > Reviewed-by: Alexey Kardashevskiy Queued for next release.  Thanks! -corey > > >> --- >> drivers/char/ipmi/ipmi_powernv.c | 5 +++-- >> 1 file changed, 3 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/char/ipmi/ipmi_powernv.c b/drivers/char/ipmi/ipmi_powernv.c >> index c687c8d..bcf493d 100644 >> --- a/drivers/char/ipmi/ipmi_powernv.c >> +++ b/drivers/char/ipmi/ipmi_powernv.c >> @@ -250,8 +250,9 @@ static int ipmi_powernv_probe(struct platform_device *pdev) >> ipmi->irq = opal_event_request(prop); >> } >> >> - if (request_irq(ipmi->irq, ipmi_opal_event, IRQ_TYPE_LEVEL_HIGH, >> - "opal-ipmi", ipmi)) { >> + rc = request_irq(ipmi->irq, ipmi_opal_event, IRQ_TYPE_LEVEL_HIGH, >> + "opal-ipmi", ipmi); >> + if (rc) { >> dev_warn(dev, "Unable to request irq\n"); >> goto err_dispose; >> } >> >