mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: Thomas Zimmermann <tzimmermann@suse.de>,
	John Edwards <uejji@uejji.net>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>
Cc: Andrew Wyatt <fewtarius@steamfork.org>,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/5] Handheld gaming PC panel orientation quirks
Date: Wed, 12 Feb 2025 11:51:07 +0100	[thread overview]
Message-ID: <6abc98bd-5ef9-491e-985b-7ed8a848c96e@redhat.com> (raw)
In-Reply-To: <b3caa748-2dbd-4911-968f-878fcd118a9b@suse.de>

Hi Thomas,

On 11-Feb-25 2:55 PM, Thomas Zimmermann wrote:
> Hi
> 
> Am 24.01.25 um 21:46 schrieb John Edwards:
>> Hello.
>>
>> I am submitting a small number of patches to add panel rotation quirks for
>> a few handheld gaming PCs.  These patches were created by the SteamFork
>> team and are in daily use by us and/or members of our community.
>>
>> The following devices are covered by these patches:
>> 1: AYANEO 2S
>> 2: AYANEO Flip DS, AYANEO Flip KB
>> 3: AYANEO Slide, Antec Core HS
>> 4: GPD Win 2 (with correct DMI strings)
>> 5: OneXPlayer Mini (Intel)
>>
>> Thank you for your consideration and for taking the time to review these
>> patches.
> 
> Did you ever receive any response to this series? If not, then
> 
> Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>

I had the following remark for 3 new entries added in patches 2/5 + 3/5:

"Since this '}' is closing the .matches initializer it should be indented 2 tabs"

With that fixed, you can add my:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

to the entire series.

> for the series. Let me know if you need assistance for getting the patch files merged.

Normally I pickup/merge these panel orientation quirks, but I've been swamped
which is why these have just been sitting on the list.

Thomas, I would appreciate it if you can merge the set into drm-misc-fixes, with
the 3 minor indentation issues fixed.

Regards,

Hans




>> v2:
>> - Minor rewording of commit messages
>> - Include Tested-by tag for Paco Avelar in AYANEO Flip DS/KB patch
>> - Add OneXPlayer Mini (Intel) patch
>>
>> v1:
>> https://lore.kernel.org/dri-devel/20250116155049.39647-2-uejji@uejji.net/
>>
>> Andrew Wyatt (5):
>>    drm: panel-orientation-quirks: Add support for AYANEO 2S
>>    drm: panel-orientation-quirks: Add quirks for AYA NEO Flip DS and KB
>>    drm: panel-orientation-quirks: Add quirk for AYA NEO Slide
>>    drm: panel-orientation-quirks: Add new quirk for GPD Win 2
>>    drm: panel-orientation-quirks: Add quirk for OneXPlayer Mini (Intel)
>>
>>   .../gpu/drm/drm_panel_orientation_quirks.c    | 40 ++++++++++++++++++-
>>   1 file changed, 38 insertions(+), 2 deletions(-)
>>
> 


  reply	other threads:[~2025-02-12 10:51 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-24 20:46 John Edwards
2025-01-24 20:46 ` [PATCH v2 1/5] drm: panel-orientation-quirks: Add support for AYANEO 2S John Edwards
2025-01-24 20:46 ` [PATCH v2 2/5] drm: panel-orientation-quirks: Add quirks for AYA NEO Flip DS and KB John Edwards
2025-02-12 10:47   ` Hans de Goede
2025-01-24 20:46 ` [PATCH v2 3/5] drm: panel-orientation-quirks: Add quirk for AYA NEO Slide John Edwards
2025-02-12 10:48   ` Hans de Goede
2025-01-24 20:46 ` [PATCH v2 4/5] drm: panel-orientation-quirks: Add new quirk for GPD Win 2 John Edwards
2025-01-24 20:46 ` [PATCH v2 5/5] drm: panel-orientation-quirks: Add quirk for OneXPlayer Mini (Intel) From: Andrew Wyatt <fewtarius@steamfork.org> John Edwards
2025-01-24 20:58   ` John Edwards
2025-01-24 20:52 ` [PATCH v2 5/5] drm: panel-orientation-quirks: Add quirk for OneXPlayer Mini (Intel) John Edwards
2025-02-11 13:55 ` [PATCH v2 0/5] Handheld gaming PC panel orientation quirks Thomas Zimmermann
2025-02-12 10:51   ` Hans de Goede [this message]
2025-02-12 11:11     ` Thomas Zimmermann
2025-02-12 11:14       ` Hans de Goede
2025-02-12 19:59         ` John Edwards
2025-02-13  7:35           ` Thomas Zimmermann
2025-02-13 22:33             ` John Edwards

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6abc98bd-5ef9-491e-985b-7ed8a848c96e@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=airlied@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=fewtarius@steamfork.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=simona@ffwll.ch \
    --cc=tzimmermann@suse.de \
    --cc=uejji@uejji.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®