From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from xry111.site (xry111.site [89.208.246.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5827E61FFE; Mon, 23 Dec 2024 07:16:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=89.208.246.23 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734938174; cv=none; b=K3wN3h9HNh9Oeos+GZSNMdTVzduL1znsOmCIXcQ+Ls8pP3n/PtLI0EmglhT6GhEcnC/w5AG/6RDwbeW2paHaVnFaDFJNsLMWrHaAyTnMaD4BRMICRDaBgD0Yzd7yYQ6n/MTzmHA4r7DvqX0xmUe04jD3kbHoUhKSzIUSsinMW3I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734938174; c=relaxed/simple; bh=ZrcgZL9/LrEEus6L4Sj0r3Gfl0Npm9SW91wzmtQUfGo=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=tFh1YzTy6DuDUV6iTMIG9ynF9nMuaN1Ho49aA+xmM95gY2ppN+sr0pMp0PCKxyXDgPTCp+ZOLZwOuSba1l7q0OEGImco2hIJnP9uHwgvArOtPcE1ffXt7hiFlwmIpbzq3ZLFX+pZzI5wmyVv0/DU60MQdpZzHrQOGoo5vXwJlcw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=xry111.site; spf=pass smtp.mailfrom=xry111.site; dkim=pass (1024-bit key) header.d=xry111.site header.i=@xry111.site header.b=dYLhBand; arc=none smtp.client-ip=89.208.246.23 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=xry111.site Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=xry111.site Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=xry111.site header.i=@xry111.site header.b="dYLhBand" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xry111.site; s=default; t=1734938153; bh=ecGpjQJ+dPTMtl9IS6T8Zx3DPG9sUHrYzmuZ6ugsSWw=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=dYLhBandMXiOWoijdab1gHiwxN4eR/VOe1BsVjVz9qXmRVOFQ3esRLy431bdS1dZk XfvgNo/mfzBUiJSkzYWjXUz9VNZqGIoxmAEmuMRQld4Umwy3a2m4Fwo8gIpR4U1JmC QNQagNSSgXTyOhRij3RWOWxKAWCl+3mSvRV2S1v8= Received: from [127.0.0.1] (unknown [IPv6:2001:470:683e::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature ECDSA (secp384r1) server-digest SHA384) (Client did not present a certificate) (Authenticated sender: xry111@xry111.site) by xry111.site (Postfix) with ESMTPSA id 1944F67671; Mon, 23 Dec 2024 02:15:35 -0500 (EST) Message-ID: <6ac0e0f71990e5a8dc52f00c737cdf56916e0d4e.camel@xry111.site> Subject: Re: [PATCH v7] mm/memblock: Add memblock_alloc_or_panic interface From: Xi Ruoyao To: Mike Rapoport , Guo Weikang Cc: Andrew Morton , Geert Uytterhoeven , Dennis Zhou , Tejun Heo , Christoph Lameter , Thomas Bogendoerfer , Sam Creasey , Huacai Chen , Will Deacon , Catalin Marinas , Oreoluwa Babatunde , rafael.j.wysocki@intel.com, Palmer Dabbelt , Hanjun Guo , Easwar Hariharan , Johannes Berg , Ingo Molnar , Dave Hansen , Christian Brauner , KP Singh , Richard Henderson , Matt Turner , Russell King , WANG Xuerui , Michael Ellerman , Stefan Kristiansson , Stafford Horne , Helge Deller , Nicholas Piggin , Christophe Leroy , Naveen N Rao , Madhavan Srinivasan , Geoff Levand , Paul Walmsley , Palmer Dabbelt , Albert Ou , Andrey Ryabinin , Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Yoshinori Sato , Rich Felker , John Paul Adrian Glaubitz , Andreas Larsson , Richard Weinberger , Anton Ivanov , Johannes Berg , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, kasan-dev@googlegroups.com, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, linux-acpi@vger.kernel.org, xen-devel@lists.xenproject.org, linux-omap@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-mm@kvack.org, linux-pm@vger.kernel.org Date: Mon, 23 Dec 2024 15:15:34 +0800 In-Reply-To: References: <20241222111537.2720303-1-guoweikang.kernel@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.54.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Mon, 2024-12-23 at 09:12 +0200, Mike Rapoport wrote: > On Sun, Dec 22, 2024 at 07:15:37PM +0800, Guo Weikang wrote: > > Before SLUB initialization, various subsystems used memblock_alloc to > > allocate memory. In most cases, when memory allocation fails, an immedi= ate > > panic is required. To simplify this behavior and reduce repetitive chec= ks, > > introduce `memblock_alloc_or_panic`. This function ensures that memory > > allocation failures result in a panic automatically, improving code > > readability and consistency across subsystems that require this behavio= r. > >=20 > > Changelog: > > ---------- > > v1: initial version > > v2: add __memblock_alloc_or_panic support panic output caller > > v3: panic output phys_addr_t use printk's %pap > > v4: make __memblock_alloc_or_panic out-of-line, move to memblock.c > > v6: Fix CI compile error > > Links to CI: https://lore.kernel.org/oe-kbuild-all/202412221000.r1NzXJU= O-lkp@intel.com/ > > v6: Fix CI compile warinigs > > Links to CI: https://lore.kernel.org/oe-kbuild-all/202412221259.JuGNAUC= q-lkp@intel.com/ > > v7: add chagelog and adjust function declaration alignment format > > ---------- > >=20 > > Signed-off-by: Guo Weikang > > Reviewed-by: Andrew Morton > > Reviewed-by: Geert Uytterhoeven > > Reviewed-by: Mike Rapoport (Microsoft) > > Acked-by: Xi Ruoyao >=20 > If people commented on your patch it does not mean you should add > Reviewed-by or Acked-by tags for them. Wait for explicit tags from the > reviewers. And: - Acked-by: indicates an agreement by another developer (often a maintainer of the relevant code) that the patch is appropriate for inclusion into the kernel.=20 I'm not a maintainer so I even don't have the right to use Acked-by :). --=20 Xi Ruoyao School of Aerospace Science and Technology, Xidian University