From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934106AbdEVSSe (ORCPT ); Mon, 22 May 2017 14:18:34 -0400 Received: from david.siemens.de ([192.35.17.14]:53994 "EHLO david.siemens.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933895AbdEVSSa (ORCPT ); Mon, 22 May 2017 14:18:30 -0400 Subject: Re: gpio-exar: Why filtering out Commtech devices? From: Jan Kiszka To: Technical Support Cc: Sudip Mukherjee , Linux Kernel Mailing List , linux-serial , linux-gpio References: <18f4b5cb-cba0-aab4-7958-84a5b8d28935@siemens.com> <7a25751e-931f-b713-dcdd-7a7483aae115@codethink.co.uk> Message-ID: <6ac3fff4-5d23-d30c-1e04-e5a1f12f466d@siemens.com> Date: Mon, 22 May 2017 20:18:21 +0200 User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017-05-22 18:24, Jan Kiszka wrote: > On 2017-05-22 17:17, Technical Support wrote: >> Hello, >> >> The Exar MPIO pins are used by our device driver to control features of >> the line driver and can't be used as GPIO pins. I agree, the condition >> can be moved to 8250_exar prior to a platform device being created for >> the gpio_exar driver. >> > > Thanks a lot for the feedback! I will send a refactoring patch. Hmm, are you possibly talking about PCI device with the IDs 0x2, 0x4, 0xa, 0xb (4222PCI335, 4224PCI335, 2324PCI335, 2328PCI335), because those actually set the GPIOs for apparent internal reasons. However, 0x20..0x22 (4222PCIE, 4224PCIE, 4228PCIE) already share setup_gpio() via pci_xr17v35x_setup(), and that looks different. I'm also asking again because we just changed the default MPIO settings for the latter to all inputs. If you depended on them to be all outputs and 0, we may have broken something. Thanks, Jan -- Siemens AG, Corporate Technology, CT RDA ITP SES-DE Corporate Competence Center Embedded Linux