From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752022AbdAYKvK (ORCPT ); Wed, 25 Jan 2017 05:51:10 -0500 Received: from szxga01-in.huawei.com ([58.251.152.64]:11338 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751625AbdAYKvJ (ORCPT ); Wed, 25 Jan 2017 05:51:09 -0500 Subject: Re: [PATCH] mm/migration: make isolate_movable_page always defined To: , References: <1485340563-60785-1-git-send-email-xieyisheng1@huawei.com> CC: , , , , , , From: Yisheng Xie Message-ID: <6ac6ec39-08d4-e8eb-4528-72e14a8cc0e7@huawei.com> Date: Wed, 25 Jan 2017 18:50:03 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: <1485340563-60785-1-git-send-email-xieyisheng1@huawei.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.29.40] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A090204.588882F4.0097,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 847e4bdd0f792357bc7b6a7e9937a743 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Andrew, Minchan, and all: My former patch "HWPOISON: soft offlining for non-lru movable page" will cause compiled error when disable CONFIG_MIGRATION. And this is a patch to fixe it by define isolate_movable_page as a static inline function with !CONFIG_MIGRATION. Could you please help to review it ? Thanks so much~ I am so sorry about that. Thanks. Yisheng Xie On 2017/1/25 18:36, Yisheng Xie wrote: > Define isolate_movable_page as a static inline function when > CONFIG_MIGRATION is not enable. It should return false > here which means failed to isolate movable pages. > > This patch do not have any functional change but to resolve compile > error caused by former commit "HWPOISON: soft offlining for non-lru > movable page" with CONFIG_MIGRATION disabled. > > Signed-off-by: Yisheng Xie > --- > include/linux/migrate.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/linux/migrate.h b/include/linux/migrate.h > index ae8d475..631a8c8 100644 > --- a/include/linux/migrate.h > +++ b/include/linux/migrate.h > @@ -56,6 +56,8 @@ static inline int migrate_pages(struct list_head *l, new_page_t new, > free_page_t free, unsigned long private, enum migrate_mode mode, > int reason) > { return -ENOSYS; } > +static inline bool isolate_movable_page(struct page *page, isolate_mode_t mode) > + { return false; } > > static inline int migrate_prep(void) { return -ENOSYS; } > static inline int migrate_prep_local(void) { return -ENOSYS; } >