Re: [PATCH 1/1] platform/x86: hp-wmi: support profiles for HP Laptop 15

["Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>]

On Sat, 16 May 2026, yoy95104 wrote:

> From: yahia ahmed <yahia.a.abdrabou@gmail.com>
> 
> Added board 8B2F to the victus_s_thermal_profile_boards table,
> although it is marketed as a notebook, as said in the hp app,

I don't think hp app has much relevance here.

> my testing confirms it utilizes the same underlying
> structure as other Victus models. In addition i added prt sc
> key and mapped it to event 0xb7 and assigned it to KEY_PRINT.

Please don't combine changes but make a patch series out of them, make 
only one logical (minimal) change per patch.

Write the changelog with imperative tone.

> Signed-off-by: yahia ahmed <yahia.a.abdrabou@gmail.com>
> ---
>  drivers/platform/x86/hp/hp-wmi.c | 18 ++++++++++++++----
>  1 file changed, 14 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/platform/x86/hp/hp-wmi.c b/drivers/platform/x86/hp/hp-wmi.c
> index 6950bec2a9d8..693031aa1f11 100644
> --- a/drivers/platform/x86/hp/hp-wmi.c
> +++ b/drivers/platform/x86/hp/hp-wmi.c
> @@ -11,6 +11,7 @@
>   * Copyright (C) 2005 Dmitry Torokhov <dtor@mail.ru>
>   */
>  
> +#include <linux/input-event-codes.h>
>  #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
>  
>  #include <linux/acpi.h>
> @@ -36,6 +37,13 @@
>  #include <linux/types.h>
>  #include <linux/workqueue.h>
>  
> +#include <acpi/acpi_bus.h>
> +#include <acpi/acpi_drivers.h>
> +
> +#ifndef ACPI_AC_CLASS
> +#define ACPI_AC_CLASS "ac_adapter"
> +#endif
> +
>  MODULE_AUTHOR("Matthew Garrett <mjg59@srcf.ucam.org>");
>  MODULE_DESCRIPTION("HP laptop WMI driver");
>  MODULE_LICENSE("GPL");
> @@ -205,10 +213,6 @@ static const struct dmi_system_id victus_s_thermal_profile_boards[] __initconst
>  		.matches = { DMI_MATCH(DMI_BOARD_NAME, "8BBE") },
>  		.driver_data = (void *)&victus_s_thermal_params,
>  	},
> -	{
> -		.matches = { DMI_MATCH(DMI_BOARD_NAME, "8BC2") },
> -		.driver_data = (void *)&omen_v1_thermal_params,
> -	},
>  	{
>  		.matches = { DMI_MATCH(DMI_BOARD_NAME, "8BCA") },
>  		.driver_data = (void *)&omen_v1_thermal_params,
> @@ -253,6 +257,10 @@ static const struct dmi_system_id victus_s_thermal_profile_boards[] __initconst
>  		.matches = { DMI_MATCH(DMI_BOARD_NAME, "8D87") },
>  		.driver_data = (void *)&omen_v1_no_ec_thermal_params,
>  	},
> +	{
> +		.matches = { DMI_MATCH(DMI_BOARD_NAME, "8B2F") },
> +		.driver_data = (void *)&victus_s_thermal_params,
> +	},
>  	{},
>  };
>  
> @@ -407,6 +415,7 @@ struct bios_rfkill2_state {
>  static const struct key_entry hp_wmi_keymap[] = {
>  	{ KE_KEY, 0x02,    { KEY_BRIGHTNESSUP } },
>  	{ KE_KEY, 0x03,    { KEY_BRIGHTNESSDOWN } },
> +	{ KE_KEY, 0xb7,		{ KEY_PRINT } },
>  	{ KE_KEY, 0x270,   { KEY_MICMUTE } },
>  	{ KE_KEY, 0x20e6,  { KEY_PROG1 } },
>  	{ KE_KEY, 0x20e8,  { KEY_MEDIA } },
> @@ -1086,6 +1095,7 @@ static int camera_shutter_input_setup(void)
>  	int err;
>  
>  	camera_shutter_input_dev = input_allocate_device();
> +
>  	if (!camera_shutter_input_dev)
>  		return -ENOMEM;

There seem to be lots of unexplained and spurious changes in this?

Also, it makes changes that do not follow the usual conventions.

I'm intentionally vague here with my review as it's looks obvious you 
didn't properly review this change yourself before submitting it.
I suspect this patch comes directly from some tool/AI which you should 
have disclosed as per Documentation/process/generated-content.rst.

If you use such a tool, please carefully review its output whether the 
output makes sense or not compared with the intent of the change as 
stated in the changelog, before sending the patch towards us.

Also make sure the changes do not diverge from normal kernel coding style 
and surroundings you're touching (unless there's a very good reason for 
that you can point to as "why" you're diverging).

-- 
 i.