From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx.nabladev.com (mx.nabladev.com [178.251.229.89]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 963862DF132; Tue, 17 Mar 2026 17:20:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=178.251.229.89 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773768050; cv=none; b=I258Lh7PjOK1Xlp/sIuhgPBGwGIzDI3IK9jQ1QQwQrQXGETnn7PcCRKi0X5Blp4qTd8WE4IRWQW7Bfd79PgbXBB9UNu3tekOpF6o/L9OKCLK/LLMSP44M8nu7JUKSvRaXYZokH56ApY1MHczRJDDfjm3ynUrrolOdLJH2fB7cOQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773768050; c=relaxed/simple; bh=E8iGa2mmDPj3sCEE2QV26eCTzbwh+nIaRgunYN5pihc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ShepaxZA1ii91uMrYMQgdPUfhi2BBQQhGtTXsUFOewguka5qDeflxFiYDAV/EJGDU7zSIGwG8u+PzgG3QtJNs880bsYerrQ8w03epectAY/0bMlt3a+sDYL+f408kBfihDi9mIxcoQ5FNfgmvr6eXJDH63+nBUDhv1kfbTDzg30= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nabladev.com; spf=pass smtp.mailfrom=nabladev.com; dkim=pass (2048-bit key) header.d=nabladev.com header.i=@nabladev.com header.b=aTN8Yiz9; arc=none smtp.client-ip=178.251.229.89 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nabladev.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nabladev.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nabladev.com header.i=@nabladev.com header.b="aTN8Yiz9" Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 32A7B10D90E; Tue, 17 Mar 2026 18:20:37 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nabladev.com; s=dkim; t=1773768040; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:content-language:in-reply-to:references; bh=ER1Wx1cLo48PWOXiIHDwWNLWadUbn+AOiGeXP4sXszM=; b=aTN8Yiz9hBMF4UUOfecSjMgGKpOQg0aHaiq5TV18OviysEmB/UfIMUyjcmqtUDXz5D6A/E nGDdBoX8T+CpT3lja3J+SQCvPNghVsCzjymc2+n4kJjSH8d4OZJAWZcM45yE0FeySYYEbf TbWHPhT+bVQshlQdewle2AMdqY/maZU4e3OSbv/jdnuOPpNsBmAnLRLgUmIkzKSaGlyD8G d2no3yitMLOA+eDWgStEKyQoFrxW0LHv1SVcw/LshGyBJMRzdol97OMob+I+Cq1ml2tPub 55TUfBDxBp0jCklBSNwK1L+tjtlv04hloidZ21C3FYJoa9z6u+xlRz3Vb0Fb0w== Message-ID: <6ad18fb7-75e8-4ef6-909c-0f2c356fa8ac@nabladev.com> Date: Tue, 17 Mar 2026 18:20:36 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH] dmaengine: xilinx_dma: Fix per-channel direction reporting via device_caps To: Rahul Navale , Folker Schwesinger Cc: Rahul Navale , dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, vkoul@kernel.org, Frank.Li@kernel.org, michal.simek@amd.com, suraj.gupta2@amd.com, thomas.gessler@brueckmann-gmbh.de, radhey.shyam.pandey@amd.com, tomi.valkeinen@ideasonboard.com, marex@denx.de References: <20260317104933.4846-1-rahulnavale04@gmail.com> Content-Language: en-US From: Marek Vasut In-Reply-To: <20260317104933.4846-1-rahulnavale04@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Last-TLS-Session-Version: TLSv1.3 On 3/17/26 11:49 AM, Rahul Navale wrote: > From: Rahul Navale > > Hi Folker, > >> Just to double check, and to make sure the regression you're seeing is >> not a combination of any additional, yet unknown side-effects, could you >> perform one more test? >> In dmaengine_pcm_pointer() (the function we just patched), could you >> replace the call to snd_dmaengine_pcm_pointer() with >> snd_dmaengine_pcm_pointer_no_residue() while keeping 7e01511443c3 active >> and test if this fixes your issue or not? > > I have performed the test (replace the call in dmaengine_pcm_pointer() > function of provided patch) while keeping 7e01511443c3 active. > I see issue is fixed audio is working with this. > > Hi Marek, > >> I came to the same conclusion, that the residue handling is broken in >> the xilinx DMA driver for cyclic transfers, and the fix is below, with >> two extra fixes in top: > > I have tested the provided patches the audio is not fixed with this. Do you have any other patches applied on the xilinx DMA driver by any chance ? If yes, make sure you only test these three.