From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756548AbdCXLWP (ORCPT ); Fri, 24 Mar 2017 07:22:15 -0400 Received: from mail-ve1eur01on0115.outbound.protection.outlook.com ([104.47.1.115]:35072 "EHLO EUR01-VE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751274AbdCXLWI (ORCPT ); Fri, 24 Mar 2017 07:22:08 -0400 Authentication-Results: the-dreams.de; dkim=none (message not signed) header.d=none;the-dreams.de; dmarc=none action=none header.from=axentia.se; Subject: Re: [PATCH] i2c: mux: pca954x: Add missing pca9546 definition to chip_desc To: Mike Looijmans , References: <1490259636-16859-1-git-send-email-mike.looijmans@topic.nl> CC: , From: Peter Rosin Organization: Axentia Technologies AB Message-ID: <6ad1df75-ceef-9b94-6c66-e6ba569221b4@axentia.se> Date: Fri, 24 Mar 2017 12:21:58 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <1490259636-16859-1-git-send-email-mike.looijmans@topic.nl> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [81.224.171.159] X-ClientProxiedBy: DB6PR0601CA0043.eurprd06.prod.outlook.com (10.169.209.29) To AM5PR0202MB2547.eurprd02.prod.outlook.com (10.173.89.8) X-MS-Office365-Filtering-Correlation-Id: 8af25490-9eea-49cc-8501-08d472a7fef0 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:AM5PR0202MB2547; X-Microsoft-Exchange-Diagnostics: 1;AM5PR0202MB2547;3:pdVSwqAQkechf9Z4GED1wBUGpqR2x3dM7IoQgw6pWCg/uKcLKQaM6XL9Tirz0TsAafDTctLphTK/8KQuq8a/y9iwDeVzqEZM59AxoRZQmQ5yF/IYzRWziqKSr7nPkEE4qecI18Ovgu5IU66tobLZFjHeFB4uNdHGtr1DW3nJA+DBEBu5CXiDg7uL5bCwUykOrUR+UUiZzVNtglf0IAoxP4awNL4T2NTu7Z5WwpfrceWWnmRDGvekurPNMuLLIz56xT0SpXTDOOv1taVEniuwrw==;25:Ot8ONXsZlcctb7ROHCLxj0t2qyYpYWGcu52cChh7uqcOXKc67l8zi5PZIL5TeXcPPH1cT1G/QmPzCdSue+dRI9x71Bgfn3nbfWYh4Sp70rHyszoQLi+OGFuKhpVy5jdGKsskZHCXlMECquwPcjwp0GcVW2qqui5o+R42+8r9C19GyW3L/CcwSbA8nV+ZBG2zpOD50Gx8BFD8U3PYZBVWHnxRtuedA8/SpePELtW7dZ9TzkRacZQ1x2M5bKW00Mz79AgANG78SlgtcjBNaDFPoMu/6oL3xZtyTRVtAmx8n/mtduCDdwKrT6l3Zfofgnu69nX/f5iBNdOiRZG/aAPH7BxT0CKvzG3DKAFIWKHIHj2Vi0y7nyDZDMCbePs7uIFZcy/RHUOBZC9zKcLURRvupaa0r/t8Ro8tIdtPG0lIbU8a1yvO9ReTT/kXkxTfuBSRypfJxufbJcRV7HvJuQmStw== X-Microsoft-Exchange-Diagnostics: 1;AM5PR0202MB2547;31:x5nqghL2MAzSsEexRFMYuVV8FqoEEFBJfmFZU2X0CeKDKJnkmOk0Zg+3bArR8pT2F+uvQkARSAJTt/VeMfMH3l7S0NeLm4WIIrWIn8F+tzJdjYYVk6WIopcODpT/wJCExAgV+aegW+yHvvZUJ97mbL8h3V2ycHGekJepkyboLNK61exl+NzDVYfjo4tGNXh3FH5Ga+mj5lISoxi7ckqtiIfkeLrsE072pl/WppyXE+xo8u7n9F1N0vq6TaLiXbamfJm/Zv+oldr523FGxMyUFg== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6041248)(20161123555025)(20161123560025)(20161123558025)(20161123562025)(20161123564025)(2016111802025)(6043046)(6072148);SRVR:AM5PR0202MB2547;BCL:0;PCL:0;RULEID:;SRVR:AM5PR0202MB2547; X-Microsoft-Exchange-Diagnostics: 1;AM5PR0202MB2547;4:Ajo2RdpfSRnEHEk5gEaQefr4A8e0+m90ecACvflh32e+gfIZ9rwlMFNMgt0OZyL5355aheDdtCHpT6qhdnUTPk1aQKBIraNuUdct1GSCppSYdLbgITSq21UPppbH/rh51iiFzzr/FZ+al/TemyX9Q5kkfC2Sg67+jQ44ZE9RSYTuI/2T3WtKwV5pP/iiwYljr8XeNE8a8to4XrK9CjoJHPwcDK3L+A+KOneeHgJ3g0SiiUP+f7KJSJyAL5VXHFHiJnsWs3QksRBUdmdxAfueA1MmxqDxZ0nCejn4oDKWvssjchU51nIyvJI8a/S+Jc47upnlRcZPzhKieLqGl+ckAT9uvd6gWjhgXMjghC5LxJaYU/4wgC7NokdWttc8wsaS2oYjjhh5YuLV5LyyYESYVVcC00hJ4AsXxO2op11ic8U5BmFa0fhOus/sXZgTbBmPK4M/yFsnmgmUilTz1w4v3R32HxaP83xSXHP3X94HDZB/pVoW9shmVjYc5FWcG+FkTBxC5V1m/Xdy30dyaMKD5H5CYOOxgyqSkiHm5m5pta+tFOj/XuDPErTRR5jQMiTHNBzJAszQxERKqei+9RN78IN/pFAmHMTB++YYvbNsRqN88jtaTqI6kUM4OuKPBnv8XJmGh6WBrQtz6+Nt49SbtKWM32IUWxHfTpPLXPCKaiU= X-Forefront-PRVS: 0256C18696 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6049001)(6009001)(39410400002)(39450400003)(39830400002)(24454002)(377424004)(65956001)(7736002)(5660300001)(81166006)(74482002)(2906002)(66066001)(4326008)(575784001)(65806001)(230700001)(31696002)(8676002)(38730400002)(86362001)(6486002)(6246003)(229853002)(64126003)(3260700006)(42186005)(4001350100001)(47776003)(54906002)(83506001)(6116002)(23746002)(50466002)(25786009)(305945005)(6666003)(117156001)(3846002)(90366009)(2950100002)(189998001)(53936002)(50986999)(76176999)(33646002)(65826007)(54356999)(77096006)(31686004)(36756003)(42262002);DIR:OUT;SFP:1102;SCL:1;SRVR:AM5PR0202MB2547;H:[192.168.0.125];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;AM5PR0202MB2547;23:Wxtdng1oATnSyni/j3WDjyYhGvh49W1hMoX?= =?Windows-1252?Q?+2t0hDZScDmQgPd1HJlucllyFaLLb+nVh8JO0Ifig8ff9tTEHheAHH1F?= =?Windows-1252?Q?BpkxPCKLSn7x2nCVvpGBQbt0hO0AhMs82yoRB1Rks0gP/ceN8GvyxAU7?= =?Windows-1252?Q?jvmTi48OekHux57kEsaA6tV1+IRXKKbSEcRN6DckvGyRXrxLZTnfDHYg?= =?Windows-1252?Q?Td5MZuvdpgPn4fhsOyJoeY0wyRIo7XoxHlrxShiv+At9nvE7h84nGcb5?= =?Windows-1252?Q?a2j52jzD6ls9V6nwN/GyFtVOt8RFL70EnkLxeZtf+kqYxm40bg4Rf4f/?= =?Windows-1252?Q?r7VX79+pEb60sVxhoV5c9u2MJ0mCeE2QF0LqV68VRXPNnCqOCWQjIddy?= =?Windows-1252?Q?o8QmEDQvxoCIh2W+iPz3F4yOPIGYUXK1Y1BodTa2ZawTXKa0yaqdnmZm?= =?Windows-1252?Q?AAufL9ZMTarmPpT2eIGcdu+XOzbzAYHh3P8GVrZX6cznOKrcyrhtPpc9?= =?Windows-1252?Q?jVhY0XzWn//2nSKGQCziLyjmgpPIqoz0a9TxdAAO6ycLvcph9a3grQd5?= =?Windows-1252?Q?hruf3yMEy7MXxfAm9I8zLtOS6RnlFTLAjxApba1pNk/JgYPUI6ltXisl?= =?Windows-1252?Q?ypi3+RS2sd9k5K9e/Rj/5Zz7Npfa/GPWiCh0b+SBQrAMlm9D4XJ+unnk?= =?Windows-1252?Q?v4HPMY3gLwLK2BX+GqY3T/+4F2zEVYH8lhjG9eahlMQqpunO9khNJCWx?= =?Windows-1252?Q?lXkn/hWBDQeSKXjyM+8UC94A7paWcF1Q3flX4jRPrXEWFdQGRENQLMIo?= =?Windows-1252?Q?IKYsfu6iH/drwFe9Jpp0dOkNlUVxtAcWLMUH5YYzaoeW2vk70mhzWT+c?= =?Windows-1252?Q?bWjWCjtOF3wK5Dw4+yq8kdlyYknuA1FL/7zdecvQElh9EMNw6Gv8r7tX?= =?Windows-1252?Q?DHXJ5AFsTXdccaYtoScocMJVPNqQL9x2jk7+MO1PSSNPRvhd6IG42xQz?= =?Windows-1252?Q?g2goD+9hteXfWhfxT6Zhaf42cOOT7c7+2Ttk7BHavhvly0X1X1RSB85L?= =?Windows-1252?Q?bS5gV8/jCLb2RpVq1UTwtEuQXJ+UUSIGeji263kccVSzvlTQgUnpE3DI?= =?Windows-1252?Q?c6AaBjm5OmFF3m1eb9L5gg4V7DW7SBwtGe6uJ7yV/1fps4F2GhXwXb8i?= =?Windows-1252?Q?QuFz8f8Xloyw2EayKcxrEfr+eYcYs63Y6KojvtV+qMehCs4SRzrq939u?= =?Windows-1252?Q?0L0+J16CfqZh+aZ6hsiB41R15mi5b8Q8ebFN7jqlx3aU2ovtAkhksONf?= =?Windows-1252?Q?VmygFUuoXyE9yF1GVpqjAu4v5JsC3L3qopFUZ3hDG5gjU7N1g6ohyEhI?= =?Windows-1252?Q?pj/Vqw0zTpUZM4bg4TbzEMFMCAwsAbWfSAEFksoxVFz4gUKH6sCdSffX?= =?Windows-1252?Q?4r+jlaLqm0POMaF5tjsM4?= X-Microsoft-Exchange-Diagnostics: 1;AM5PR0202MB2547;6:5njW34uHktkLcMg98iJncGynbmqAfG9Iv0JcEz6cbUOA68BsEfZjohyGpF58nVoLY/0dxNnxR0xNd4TiO9zLxnwtoOhRs7lsSFHEm36rZT0CeRwBNMjtMYiG9c3vDUGpesJq0J4iREGMVLMLwjA40XP2xFTkRcB2cAnNYASM7+o60C486P6qXXwBt+AVEMO0p7XA97mdhqpTY7v3gCUkbK50aiTmg6dJAnsVcIXCLxe5wTMy7U2P8sq0I21Hi9ppsX2F1AjEATef9jxfnqtuHTJWJ9OL+CU5UBixewSECCVJFEMLd9Q0gI6rcgyMv2Q3ZZXv8YkWaTkJWIOEN5Ro4tzt93wNsvyRsm/BcFX+rcbZiP9EY79Y0O7vc6AQV8DiTOP+2v+hehxsWh1H+APp/w==;5:9RlZeUleD5cSW8tMFgSOEY0I0tfnYfLERAsanW3fRPlHThIzOjJB5T51v2DjhyR3Ow1K2n+UY2BXA4NwMOpeRkiPI0MMu6bsfCl/FQnG7Hq9PmZbjxxjLa4bIN1CJWrOeiicG9KfUttA7a4qMNc/sg==;24:CNzIzYRsO8XA6bQAurDQ7FMcy51x+PSjhLD2qQtwSLyUNNZyLgI8zyt7fNxVdHS0tB0ucf4UrTdKqPE3xXVfdSFSk7JVvMcNRhXOsrNFGdY= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;AM5PR0202MB2547;7:1uZDyZN+vUXjukY8lTchIb6PV6Wz6DefCb5Nlin5EK67EWAOBmS3phNRQSehX909V+iIT2LrY9bgqFZ2M6FnCIdlpsNc39OXRLHgGB8WzmCQt2aId3+7nT+oTs37ASiIu0u+vz2YEoLi7kvt9iV+HpmQI1BifdhI4RXvQaTke/n6VuopsIw90rvvGUEleRoP4k/dhsAYgmbRMvvkdmufhNFCCamHj/kk8zzjMeWKA7rkQVnz7RvFXaFn9oqwx4Fxe83aGTJqsun3cUFHh9qJ8dffIzm95cwN+jU2/AVlglGE8MD3BlhIwwMdBCNbwjDFTrth6lsJxDrx4Kg0BRm2AA== X-OriginatorOrg: axentia.se X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Mar 2017 11:22:02.2107 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0202MB2547 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017-03-23 10:00, Mike Looijmans wrote: > The spec for the pca9546 was missing. This chip is the same as the pca9545 > except that it lacks interrupt lines. While the i2c_device_id table mapped > the pca9546 to the pca9545 definition the compatible table did not. Ouch, good catch, I have committed this to my i2c-mux for-current branch. Cheers, peda > Signed-off-by: Mike Looijmans > --- > drivers/i2c/muxes/i2c-mux-pca954x.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/i2c/muxes/i2c-mux-pca954x.c b/drivers/i2c/muxes/i2c-mux-pca954x.c > index dfc1c0e..69c2f5a 100644 > --- a/drivers/i2c/muxes/i2c-mux-pca954x.c > +++ b/drivers/i2c/muxes/i2c-mux-pca954x.c > @@ -117,6 +117,10 @@ struct pca954x { > .has_irq = 1, > .muxtype = pca954x_isswi, > }, > + [pca_9546] = { > + .nchans = 4, > + .muxtype = pca954x_isswi, > + }, > [pca_9547] = { > .nchans = 8, > .enable = 0x8, > @@ -134,7 +138,7 @@ struct pca954x { > { "pca9543", pca_9543 }, > { "pca9544", pca_9544 }, > { "pca9545", pca_9545 }, > - { "pca9546", pca_9545 }, > + { "pca9546", pca_9546 }, > { "pca9547", pca_9547 }, > { "pca9548", pca_9548 }, > { } >