From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E44CEC433E0 for ; Fri, 15 Jan 2021 05:46:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AD662239EF for ; Fri, 15 Jan 2021 05:46:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733279AbhAOFpi (ORCPT ); Fri, 15 Jan 2021 00:45:38 -0500 Received: from szxga06-in.huawei.com ([45.249.212.32]:10970 "EHLO szxga06-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732340AbhAOFpa (ORCPT ); Fri, 15 Jan 2021 00:45:30 -0500 Received: from DGGEMS414-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4DH98s0gH1zj4lX; Fri, 15 Jan 2021 13:43:57 +0800 (CST) Received: from [10.174.177.244] (10.174.177.244) by DGGEMS414-HUB.china.huawei.com (10.3.19.214) with Microsoft SMTP Server id 14.3.498.0; Fri, 15 Jan 2021 13:44:42 +0800 Subject: Re: [PATCH v2] initramfs: Provide a common initrd reserve function To: Palmer Dabbelt CC: , , , , Atish Patra , , Paul Walmsley References: From: Kefeng Wang Message-ID: <6ad30931-85a1-37a1-ce80-9a8752ebb22a@huawei.com> Date: Fri, 15 Jan 2021 13:44:42 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Originating-IP: [10.174.177.244] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021/1/15 10:33, Palmer Dabbelt wrote: > On Wed, 13 Jan 2021 18:33:58 PST (-0800), wangkefeng.wang@huawei.com > wrote: >> The ARM and riscv have same logic to check and reserve >> the memory of initrd, let's provide a common function to >> reduce duplicated code. >> >> Add __LINUX_INITRD_H define in initrd.h to prevent build error >> (found by kernel test robot ) from the multiple >> inclusion of same header file multiple time. > > This is doing a bunch of different things: > > * Fixing the lack of a preprocessor guard in initrd.h > * Adding some generic code. > * Converting two architectures over to that generic code. > > It needs to be split into four patches.  I'm happy to take them via > the RISC-V tree (with an Ack from for the arch/arm/ stuff), but not > all together. > > It looks like csky copied this as well, they at least have exactly the > same message. Send v3, according to the suggestion,thanks.