From: Paolo Bonzini <pbonzini@redhat.com>
To: Thomas Gleixner <tglx@linutronix.de>, Miaohe Lin <linmiaohe@huawei.com>
Cc: rkrcmar@redhat.com, sean.j.christopherson@intel.com,
vkuznets@redhat.com, wanpengli@tencent.com, jmattson@google.com,
joro@8bytes.org, mingo@redhat.com, bp@alien8.de, hpa@zytor.com,
x86@kernel.org, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] KVM: remove redundant code in kvm_arch_vm_ioctl
Date: Mon, 21 Oct 2019 10:56:21 +0200 [thread overview]
Message-ID: <6ad3a479-5015-10c7-3f32-70f3ed1ecf64@redhat.com> (raw)
In-Reply-To: <alpine.DEB.2.21.1910211015260.1904@nanos.tec.linutronix.de>
On 21/10/19 10:16, Thomas Gleixner wrote:
> Can you please get rid of that odd jump label completely?
>
> if (irqchip_kernel(kvm))
> r = kvm_vm_ioctl_set_irqchip(kvm, chip);
Keeping the label has the advantage of making the get and set cases a
bit more similar (the get case has to do a copy_to_user after
kvm_vm_ioctl_get_irqchip returns). Unfortunately struct kvm_irqchip is
quite big (520 bytes) so we don't allocate it on the stack.
So I queued Miaohe's patch.
Paolo
next prev parent reply other threads:[~2019-10-21 8:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-21 2:52 Miaohe Lin
2019-10-21 8:16 ` Thomas Gleixner
2019-10-21 8:56 ` Paolo Bonzini [this message]
2019-10-21 8:39 linmiaohe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ad3a479-5015-10c7-3f32-70f3ed1ecf64@redhat.com \
--to=pbonzini@redhat.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=sean.j.christopherson@intel.com \
--cc=tglx@linutronix.de \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®