From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754603AbcE3Jpk (ORCPT ); Mon, 30 May 2016 05:45:40 -0400 Received: from m199-177.yeah.net ([123.58.177.199]:40221 "EHLO m199-177.yeah.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752561AbcE3Jpi (ORCPT ); Mon, 30 May 2016 05:45:38 -0400 Subject: Re: [PATCH] mmc: core: fix the wrong error control To: Jaehoon Chung , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org References: <1464594014-31934-1-git-send-email-jh80.chung@samsung.com> Cc: shawn.lin@rock-chips.com, ulf.hansson@linaro.org, arnd@arndb.de, a.hajda@samsung.com, akpm@linux-foundation.org, torvalds@linux-foundation.org, k.kozlowski@samsung.com From: Shawn Lin Message-ID: <6ad3f39a-9ff6-6992-d9d4-8bc411128219@kernel-upstream.org> Date: Mon, 30 May 2016 17:45:28 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: <1464594014-31934-1-git-send-email-jh80.chung@samsung.com> Content-Type: text/plain; charset=gbk; format=flowed Content-Transfer-Encoding: 8bit X-HM-Spam-Status: e1koWUFPN1dZCBgUCR5ZQVZIVUhISUtLS0tKTEpNTUpITExXWQkOFx4IWU FZKCs9JDU#Li8pOjckMjUkMz46Pz4pQUtVS0A2IyQiPigkMjUkMz46Pz4pQUtVS0ArLykkIj4oJD I1JDM#Oj8#KUFLVUtAODQuNS8pIiQ4NUFLVUtAKT48MjQ1JDooMjpBS1VLQCspNC0yNTg#JD0uMT I6NUFLVUtAPyI1OjYyOCQyKyQ1NCQyNSQzPjo*PilBS1VLQDYuNy8yJCk4Ky8kPzI9PT4pPjUvJD I1JDM#Oj8#KUFJVUtAMiskLzQ*OiIkODUvJEskSktLQUtVS0AyKyRKJDYyNS4vPiQ4NS8kSyRKS0 FLVUtAMiskSEskNjI1Li8#JDg1LyRLJE5LQUtVS0AyKyROJDYyNS4vPiQ4NS8kSyRKS0FLVUtAMi skSiQzNC4pJDg1LyRLJEpLS0FLVUtAKC45MT44LyQvND86IiQ4NS8kSyRKS0tBS1VLQCguOTE#OC 8kSiQzNC4pJDg1LyRLJEpLS0FLVUtAKC45MT44LyROJDYyNS4vPiQ4NS8kSyRKS0FLVUtAKDkxJD c#NSRPSyQjQUtVS0tKS0AvPiMvJDc#NSRKSUNLJCNBS1VLS0pLQDg1LyQzLzY3JDc#NSRKMCROME FLVUtLSktALz4jLy4pNyQ#IzIoL0FLVUtLSktAKT44PjItPikkODUvJE4kI0FLVUtLSktAIzY6Mj c#KSQ1Ljc3QUtVS0tKS0A*PjcyLT4pJDc#NSRLQUtVS0tKS0A3OjU8JDg1QUtVS0tKS0A9NSQuKT ckMy8vKygkMzcxJEtDS0pLQ0FLVUtAPTUkNjoiJE9KQiQzNzEkSiRLQ0tIS09BS1VISEA9KyQpPi Q9LCQzNzEkS0NLSEtNQVZMVU5APTUkKC45JD41LDQpPygkMzcxJEpLS0lLSkFLVUlDQCguOSQ#QU pVTk5APTUkNjoiJE9KQiQzNzEkSSRLQ0tIS09BS1VLWQY+ X-HM-Sender-Digest: e1kSHx4VD1lBWUc6MlE6AQw4Fzo#SkIhUSofAStPGRQaCilVSlVKT01P TUtKTkhJT0pMVTMWGhIXVQgTGgwVVRcSFTsQHgkVHhdWDgsIDwkeGhZVFAkcRVlXWQweGVlBHRoX CB5XWQgBWUFIS0tPN1dZEgtZQVlOQ1VJSVVMVUpKT1kG X-HM-Tid: 0a55010dd76b64276b756110568c Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, ÔÚ 2016/5/30 15:40, Jaehoon Chung дµÀ: > After applied "remove lots of IS_ERR_VALUE abuses", it shoold be > misoperation. (commit 287980e49) > If mmc_bus_test is successful, it returned the bus-witdh bit. > > The below log is error log > [ 2.542260] mmc0: mmc_select_hs200 failed, error 3 > [ 2.542275] mmc0: error 3 whilst initialising MMC card > The same as this patch[0]? [0]https://patchwork.kernel.org/patch/9139673/ > Signed-off-by: Jaehoon Chung > --- > drivers/mmc/core/mmc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c > index c984321..aafb73d 100644 > --- a/drivers/mmc/core/mmc.c > +++ b/drivers/mmc/core/mmc.c > @@ -1276,7 +1276,7 @@ static int mmc_select_hs200(struct mmc_card *card) > * switch to HS200 mode if bus width is set successfully. > */ > err = mmc_select_bus_width(card); > - if (!err) { > + if (err > 0) { > val = EXT_CSD_TIMING_HS200 | > card->drive_strength << EXT_CSD_DRV_STR_SHIFT; > err = __mmc_switch(card, EXT_CSD_CMD_SET_NORMAL, > @@ -1583,7 +1583,7 @@ static int mmc_init_card(struct mmc_host *host, u32 ocr, > } else if (mmc_card_hs(card)) { > /* Select the desired bus width optionally */ > err = mmc_select_bus_width(card); > - if (!err) { > + if (err > 0) { > err = mmc_select_hs_ddr(card); > if (err) > goto free_card; >