From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76C3EC4361B for ; Thu, 17 Dec 2020 13:18:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1B901238A0 for ; Thu, 17 Dec 2020 13:18:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727721AbgLQNS4 (ORCPT ); Thu, 17 Dec 2020 08:18:56 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:57258 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726012AbgLQNSz (ORCPT ); Thu, 17 Dec 2020 08:18:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1608211049; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ocVbXd5tOfDrxGvrA5+6ey5fuQhbI9fTf7NbBH/g/Pc=; b=FXCld0sZb7HQQxh8YRNkV0KAs5ZQTXGWlzVyCLx6YEzcX/GWdnecCj+RjVuSDN7J5qV1HY h1MfAzpNbgn68rcykSSZFhEkxJJ+ElhHVmydPHOcT8W6DNxZxf+6u+qOhnd+ulcxRkKRHt k1tz83ZSlaqSgRqq7ccXeuFXGJfHgE8= Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-578-wed9bvt4O1CcTWFtqU7Atw-1; Thu, 17 Dec 2020 08:17:27 -0500 X-MC-Unique: wed9bvt4O1CcTWFtqU7Atw-1 Received: by mail-qk1-f199.google.com with SMTP id n190so22200127qkf.18 for ; Thu, 17 Dec 2020 05:17:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=ocVbXd5tOfDrxGvrA5+6ey5fuQhbI9fTf7NbBH/g/Pc=; b=OIguVx0vN8jrFaFVsa66tRjhI/sCby8y4qTk8f6ggKdBI7GmrYvMP8V2n2obOtkfJB 4CgGOt1K+2F4nwzGIhIoSFfm9ynZX4IuDM/hKdk4G6vJwAF5AHfVnS28HkFTPmCjxzuJ uk6KGde1vF+GUN5L057+GupmVFzRR6ad21o3ZQJQozzFPHmzgtwoO2cIh9IY17MS/T9X yzV3AGct0OBtoX//zd1gL3VT//etTl4keKZu0D1mjboLYHhMvRuVuxXvhxnxX+nRiL53 4NFN7/LdJSRQHFJS5FohOZqivUr8CWJ6YA4+xJWHldPHfGcZV2ODYLNexNbZgbjMqtXO e1CA== X-Gm-Message-State: AOAM533qBwlzYHnrWV3S/lDc6PVSyB35eypkNBRVie1EkZr29ik1Debh 0fJfuAYRZLuMaQb03YIRoF5HmqF/nA8Yuh6gU013EiETzwsdOpMOX6HT9OBa3V/Hdd3YylA1FQh DC+LMd/9NzjISi9umvRSpmZDsbH0zVTPgoFkakm5CUZaJLeLFbDGE/AexxZ0sLjOqXiOhTtI= X-Received: by 2002:aed:3144:: with SMTP id 62mr48589782qtg.342.1608211046974; Thu, 17 Dec 2020 05:17:26 -0800 (PST) X-Google-Smtp-Source: ABdhPJyhFwVGG8Kkax7v/eyJISK93npWC3VG3nlu8liesJbrGCip5EwprgQTQF6BcwFvzS1O4uZAiQ== X-Received: by 2002:aed:3144:: with SMTP id 62mr48589755qtg.342.1608211046674; Thu, 17 Dec 2020 05:17:26 -0800 (PST) Received: from trix.remote.csb (075-142-250-213.res.spectrum.com. [75.142.250.213]) by smtp.gmail.com with ESMTPSA id w192sm3351417qka.68.2020.12.17.05.17.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 17 Dec 2020 05:17:26 -0800 (PST) Subject: Re: [PATCH] atm: ambassador: remove h from printk format specifier To: Jakub Kicinski Cc: 3chas3@gmail.com, linux-atm-general@lists.sourceforge.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20201215142228.1847161-1-trix@redhat.com> <20201216164510.770454d8@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> From: Tom Rix Message-ID: <6ada03ed-1ecb-493b-96f8-5f9548a46a5e@redhat.com> Date: Thu, 17 Dec 2020 05:17:24 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <20201216164510.770454d8@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/16/20 4:45 PM, Jakub Kicinski wrote: > On Tue, 15 Dec 2020 06:22:28 -0800 trix@redhat.com wrote: >> From: Tom Rix >> >> See Documentation/core-api/printk-formats.rst. >> h should no longer be used in the format specifier for printk. >> >> Signed-off-by: Tom Rix > That's for new code I assume? > > What's the harm in leaving this ancient code be? This change is part of a tree wide cleanup. drivers/atm status is listed as Maintained in MAINTAINERS so changes like this should be ok. Should drivers/atm status be changed? Tom > >> diff --git a/drivers/atm/ambassador.c b/drivers/atm/ambassador.c >> index c039b8a4fefe..6b0fff8c0141 100644 >> --- a/drivers/atm/ambassador.c >> +++ b/drivers/atm/ambassador.c >> @@ -2169,7 +2169,7 @@ static void setup_pci_dev(struct pci_dev *pci_dev) >> pci_lat = (lat < MIN_PCI_LATENCY) ? MIN_PCI_LATENCY : lat; >> >> if (lat != pci_lat) { >> - PRINTK (KERN_INFO, "Changing PCI latency timer from %hu to %hu", >> + PRINTK (KERN_INFO, "Changing PCI latency timer from %u to %u", >> lat, pci_lat); >> pci_write_config_byte(pci_dev, PCI_LATENCY_TIMER, pci_lat); >> } >> @@ -2300,7 +2300,7 @@ static void __init amb_check_args (void) { >> unsigned int max_rx_size; >> >> #ifdef DEBUG_AMBASSADOR >> - PRINTK (KERN_NOTICE, "debug bitmap is %hx", debug &= DBG_MASK); >> + PRINTK (KERN_NOTICE, "debug bitmap is %x", debug &= DBG_MASK); >> #else >> if (debug) >> PRINTK (KERN_NOTICE, "no debugging support");