mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: D. Manresa <dmanresa@gmail.com>
To: sakari.ailus@linux.intel.com, hansg@kernel.org
Cc: dan.scally@ideasonboard.com, mchehab@kernel.org, brgl@kernel.org,
	toorandom@gmail.com, linux-media@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 0/2] media: ipu-bridge: survive module unload and reuse the software nodes on rebind
Date: Tue, 03 Nov 2026 09:38:52 -0800 (PST)	[thread overview]
Message-ID: <6aea1c2c.950cae81.3a8700.c477@mx.google.com> (raw)
In-Reply-To: <20261026082549.662885-1-dmanresa@gmail.com>

Please drop 2/2. Bart's driver core fix [1] removes the imbalance that
2/2 compensates for, so on top of it 2/2 leaks a reference instead of
saving one. 1/2 is independent of that and still stands on its own.

For whoever picks this up later: the rebind failure 2/2 was aimed at is
still there with [1] applied. ipu_bridge_init() only unregisters its
IPU HID node on its error path, and ipu6_pci_remove() does not tear the
bridge down, so a PCI remove/rescan leaves the node registered and the
next probe fails -EEXIST. Measured on a Surface Pro 7+ on 7.3 + [1].

The machine that produced the IPU6 numbers in this thread leaves my
hands at the end of the year and I have no other IPU6, so please do
not wait on me for retests.

[1] https://lore.kernel.org/all/20261023-swnode-dev-notify-balance-v2-0-948d920a79f6@oss.qualcomm.com/

      parent reply	other threads:[~2026-11-03 17:38 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-26  8:25 D. Manresa
2026-10-26  8:25 ` [PATCH v5 1/2] media: ipu-bridge: don't reference the module image from software nodes D. Manresa
2026-10-26  8:25 ` [PATCH v5 2/2] media: ipu-bridge: reuse the software nodes on rebind D. Manresa
2026-10-28  5:38 ` [PATCH v5 0/2] media: ipu-bridge: survive module unload and " Sergey Lebedev
2026-10-28 14:41 ` D. Manresa
2026-10-28 14:57   ` Bartosz Golaszewski
2026-11-03 17:38 ` D. Manresa [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6aea1c2c.950cae81.3a8700.c477@mx.google.com \
    --to=dmanresa@gmail.com \
    --cc=brgl@kernel.org \
    --cc=dan.scally@ideasonboard.com \
    --cc=hansg@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    --cc=toorandom@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®