From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A6C2C678D4 for ; Tue, 7 Mar 2023 07:53:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229705AbjCGHxh (ORCPT ); Tue, 7 Mar 2023 02:53:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51250 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229948AbjCGHxQ (ORCPT ); Tue, 7 Mar 2023 02:53:16 -0500 Received: from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com [IPv6:2a00:1450:4864:20::52e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 96C282BEF0 for ; Mon, 6 Mar 2023 23:53:08 -0800 (PST) Received: by mail-ed1-x52e.google.com with SMTP id i34so48763481eda.7 for ; Mon, 06 Mar 2023 23:53:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678175587; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=2fbNVSLqIHvV0bqpOfDOpCzWFojulNanBN36qBfwsNY=; b=rVPWF+vVajj/Wd3RGxj9W095GMsUmEBJ+RFpZsT2scO9I9NRRnLYld/8Q1hJ1G5fwj GmzFnNH9zU/khqjqWTOVykHFA2d+oRCJZtisU8Ic+P2sBTV1fpvBUhs9T5gKgVYeJQyo g8/XAOXuwpAVabq+UbSdS4NOAHMzwzc31lV5sSjyKqAz6BxhkOvAgE4T4Fqp1a2RtjMJ SKeBrvJY83OYH0Oy3vdr73E0NfvlZMbFTNznEuFQH+LPEZWqPAvcBCiiDPh1oE3s1Xes ZGURO/lZdyMOQIPo7tjaCnaUzxLwetkd9bqk4R7yFrYEcQF4pIIKUTmiu+2R19RzG3yk uqZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678175587; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2fbNVSLqIHvV0bqpOfDOpCzWFojulNanBN36qBfwsNY=; b=fw/G284izrqFqmJdBUNF6IxM3hOvh9uzlcG3LcRZUoBpZD1GotW0Y5/RE25OGa6b8k Lo9vHGSvMlg2uWA1TU63e1zoguP/F98j2gVih9vvNi/eUzdAaUc1AVhSURrOZwD9/QHC oXxgta9NAI4f0V3N7PzAtBwNiJeTU1t5PZMqCuolpcMnVWCTIWXiOFvdQU0iPBUfXdsO /ZBxwakRRZztNyIBFyZ+B43y36gU74DS0j6eM7zjfKtlsCzuzoB7SG6jGj98kNCR3Fhv 2phVP/QCWw3iiCnid90hSdZ5w7OjxWTCexpL0qZSjsKAZJeUc4/q3g/m5SfdASiV7TGM 4KhQ== X-Gm-Message-State: AO0yUKUyynXoczPgEZ2I/awRdzfRJCOAJqeRHpsNL/m2ewX8inZpo9ge fsc3GjypGo+MQJZ5vGsT8Vqk3Q== X-Google-Smtp-Source: AK7set86p4C3BL6LTMri6M4GNxY1CcyOYdrJhQ/9UfGZbb6pzNqA9GJE7GOxr4oUcC+vU7iKO++hNQ== X-Received: by 2002:a17:906:b1cc:b0:8b1:7684:dfab with SMTP id bv12-20020a170906b1cc00b008b17684dfabmr14962870ejb.38.1678175587076; Mon, 06 Mar 2023 23:53:07 -0800 (PST) Received: from ?IPV6:2a02:810d:15c0:828:5310:35c7:6f9e:2cd3? ([2a02:810d:15c0:828:5310:35c7:6f9e:2cd3]) by smtp.gmail.com with ESMTPSA id b2-20020a50b402000000b004be64b284b2sm6252792edh.3.2023.03.06.23.53.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Mar 2023 23:53:06 -0800 (PST) Message-ID: <6aeaa895-7f99-3598-2490-88eb48735a15@linaro.org> Date: Tue, 7 Mar 2023 08:53:05 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v1 02/11] media: dt-bindings: starfive,jh7110-mipi-csi2: add binding docmuent Content-Language: en-US To: Jack Zhu , Mauro Carvalho Chehab , Robert Foss , Todor Tomov , Rob Herring , Krzysztof Kozlowski , Maxime Ripard , Philipp Zabel Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, changhuang.liang@starfivetech.com References: <20230302091921.43309-1-jack.zhu@starfivetech.com> <20230302091921.43309-3-jack.zhu@starfivetech.com> <11e7c986-e6cc-ee57-b36e-816af8cc11a7@linaro.org> <30000009-cf05-988a-9817-97a7af36db37@starfivetech.com> From: Krzysztof Kozlowski In-Reply-To: <30000009-cf05-988a-9817-97a7af36db37@starfivetech.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/03/2023 07:41, Jack Zhu wrote: > > > On 2023/3/3 16:47, Krzysztof Kozlowski wrote: >> On 02/03/2023 10:19, jack.zhu wrote: >>> Add DT binding document for Starfive MIPI CSI2 receiver >> >> Ehh... you have entire commit msg to explain what you do here. Yet there >> is nothing mentioning that you actually have Cadence MIPI CSI here. >> >> Since you decided to add new bindings, you receive review matching new >> bindings. I don't think this is correct approach (duplicated bindings), >> but could work for me. However how are you going to solve all the points >> of my review? > > Maybe I don't need to add the CSI yaml file, since it already exists on the Linux mainline. If you add *only* new compatible, you do not need new binding. If you add any new properties, then depends, but old binding anyway would need conversion from TXT. Best regards, Krzysztof