From: Andrew Lunn <andrew@lunn.ch>
To: Tomer Maimon <tmaimon77@gmail.com>
Cc: davem@davemloft.net, edumazet@google.com, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, alexandre.torgue@foss.st.com,
peppe.cavallaro@st.com, joabreu@synopsys.com,
mcoquelin.stm32@gmail.com, avifishman70@gmail.com,
tali.perry1@gmail.com, joel@jms.id.au,
andrew@codeconstruct.com.au, venture@google.com,
yuenn@google.com, benjaminfair@google.com, j.neuschaefer@gmx.net,
openbmc@lists.ozlabs.org, netdev@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v1 2/2] net: stmmac: Add NPCM support
Date: Tue, 21 Nov 2023 17:00:53 +0100 [thread overview]
Message-ID: <6aeb28f5-04c2-4723-9da2-d168025c307c@lunn.ch> (raw)
In-Reply-To: <20231121151733.2015384-3-tmaimon77@gmail.com>
> +void npcm_dwmac_pcs_init(struct npcm_dwmac *dwmac, struct device *dev,
> + struct plat_stmmacenet_data *plat_dat)
> +{
> + u16 val;
> +
> + iowrite16((u16)(SR_MII_CTRL >> 9), dwmac->reg + IND_AC_BA_REG);
> + val = ioread16(dwmac->reg + PCS_SR_MII_CTRL_REG);
> + val |= PCS_RST;
> + iowrite16(val, dwmac->reg + PCS_SR_MII_CTRL_REG);
> +
> + while (val & PCS_RST)
> + val = ioread16(dwmac->reg + PCS_SR_MII_CTRL_REG);
> +
> + val &= ~(PCS_AN_ENABLE);
> + iowrite16(val, dwmac->reg + PCS_SR_MII_CTRL_REG);
> +}
Is this a licensed PCS implementation? Or home grown? If its been
licensed from somebody, it maybe should live in driver/net/pcs, so
others can reuse it when they license the same core.
Andrew
next prev parent reply other threads:[~2023-11-21 16:01 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-21 15:17 [PATCH v1 0/2] net: stmmac: add NPCM dwmac support Tomer Maimon
2023-11-21 15:17 ` [PATCH v1 1/2] dt-bindings: net: Add support NPCM dwmac Tomer Maimon
2023-11-21 17:21 ` Krzysztof Kozlowski
2023-11-21 15:17 ` [PATCH v1 2/2] net: stmmac: Add NPCM support Tomer Maimon
2023-11-21 15:45 ` Russell King (Oracle)
2023-11-22 17:23 ` Tomer Maimon
2023-11-27 15:58 ` Russell King (Oracle)
2023-11-30 17:15 ` Tomer Maimon
2023-11-21 16:00 ` Andrew Lunn [this message]
2023-11-22 17:50 ` Tomer Maimon
2023-11-22 18:45 ` Andrew Lunn
2023-11-23 13:50 ` Tomer Maimon
2023-11-27 15:19 ` Tomer Maimon
2023-11-28 23:31 ` Andrew Lunn
2023-11-30 17:17 ` Tomer Maimon
2023-11-30 17:26 ` Andrew Lunn
2023-11-30 18:25 ` Tomer Maimon
2023-11-30 19:59 ` Serge Semin
2023-11-30 20:34 ` [Linux-stm32] " Maxime Chevallier
2023-12-01 16:25 ` Serge Semin
2023-11-22 2:11 ` kernel test robot
2023-11-22 4:45 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6aeb28f5-04c2-4723-9da2-d168025c307c@lunn.ch \
--to=andrew@lunn.ch \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew@codeconstruct.com.au \
--cc=avifishman70@gmail.com \
--cc=benjaminfair@google.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=j.neuschaefer@gmx.net \
--cc=joabreu@synopsys.com \
--cc=joel@jms.id.au \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=peppe.cavallaro@st.com \
--cc=robh+dt@kernel.org \
--cc=tali.perry1@gmail.com \
--cc=tmaimon77@gmail.com \
--cc=venture@google.com \
--cc=yuenn@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®