From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934879AbbEOQDB (ORCPT ); Fri, 15 May 2015 12:03:01 -0400 Received: from mail.kmu-office.ch ([178.209.48.109]:42262 "EHLO mail.kmu-office.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934569AbbEOQC7 (ORCPT ); Fri, 15 May 2015 12:02:59 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Date: Fri, 15 May 2015 18:01:19 +0200 From: Stefan Agner To: Thomas Gleixner Cc: shawn.guo@linaro.org, kernel@pengutronix.de, jason@lakedaemon.net, marc.zyngier@arm.com, linux@arm.linux.org.uk, u.kleine-koenig@pengutronix.de, olof@lixom.net, arnd@arndb.de, daniel.lezcano@linaro.org, mark.rutland@arm.com, pawel.moll@arm.com, robh+dt@kernel.org, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, mcoquelin.stm32@gmail.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 04/12] irqchip: vf610-mscm: support NVIC parent In-Reply-To: References: <1431203982-13217-1-git-send-email-stefan@agner.ch> <1431203982-13217-5-git-send-email-stefan@agner.ch> Message-ID: <6af49d55159182668c21480e0fbaa85c@agner.ch> User-Agent: Roundcube Webmail/1.1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015-05-15 12:39, Thomas Gleixner wrote: > On Sat, 9 May 2015, Stefan Agner wrote: >> - irq_chip_unmask_parent(data); >> + if (parent->chip->irq_enable) >> + parent->chip->irq_enable(parent); >> + else >> + parent->chip->irq_unmask(parent); > > Why are you not creating irq_chip_enable_parent() which would have > been the proper function anyway? > Will add that... Btw, have you had a chance to look at 1/12? I added a helper there too to allow make use of generic chip with IRQ domain hierarchy. In case you are fine with that general appraoch I will send an updated version of the patchset with the irq_chip_enable_parent helper soon. -- Stefan