From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752778AbcELKS1 (ORCPT ); Thu, 12 May 2016 06:18:27 -0400 Received: from smtp.domeneshop.no ([194.63.252.55]:53124 "EHLO smtp.domeneshop.no" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751512AbcELKS0 (ORCPT ); Thu, 12 May 2016 06:18:26 -0400 Subject: Re: [PATCH v2 6/6] drm: Add helper for simple display pipeline To: Daniel Vetter References: <1462982962-10530-1-git-send-email-noralf@tronnes.org> <1462982962-10530-7-git-send-email-noralf@tronnes.org> <20160511170910.GU27098@phenom.ffwll.local> <20160512081119.GV27098@phenom.ffwll.local> Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org From: =?UTF-8?Q?Noralf_Tr=c3=b8nnes?= Message-ID: <6af69339-13f1-433e-b343-dfa4dff9734c@tronnes.org> Date: Thu, 12 May 2016 12:18:21 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: <20160512081119.GV27098@phenom.ffwll.local> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Den 12.05.2016 10:11, skrev Daniel Vetter: > On Wed, May 11, 2016 at 07:09:10PM +0200, Daniel Vetter wrote: >> On Wed, May 11, 2016 at 06:09:22PM +0200, Noralf Trønnes wrote: >>> +/** >>> + * drm_simple_display_pipe_init - Initialize a simple display pipeline >>> + * @dev: DRM device >>> + * @pipe: simple display pipe object to initialize >>> + * @funcs: callbacks for the display pipe (optional) >>> + * @formats: array of supported formats (%DRM_FORMAT_*) >>> + * @format_count: number of elements in @formats >>> + * @connector: connector to attach and register >>> + * >>> + * Sets up a display pipeline which consist of a really simple >>> + * plane-crtc-encoder pipe coupled with the provided connector. >> How are drivers supposed to release this stuff again? Maybe add: >> >> "Teardown of a simple display pipe is all handled automatically by the drm >> core through calling drm_mode_config_cleanup()." > Thought a bit more about this, maybe we should also add "Drivers > afterwards need to release the memory for the structure themselves." > > Btw one other thing I realized is that there's no atomic_commit for this. > How do you plane to implement async commit? No need to address this right > away, we can discuss it when you've rebased tinydrm and submit that for > review. > -Daniel I don't follow you here. Isn't this atomic_commit: drm_atomic_helper_commit => drm_atomic_helper_commit_planes => drm_simple_kms_plane_atomic_update => pipe->funcs->update Noralf.