From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Mukesh Ojha <quic_mojha@quicinc.com>,
andersson@kernel.org, robh@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] arm64: dts: qcom: sm8450: Add qfprom node
Date: Fri, 15 Mar 2024 20:46:06 +0100 [thread overview]
Message-ID: <6af70342-0a87-46d6-8aaf-c44174017438@linaro.org> (raw)
In-Reply-To: <69a8c14c-109a-103a-b8dc-d8e303c0f0d5@quicinc.com>
On 14.03.2024 17:43, Mukesh Ojha wrote:
> Sorry for the late reply, was on vacation.
>
> On 3/6/2024 9:24 PM, Konrad Dybcio wrote:
>>
>>
>> On 3/6/24 13:26, Mukesh Ojha wrote:
>>> Add the qfprom node for sm8450 SoC.
>>>
>>> Signed-off-by: Mukesh Ojha <quic_mojha@quicinc.com>
>>> ---
>>> arch/arm64/boot/dts/qcom/sm8450.dtsi | 7 +++++++
>>> 1 file changed, 7 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi
>>> index b86be34a912b..02089a388d03 100644
>>> --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi
>>> +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi
>>> @@ -4575,6 +4575,13 @@
>>> };
>>> };
>>> + qfprom: efuse@221c8000 {
>>> + compatible = "qcom,sm8450-qfprom", "qcom,qfprom";
>>> + reg = <0 0x221c8000 0 0x1000>;
>>
>> Is is really only 0x1000-long? Also, is the base you put
>> here the ECC-corrected part (if that still exists)?
>
> No, its not.
>
> Entire fuse space is this.
> 0x221C0000-0x221Cbfff
>
> ECC corrected range is this 0x221C2000-0x221C3fff and High level OS
> does have a access to ECC range however, they are not recommended for
> SW usage.
Are you sure? Bjorn always insisted to use the corrected bit.
The ancient APQ8016 TRM also mentions this:
QFPROM Corrected Region - [...] This region is intended for
functional use of the QFPROM stored data by software.
>
> Above mentioned SW range(4) in the patch is one and only accessible range available out of 0-7 SW ranges(0x221C4000-0x221Cbfff with each
> size 0x1000) and does not have ECC fuses.
>
> All the downstream use cases are getting fulfilled with this.
Right, and I don't quite get why there's an corrected region if
it sits unused.
Konrad
next prev parent reply other threads:[~2024-03-15 19:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-06 12:26 [PATCH 0/3] Add eFuse region for Qualcomm SoCs Mukesh Ojha
2024-03-06 12:26 ` [PATCH 1/3] arm64: dts: qcom: sm8450: Add qfprom node Mukesh Ojha
2024-03-06 15:54 ` Konrad Dybcio
2024-03-14 16:43 ` Mukesh Ojha
2024-03-15 19:46 ` Konrad Dybcio [this message]
2024-03-18 1:21 ` Bjorn Andersson
2024-05-28 15:37 ` Bjorn Andersson
2024-05-29 14:12 ` Mukesh Ojha
2024-03-06 12:26 ` [PATCH 2/3] arm64: dts: qcom: sm8550: " Mukesh Ojha
2024-03-06 12:26 ` [PATCH 3/3] arm64: dts: qcom: sm8650: " Mukesh Ojha
2024-03-06 15:08 ` [PATCH 0/3] Add eFuse region for Qualcomm SoCs Krzysztof Kozlowski
2024-03-14 16:49 ` Mukesh Ojha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6af70342-0a87-46d6-8aaf-c44174017438@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_mojha@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®