From: Krzysztof Kozlowski <krzk@kernel.org>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
lee@kernel.org, alim.akhtar@samsung.com, s.nawrocki@samsung.com,
m.szyprowski@samsung.com, ideal.song@samsung.com,
beomho.seo@samsung.com
Cc: linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH v2 3/3] mfd: exynos-lpass: Fix another error handling path in exynos_lpass_probe()
Date: Wed, 23 Apr 2025 18:33:49 +0200 [thread overview]
Message-ID: <6af9145e-2682-43d6-8315-223c26c69e18@kernel.org> (raw)
In-Reply-To: <69471e839efc0249a504492a8de3497fcdb6a009.1745247209.git.christophe.jaillet@wanadoo.fr>
On 21/04/2025 17:00, Christophe JAILLET wrote:
> If devm_of_platform_populate() fails, some clean-up needs to be done, as
> already done in the remove function.
>
> Add a new devm_add_action_or_reset() to fix the leak in the probe and
> remove the need of a remove function.
>
> Fixes: c695abab2429 ("mfd: Add Samsung Exynos Low Power Audio Subsystem driver")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> Compile tested only.
>
> Changes in v2:
> - Use a new devm_add_action_or_reset() to fix the leak in the probe
> and remove the need of a remove function.
> - Update the commit description accordingly
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-04-23 16:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-21 15:00 [PATCH v2 0/3] mfd: exynos-lpass: Fix some error handling paths Christophe JAILLET
2025-04-21 15:00 ` [PATCH v2 1/3] mfd: exynos-lpass: Fix an error handling path in exynos_lpass_probe() Christophe JAILLET
2025-04-21 15:00 ` [PATCH v2 2/3] mfd: exynos-lpass: Avoid calling exynos_lpass_disable() twice in exynos_lpass_remove() Christophe JAILLET
2025-04-21 15:00 ` [PATCH v2 3/3] mfd: exynos-lpass: Fix another error handling path in exynos_lpass_probe() Christophe JAILLET
2025-04-23 16:33 ` Krzysztof Kozlowski [this message]
2025-05-01 11:18 ` [PATCH v2 0/3] mfd: exynos-lpass: Fix some error handling paths Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6af9145e-2682-43d6-8315-223c26c69e18@kernel.org \
--to=krzk@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=beomho.seo@samsung.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=ideal.song@samsung.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=s.nawrocki@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®