From: Christian Marangi <ansuelsmth@gmail.com>
To: Maxime Chevallier <maxime.chevallier@bootlin.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@kernel.org>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Simon Horman <horms@kernel.org>, Jonathan Corbet <corbet@lwn.net>,
Shuah Khan <skhan@linuxfoundation.org>,
Randy Dunlap <rdunlap@infradead.org>,
Lorenzo Bianconi <lorenzo@kernel.org>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
Philipp Zabel <p.zabel@pengutronix.de>,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Bill Wendling <morbo@google.com>,
Justin Stitt <justinstitt@google.com>,
"Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, llvm@lists.linux.dev
Subject: Re: [PATCH net-next v21 07/15] net: phylink: add capabilities helper and track modified advertising
Date: Mon, 16 Nov 2026 17:37:47 +0100 [thread overview]
Message-ID: <6afb315f.7f974077.2e08bb.6940@mx.google.com> (raw)
In-Reply-To: <20261116163412.551438-8-ansuelsmth@gmail.com>
On Mon, Nov 16, 2026 at 05:33:50PM +0100, Christian Marangi wrote:
> In preparation for PCS release/late attach, it's needed to introduce an
> helper to calculate the capabilities after a PCS is removed/added and it's
> needed to track the advertising in link_config changed by the user compared
> to the originally one calculated in phylink_create().
>
> To archieve this, introduce dedicated advertising variables in phylink
> struct and update it when the new phylink_update_capabilities() is called
> or advertise is updated in link_config.
>
> In phylink struct the new advertising will contain the full advertising
> bits right after a phylink_validate and the new user_disabled_advertising
> will be the mask of modes that were disabled from an ethtool ksettings
> (with the parsing done in phylink_update_user_disabled_advertising()).
>
> This double reference is needed to account case when a PCS gets removed and
> attached again to preserve user-defined advertising rules.
>
> phylink_update_capabilities() will calculate the new supported modes and
> the new capabilities, update the full advertising in phylink and restore
> the user-disabled modes.
>
> phylink_create() is also updated to init the phylink advertising and
> link_config advertising.
>
> phylink_update_mac_pause_capabilities() is updated to use the new
> phylink_update_capabilities() to account for user-disabled advertising
> modes and update the full advertising in phylink.
>
> phylink_sfp_set_config() and phylink_choose_sfp_interface() are updated to
> account for the user-disabled modes, first in the
> phylink_sfp_interface_preference loop and then on updating the link_config
> advertising.
>
> Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
This is a leftover from the title rename... Please ignore.
--
Ansuel
next prev parent reply other threads:[~2026-11-16 16:37 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 16:33 [PATCH net-next v21 00/15] net: pcs: Introduce support for fwnode PCS Christian Marangi
2026-11-16 16:33 ` [PATCH net-next v21 01/15] net: phylink: make PCS phylink instance access RCU protected Christian Marangi
2026-11-16 16:33 ` [PATCH net-next v21 02/15] net: phylink: keep and use MAC supported_interfaces in phylink struct Christian Marangi
2026-11-16 16:33 ` [PATCH net-next v21 03/15] net: phylink: introduce internal phylink PCS handling Christian Marangi
2026-11-16 16:33 ` [PATCH net-next v21 04/15] net: pcs: implement Firmware node support for PCS driver Christian Marangi
2026-11-16 16:33 ` [PATCH net-next v21 05/15] net: phylink: save phylink instance fwnode on phylink_create Christian Marangi
2026-11-16 16:33 ` [PATCH net-next v21 06/15] net: phylink: make phylink_validate state locked Christian Marangi
2026-11-16 16:33 ` [PATCH net-next v21 07/15] net: phylink: add capabilities helper and track modified advertising Christian Marangi
2026-11-16 16:37 ` Christian Marangi [this message]
2026-11-16 16:33 ` [PATCH net-next v21 07/15] net: phylink: add capabilities helpers " Christian Marangi
2026-11-16 16:33 ` [PATCH net-next v21 08/15] net: phylink: support PCS provider release Christian Marangi
2026-11-16 16:33 ` [PATCH net-next v21 09/15] net: phylink: support late PCS provider attach Christian Marangi
2026-11-16 16:33 ` [PATCH net-next v21 10/15] net: Document PCS subsystem Christian Marangi
2026-11-16 16:33 ` [PATCH net-next v21 11/15] MAINTAINERS: add myself as PCS subsystem maintainer Christian Marangi
2026-11-16 16:33 ` [PATCH net-next v21 12/15] net: phylink: add .pcs_link_down PCS OP Christian Marangi
2026-11-16 16:33 ` [PATCH net-next v21 13/15] dt-bindings: net: pcs: Document support for Airoha Ethernet PCS Christian Marangi
2026-11-16 16:33 ` [PATCH net-next v21 14/15] net: pcs: airoha: add PCS driver for Airoha AN7581 SoC Christian Marangi
2026-11-16 16:33 ` [PATCH net-next v21 15/15] net: airoha: add phylink support Christian Marangi
2026-11-16 16:38 ` [PATCH net-next v21 00/15] net: pcs: Introduce support for fwnode PCS netdev-bot+sinfo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6afb315f.7f974077.2e08bb.6940@mx.google.com \
--to=ansuelsmth@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@kernel.org \
--cc=hkallweit1@gmail.com \
--cc=horms@kernel.org \
--cc=justinstitt@google.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=llvm@lists.linux.dev \
--cc=lorenzo@kernel.org \
--cc=maxime.chevallier@bootlin.com \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=netdev@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=rdunlap@infradead.org \
--cc=rmk+kernel@armlinux.org.uk \
--cc=robh@kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®