From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2EF48C433F5 for ; Fri, 8 Apr 2022 01:36:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233470AbiDHBij (ORCPT ); Thu, 7 Apr 2022 21:38:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45312 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230247AbiDHBie (ORCPT ); Thu, 7 Apr 2022 21:38:34 -0400 Received: from mailgw01.mediatek.com (unknown [60.244.123.138]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D8BA5103B8C for ; Thu, 7 Apr 2022 18:36:32 -0700 (PDT) X-UUID: d52a4ffa836f408aa4a8bd25f04c60d3-20220408 X-UUID: d52a4ffa836f408aa4a8bd25f04c60d3-20220408 Received: from mtkexhb02.mediatek.inc [(172.21.101.103)] by mailgw01.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 2074834216; Fri, 08 Apr 2022 09:36:19 +0800 Received: from mtkcas11.mediatek.inc (172.21.101.40) by mtkmbs10n2.mediatek.inc (172.21.101.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.792.3; Fri, 8 Apr 2022 09:36:17 +0800 Received: from mtksdccf07 (172.21.84.99) by mtkcas11.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Fri, 8 Apr 2022 09:36:17 +0800 Message-ID: <6afe7366ceffb77674d34c48f84aa85b1c088bc3.camel@mediatek.com> Subject: Re: [PATCH] drm/mediatek: dpi: Use mt8183 output formats for mt8192 From: CK Hu To: "=?ISO-8859-1?Q?N=EDcolas?= F. R. A. Prado" , Philipp Zabel , Chun-Kuang Hu , , CC: David Airlie , , , , Matthias Brugger , , , AngeloGioacchino Del Regno Date: Fri, 8 Apr 2022 09:36:17 +0800 In-Reply-To: <20220408011907.672120-1-nfraprado@collabora.com> References: <20220408011907.672120-1-nfraprado@collabora.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-MTK: N Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Jitao & Rex: Please help to comment on this patch. On Thu, 2022-04-07 at 21:19 -0400, Nícolas F. R. A. Prado wrote: > The configuration for mt8192 was incorrectly using the output formats > from mt8173. Since the output formats for mt8192 are instead the same > ones as for mt8183, which require two bus samples per pixel, the > pixelclock and DDR edge setting were misconfigured. This made > external > displays unable to show the image. > > Fix the issue by correcting the output format for mt8192 to be the > same > as for mt8183, fixing the usage of external displays for mt8192. > > Signed-off-by: Nícolas F. R. A. Prado > > --- > > drivers/gpu/drm/mediatek/mtk_dpi.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c > b/drivers/gpu/drm/mediatek/mtk_dpi.c > index 4554e2de1430..e61cd67b978f 100644 > --- a/drivers/gpu/drm/mediatek/mtk_dpi.c > +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c > @@ -819,8 +819,8 @@ static const struct mtk_dpi_conf mt8192_conf = { > .cal_factor = mt8183_calculate_factor, > .reg_h_fre_con = 0xe0, > .max_clock_khz = 150000, > - .output_fmts = mt8173_output_fmts, > - .num_output_fmts = ARRAY_SIZE(mt8173_output_fmts), > + .output_fmts = mt8183_output_fmts, > + .num_output_fmts = ARRAY_SIZE(mt8183_output_fmts), > }; > > static int mtk_dpi_probe(struct platform_device *pdev)