From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761992AbcINMwP (ORCPT ); Wed, 14 Sep 2016 08:52:15 -0400 Received: from mx2.suse.de ([195.135.220.15]:55263 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756072AbcINMwN (ORCPT ); Wed, 14 Sep 2016 08:52:13 -0400 Subject: Re: [PATCH 15/15] hisi_sas: send three identify before phy up To: John Garry , jejb@linux.vnet.ibm.com, martin.petersen@oracle.com References: <1473176185-217808-1-git-send-email-john.garry@huawei.com> <1473176185-217808-16-git-send-email-john.garry@huawei.com> Cc: linuxarm@huawei.com, zhangfei.gao@linaro.org, xuwei5@hisilicon.com, john.garry2@mail.dcu.ie, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, NengLong Zhao From: Hannes Reinecke Message-ID: <6aff1701-555e-7ebd-e503-73659c68702e@suse.de> Date: Wed, 14 Sep 2016 14:52:08 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2 MIME-Version: 1.0 In-Reply-To: <1473176185-217808-16-git-send-email-john.garry@huawei.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/06/2016 05:36 PM, John Garry wrote: > When the v2 hw is attached with many disks through > an expander, there may be OOB reset resulting in a PHY > going down after the speed is negotiated (very low > probability). > > This issue is resolved by modifying the link control > registers to send three identify frames before the PHY > is ready (according to 6.10.3.3.2 in SAS 3.0 spec) and > close ready when the PHY is down. > > Signed-off-by: NengLong Zhao > Signed-off-by: John Garry > --- > drivers/scsi/hisi_sas/hisi_sas_v2_hw.c | 20 ++++++++++++++++---- > 1 file changed, 16 insertions(+), 4 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)