From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1CFE542903F for ; Mon, 27 Jul 2026 20:31:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785184308; cv=none; b=WrqBscgETuNgfpcmHUGDxe5h3PdvDyYW1BxPNB09h8fRSm9S9sCPMhyTzOJ51rl/sLGm6EsnzU+4EoeHFidFhFCEGutZLsOu1X/qevHQf+luDe3h/D22HKRArJeiGCCYJcNDFl6oAnAO7F2TPf85ES2NmxXBKyNFTCBHCgS52hk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785184308; c=relaxed/simple; bh=dfK1Fc6Qw/OmRWwSYNowGLxISiw6Dk4jhByn2IbQBHQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=KjBtpx/KlmDFT992O6M0H9lWFY5Bl8xm1Y0HBhj269qiZD0bxWSLrTEuRbPYN2oMpqbdp1YVq7/EOgcS26DrbW/UQzSYtDs0lUtz4jAi0hjMBLUInE+MtbiNJztZlt38bJo/JcExeT3cTqBCV9jrKNo3VKbP/hdXrRI86RDaxo0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=eCRFvQEC; arc=none smtp.client-ip=209.85.214.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eCRFvQEC" Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-2caced6038eso4707985ad.0 for ; Mon, 27 Jul 2026 13:31:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785184306; x=1785789106; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=q2XP6yBpNA7SQvHygf0aGV7DQV6XBLGAfPztCBlAdto=; b=eCRFvQECaOOt9JqvKQKQYJxrbXeM0VvLdiudwdjZC3azyIhvCoa5NuZpveIVK1Y/4I 1FOKhKPrBBrYy5jIf/uFQppUPHI8OezoxfNwY/69NYo4+7S5ExfoxXBI3YAIH1HL+VDT fsUcOW5c/fi5N2ljebFJMnE2KLHZMbxT1dvfisDXZkA4tbA+EEaNSgijjxU6PCW9/wqj QcGLZJBjDSmS8SQiPFPf1vnrCMdoCDt354dZa6HaSqUXobxVrOgHoaC+MxatcJDxJ0AJ FqjMhtZftqJ0AXq+JBtF7B8iyAOZhNPs0wmeB2yGbcB7ucQi2UC700bgonjOZxXYAGt4 DPtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785184306; x=1785789106; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=q2XP6yBpNA7SQvHygf0aGV7DQV6XBLGAfPztCBlAdto=; b=nUj38QcdPtT9CVSticoOEpaxgZm0rpjLzD3+fkrm8NZPQFRy40UIHLcpVRYs6w/ZGh 6gk7lOX891VSelpiTwYWhW0UzX8PZcGWovZxOgjFaxCKrXN7zoRqvUYIaFNY1oWuKJhI ip5pGYRNKAiTT5NIo8O6N5zfuz3gB7MQJw/eKEWaa+6DspsqrJrdi8SGYtEQ38AeyJeL Y6Iq+ABKnD6vPnSRxX09R6E3XGWoqhPwlBpm0UozqL81070V7IynnTRnTQUI1EVyDJqI FzyNsxzAaKPdi18ajMO8TSt4i6P887bxKIJhhDJ6VnY5FYWVlRlzvlDnsX/YTOLoVul4 2Nqg== X-Forwarded-Encrypted: i=1; AHgh+RrIElhkuz4NJlUZCbEE7ZKGQMZOHacjxzs+1dzi/UtRbFTdtSF345XfJm5WhfU/tmTeH8C6aT7X8bm5o80=@vger.kernel.org X-Gm-Message-State: AOJu0YzheqdRzbdVsbQ3jY5Wa5RQnGXuL2pmQNdxKMlyFwpjwgkY0Rsa un5wjxl5ONbxQbMkcaMUUxJf8MC5TnynTeUcn1hs7kJuqnun0sEmzj4JLNpIcA== X-Gm-Gg: AR+sD12qZqiP2tftVhJPICL1Iiixum1x5QzYynwdyUqXKYXkv/1gPKkb3onF6wmWvu/ r+pfJ09jUqIPfpWqsAwBHIkhqSqWz/13YiTAZb6J7NaFuvYQFIm8P1cgfvThuZjZw5XmelhHHqk r9+uC/YtgG0iuJWERpDFgQXsbbVR9xfKJqrv/vQV+QBKlr8cdJnODd8WagE7sFSAbcMPpqahPkn mFscdarBM2lyYu1EStmJ76/PYfOZQOigqCw0JtiRfYuj9ocCkNHAOK/DcnlZS6Od0DB5Q/BwGxe loyJH2YoYXYtTraX5zY3Enx9vH5Zz9lV7sUwSS8gH/OtNWfEhrpBY3Q6R3MAYcSQpi4yHEWDY6F /cBYH+nXddhrVUBtfy06okZpzAC0jdeqkCyDuM0fiA1qLR3GXvREWvWslaEKsSSfw9AMGpKb2rA AIVrJ1 X-Received: by 2002:a17:902:c952:b0:2cc:92ae:b36 with SMTP id d9443c01a7336-2d01221ee93mr2217845ad.24.1785184306489; Mon, 27 Jul 2026 13:31:46 -0700 (PDT) Received: from cryptic.lan ([2001:569:7fab:e200:3789:64f9:8855:c0af]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2cfde59b768sm41551805ad.4.2026.07.27.13.31.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Jul 2026 13:31:46 -0700 (PDT) From: Allen Pais To: Vinod Koul , Frank Li Cc: Allen Pais , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, Arnd Bergmann , Kees Cook Subject: [PATCH v2 11/64] dmaengine: mmp_tdma: hook completions to dma_chan BH Date: Mon, 27 Jul 2026 13:28:39 -0700 Message-ID: <6b016025aba50032c5c1560d237923294a2f6ab5.1785183549.git.allen.lkml@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: <20260108080332.2341725-1-allen.lkml@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Replace the per-channel tasklet with the shared dma_chan BH helper. The handler continues to run in softirq context while dmaengine owns the common scheduling and teardown mechanism. Signed-off-by: Allen Pais --- drivers/dma/mmp_tdma.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/dma/mmp_tdma.c b/drivers/dma/mmp_tdma.c index ba03321eeff7..d1ed2886f0e7 100644 --- a/drivers/dma/mmp_tdma.c +++ b/drivers/dma/mmp_tdma.c @@ -102,7 +102,6 @@ struct mmp_tdma_chan { struct device *dev; struct dma_chan chan; struct dma_async_tx_descriptor desc; - struct tasklet_struct tasklet; struct mmp_tdma_desc *desc_arr; dma_addr_t desc_arr_phys; @@ -320,7 +319,7 @@ static irqreturn_t mmp_tdma_chan_handler(int irq, void *dev_id) struct mmp_tdma_chan *tdmac = dev_id; if (mmp_tdma_clear_chan_irq(tdmac) == 0) { - tasklet_schedule(&tdmac->tasklet); + dma_chan_schedule_bh(&tdmac->chan); return IRQ_HANDLED; } else return IRQ_NONE; @@ -346,9 +345,9 @@ static irqreturn_t mmp_tdma_int_handler(int irq, void *dev_id) return IRQ_NONE; } -static void dma_do_tasklet(struct tasklet_struct *t) +static void dma_do_tasklet(struct dma_chan *c) { - struct mmp_tdma_chan *tdmac = from_tasklet(tdmac, t, tasklet); + struct mmp_tdma_chan *tdmac = container_of(c, struct mmp_tdma_chan, chan); dmaengine_desc_get_callback_invoke(&tdmac->desc, NULL); } @@ -583,7 +582,7 @@ static int mmp_tdma_chan_init(struct mmp_tdma_device *tdev, tdmac->pool = pool; tdmac->status = DMA_COMPLETE; tdev->tdmac[tdmac->idx] = tdmac; - tasklet_setup(&tdmac->tasklet, dma_do_tasklet); + dma_chan_init_bh(&tdmac->chan, dma_do_tasklet); /* add the channel to tdma_chan list */ list_add_tail(&tdmac->chan.device_node, -- 2.43.0