From: Mukesh Ojha <quic_mojha@quicinc.com>
To: <keescook@chromium.org>, <gpiccoli@igalia.com>, <corbet@lwn.net>,
<tony.luck@intel.com>, <robh+dt@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>
Cc: <linux-hardening@vger.kernel.org>, <linux-doc@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>
Subject: Re: [PATCH v2 2/3] Documentation: admin-guide: ramoops.rst: Update the ramoops document
Date: Fri, 13 Jan 2023 18:54:19 +0530 [thread overview]
Message-ID: <6b016170-0d01-ebb3-a47e-4107cabc4403@quicinc.com> (raw)
In-Reply-To: <1673611126-13803-2-git-send-email-quic_mojha@quicinc.com>
Hi,
On 1/13/2023 5:28 PM, Mukesh Ojha wrote:
> The reserved memory region for ramoops is assumed to be at a fixed
> and known location when read from the devicetree. This is not desirable
> in environments where it is preferred the region to be dynamically
> allocated at runtime. So, update the document while adding the
> support in the driver.
>
> Signed-off-by: Mukesh Ojha <quic_mojha@quicinc.com>
> ---
> Change in v2:
> - Added this patch as per changes going to be done in patch 3/3
>
> Documentation/admin-guide/ramoops.rst | 25 ++++++++++++++++++++++---
> 1 file changed, 22 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/admin-guide/ramoops.rst b/Documentation/admin-guide/ramoops.rst
> index e9f8514..88884b2 100644
> --- a/Documentation/admin-guide/ramoops.rst
> +++ b/Documentation/admin-guide/ramoops.rst
> @@ -16,8 +16,9 @@ survive after a restart.
> Ramoops concepts
> ----------------
>
> -Ramoops uses a predefined memory area to store the dump. The start and size
> -and type of the memory area are set using three variables:
> +Ramoops uses both predefined and dynamically memory area to store the dump.
> +The start and size and type of the memory area are set using three
> +variables:
>
> * ``mem_address`` for the start
> * ``mem_size`` for the size. The memory size will be rounded down to a
> @@ -70,7 +71,8 @@ Setting the ramoops parameters can be done in several different manners:
>
> B. Use Device Tree bindings, as described in
> ``Documentation/devicetree/bindings/reserved-memory/ramoops.yaml``.
> - For example::
> +
> + Example of statically reserved ramoops region::
>
> reserved-memory {
> #address-cells = <2>;
> @@ -85,6 +87,23 @@ Setting the ramoops parameters can be done in several different manners:
> };
> };
>
> + Example of dynamically reserved ramoops region::
> +
> + reserved-memory {
> + #address-cells = <2>;
> + #size-cells = <2>;
> + ranges;
> +
> + ramoops@8f000000 {
Will fix it as ramoops_region : ramoops ?
> + compatible = "ramoops";
> + alloc-ranges = <0x0 0x00000000 0xffffffff 0xffffffff>;
> + size = <0 0x100000>;
> + record-size = <0x4000>;
> + console-size = <0x4000>;
> + };
> + };
> +
> +
> C. Use a platform device and set the platform data. The parameters can then
> be set through that platform data. An example of doing that is:
>
-Mukesh
next prev parent reply other threads:[~2023-01-13 13:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-13 11:58 [PATCH v2 1/3] dt-bindings: reserved-memory: ramoops: Update the binding Mukesh Ojha
2023-01-13 11:58 ` [PATCH v2 2/3] Documentation: admin-guide: ramoops.rst: Update the ramoops document Mukesh Ojha
2023-01-13 13:24 ` Mukesh Ojha [this message]
2023-01-13 11:58 ` [PATCH v3 3/3] pstore/ram: Rework logic for detecting ramoops Mukesh Ojha
2023-01-13 12:04 ` [PATCH v2 1/3] dt-bindings: reserved-memory: ramoops: Update the binding Krzysztof Kozlowski
2023-01-13 13:22 ` Mukesh Ojha
2023-01-27 12:29 ` Mukesh Ojha
2023-01-27 12:52 ` Krzysztof Kozlowski
2023-01-13 15:26 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6b016170-0d01-ebb3-a47e-4107cabc4403@quicinc.com \
--to=quic_mojha@quicinc.com \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=gpiccoli@igalia.com \
--cc=keescook@chromium.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®