mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Gary Guo <gary@garyguo.net>
To: Andreas Hindborg <a.hindborg@kernel.org>
Cc: "Miguel Ojeda" <ojeda@kernel.org>,
	"Boqun Feng" <boqun.feng@gmail.com>,
	"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
	"Benno Lossin" <lossin@kernel.org>,
	"Alice Ryhl" <aliceryhl@google.com>,
	"Trevor Gross" <tmgross@umich.edu>,
	"Danilo Krummrich" <dakr@kernel.org>,
	rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rust: sync: add `UniqueArc::as_ptr`
Date: Mon, 16 Feb 2026 01:38:41 +0000	[thread overview]
Message-ID: <6b03d16701160d313c08c9cb12550652@garyguo.net> (raw)
In-Reply-To: <20260215-unique-arc-as-ptr-v1-1-bdf4b3174475@kernel.org>

On 2026-02-15 20:38, Andreas Hindborg wrote:
> Add a method to `UniqueArc` for getting a raw pointer. The 
> implementation
> defers to the `Arc` implementation of the same method.
> 
> Signed-off-by: Andreas Hindborg <a.hindborg@kernel.org>
> ---
>  rust/kernel/sync/arc.rs | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/rust/kernel/sync/arc.rs b/rust/kernel/sync/arc.rs
> index 289f77abf415a..9c70fdd39bd2f 100644
> --- a/rust/kernel/sync/arc.rs
> +++ b/rust/kernel/sync/arc.rs
> @@ -770,6 +770,11 @@ pub fn new_uninit(flags: Flags) -> 
> Result<UniqueArc<MaybeUninit<T>>, AllocError>
>              inner: unsafe { Arc::from_inner(KBox::leak(inner).into()) 
> },
>          })
>      }
> +
> +    /// Return a raw pointer to the data in this unique arc.

Please add an `#[inline]` here and make this function not a method.

Best,
Gary

> +    pub fn as_ptr(&self) -> *const T {
> +        Arc::as_ptr(&self.inner)
> +    }
>  }
> 
>  impl<T> UniqueArc<MaybeUninit<T>> {
> 
> ---
> base-commit: 05f7e89ab9731565d8a62e3b5d1ec206485eeb0b
> change-id: 20260215-unique-arc-as-ptr-32eb209dde1b
> 
> Best regards,

      parent reply	other threads:[~2026-02-16  1:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-15 20:38 Andreas Hindborg
2026-02-15 23:26 ` Benno Lossin
2026-02-16  7:13   ` Andreas Hindborg
2026-02-16 10:12     ` Benno Lossin
2026-02-16  1:38 ` Gary Guo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6b03d16701160d313c08c9cb12550652@garyguo.net \
    --to=gary@garyguo.net \
    --cc=a.hindborg@kernel.org \
    --cc=aliceryhl@google.com \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun.feng@gmail.com \
    --cc=dakr@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lossin@kernel.org \
    --cc=ojeda@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=tmgross@umich.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®