From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42F7EC54EE9 for ; Tue, 13 Sep 2022 09:20:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231530AbiIMJUN (ORCPT ); Tue, 13 Sep 2022 05:20:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49482 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231264AbiIMJUI (ORCPT ); Tue, 13 Sep 2022 05:20:08 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 38B93140A7 for ; Tue, 13 Sep 2022 02:20:04 -0700 (PDT) Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[127.0.0.1]) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1oY25I-0001Z1-22; Tue, 13 Sep 2022 11:20:00 +0200 Message-ID: <6b070f8d-83aa-e816-6c1c-0d084888f9da@pengutronix.de> Date: Tue, 13 Sep 2022 11:19:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH] soc: imx: imx8m-blk-ctrl: Defer probe if 'bus' genpd is not yet ready Content-Language: en-US To: Benjamin Gaignard , shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com Cc: kernel@collabora.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20220913090655.39778-1-benjamin.gaignard@collabora.com> From: Ahmad Fatoum In-Reply-To: <20220913090655.39778-1-benjamin.gaignard@collabora.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2a0a:edc0:0:900:1d::77 X-SA-Exim-Mail-From: a.fatoum@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Benjamin, On 13.09.22 11:06, Benjamin Gaignard wrote: > Depending of the boot sequence 'bus' genpd could be probed after imx8m-blk-ctrl > which led driver probe to fail. Change the returned error to allow > to defer the probe in this case. > > Signed-off-by: Benjamin Gaignard > --- > drivers/soc/imx/imx8m-blk-ctrl.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/soc/imx/imx8m-blk-ctrl.c b/drivers/soc/imx/imx8m-blk-ctrl.c > index dff7529268e4..99f5226a465b 100644 > --- a/drivers/soc/imx/imx8m-blk-ctrl.c > +++ b/drivers/soc/imx/imx8m-blk-ctrl.c > @@ -215,8 +215,7 @@ static int imx8m_blk_ctrl_probe(struct platform_device *pdev) > > bc->bus_power_dev = genpd_dev_pm_attach_by_name(dev, "bus"); > if (IS_ERR(bc->bus_power_dev)) > - return dev_err_probe(dev, PTR_ERR(bc->bus_power_dev), > - "failed to attach power domain \"bus\"\n"); > + return -EPROBE_DEFER; If probe is deferred indefinitely, you lose the very helpful probe error message. Please translate error code instead and keep the dev_err_probe call. Cheers, Ahmad > > for (i = 0; i < bc_data->num_domains; i++) { > const struct imx8m_blk_ctrl_domain_data *data = &bc_data->domains[i]; -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |