From: James Smart <jsmart2021@gmail.com>
To: Sagi Grimberg <sagi@grimberg.me>,
Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
Jens Axboe <axboe@kernel.dk>, Keith Busch <keith.busch@intel.com>,
Johannes Thumshirn <jthumshirn@suse.de>,
Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Cc: kernel test robot <rong.a.chen@intel.com>,
Tejun Heo <tj@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
lkp@01.org
Subject: Re: [LKP] [workqueue] 4d43d395fe: WARNING:at_kernel/workqueue.c:#__flush_work
Date: Mon, 4 Mar 2019 10:38:26 -0800 [thread overview]
Message-ID: <6b0a949b-4696-bb38-6c86-a8f5ff2e1513@gmail.com> (raw)
In-Reply-To: <b247096b-9033-a06b-fd2b-2d0f8611eb97@grimberg.me>
On 3/4/2019 10:21 AM, Sagi Grimberg wrote:
>
>> Forwarding to NMVE people:
>>
>> kernel test robot found that
>> flush_work(&ctrl->async_event_work) is called from nvmet_ctrl_free()
>> without INIT_WORK(&ctrl->async_event_work, nvmet_async_event_work)
>> after ctrl was allocated (probably initialized with 0).
>> Will you make sure that INIT_WORK() is always called?
>
> I cannot reproduce this issue. When following the code I don't
> immediately see how this can happen.. Was there something special
> in this specific test run? Is it 100% reproduce-able?
I agree. INIT_WORK is setup as almost one of the first items for a new
controller. Smells more like a double-free or a corrupt ctrl struct
from the transport.
-- james
prev parent reply other threads:[~2019-03-04 18:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-04 13:41 kernel test robot
2019-03-04 13:53 ` Tetsuo Handa
2019-03-04 18:21 ` Sagi Grimberg
2019-03-04 18:38 ` James Smart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6b0a949b-4696-bb38-6c86-a8f5ff2e1513@gmail.com \
--to=jsmart2021@gmail.com \
--cc=axboe@kernel.dk \
--cc=chaitanya.kulkarni@wdc.com \
--cc=jthumshirn@suse.de \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@01.org \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=rong.a.chen@intel.com \
--cc=sagi@grimberg.me \
--cc=sfr@canb.auug.org.au \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®