From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754188AbcITI4L (ORCPT ); Tue, 20 Sep 2016 04:56:11 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:38714 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753137AbcITI4H (ORCPT ); Tue, 20 Sep 2016 04:56:07 -0400 X-AuditID: cbfec7f2-f79556d000002c42-5f-57e0f9a37eb2 Subject: Re: [PATCH v4 0/3] leds: Introduce userspace leds driver To: David Lechner , Richard Purdie Cc: linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org, Marcel Holtmann , Pavel Machek From: Jacek Anaszewski Message-id: <6b0e0eaa-1e13-e8ff-4b74-b7a608f15055@samsung.com> Date: Tue, 20 Sep 2016 10:56:01 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-version: 1.0 In-reply-to: <1474053410-24387-1-git-send-email-david@lechnology.com> Content-type: text/plain; charset=windows-1252; format=flowed Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupkleLIzCtJLcpLzFFi42LZduzned0lPx+EG3ycz2qxqEHM4vKuOWwW W9+sY7T49ukXo8XdU0fZLHbvesrqwOaxfvdydo9P/SdZPfbM/8HqsWL1d3aPz5vkAlijuGxS UnMyy1KL9O0SuDKmXT7JUrBesOLvhwXsDYzbebsYOTgkBEwkbkxl6mLkBDLFJC7cW8/WxcjF ISSwlFHi/4pOdgjnM6PEg90b2SCqTCSW314E1iEksIxRYsVxXoiiZ4wSn7bdZQFJCAs4Svw4 0gtWJCLgI7Hw7AKwScwCTYwSTbOvs4Mk2AQMJX6+eM0EcgavgJ3EgTUGICaLgKrE/UPJIKao QITE7rupIMW8AoISPybfA5vOKeAqsaX9MNh0ZqBNDxbtZIWw5SU2r3nLDLJJQmARu8Sk55uY IZ6Uldh0gBnifBeJN23PWSFsYYlXx7ewQ9gyEp0dB5kgeiczSlw8dpMVwlnNKLGxs5MFospa ouH/LxaIbXwSk7ZNh1rAK9HRJgRR4iGxquMjVLmjxP7Vc6CBOINRYldLM+MERvlZSB6aheSJ WUieWMDIvIpRJLW0ODc9tdhYrzgxt7g0L10vOT93EyMwgZz+d/zTDsavJ6wOMQpwMCrx8K54 fD9ciDWxrLgy9xCjBAezkgiv/I8H4UK8KYmVValF+fFFpTmpxYcYpTlYlMR59yy4Ei4kkJ5Y kpqdmlqQWgSTZeLglGpgjK69V5ihtim8YHHiOrMoE2HV8I+iW1/MKZrP5+B2wce3aivb1iXP S5KPud9XeJEj1nqTOUNmw/5m9ZbE+HBtmy/7zyWyfueNuDPHdJd19o1eBdY7P5aE78gycmf/ 3Nu37ovrjeOnrsoefVfhan3plpX8GZWpE887PtKcw97De4b1XqL/fPlzSizFGYmGWsxFxYkA zRuAJBwDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrNIsWRmVeSWpSXmKPExsVy+t/xK7rVPx+EG1x9wW6xqEHM4vKuOWwW W9+sY7T49ukXo8XdU0fZLHbvesrqwOaxfvdydo9P/SdZPfbM/8HqsWL1d3aPz5vkAlij3Gwy UhNTUosUUvOS81My89JtlUJD3HQtlBTyEnNTbZUidH1DgpQUyhJzSoE8IwM04OAc4B6spG+X 4JYx7fJJloL1ghV/Pyxgb2DcztvFyMkhIWAisfz2IiYIW0ziwr31bF2MXBxCAksYJebObGaE cJ4xSlw5cZodpEpYwFHix5FesA4RAR+JhWcXsEMUzWKUuL5yAwuIwyzQxCjRvLgJrIpNwFDi 54vXQDYHB6+AncSBNQYgJouAqsT9Q8kgFaICERK3Vn1kBLF5BQQlfky+xwJicwq4SmxpPww2 hVnAVmLB+3UsELa8xOY1b5knMAItRWiZhaRsFpKyBYzMqxhFUkuLc9Nziw31ihNzi0vz0vWS 83M3MQIjatuxn5t3MF7aGHyIUYCDUYmHN+Dh/XAh1sSy4srcQ4wSHMxKIrzyPx6EC/GmJFZW pRblxxeV5qQWH2I0BfphIrOUaHI+MNrzSuINTQzNLQ2NjC0szI2MlMR5Sz5cCRcSSE8sSc1O TS1ILYLpY+LglGpglIp79/KNs0Vg0mNtkfXvFqtU5xT8rZrHGa6Ycnf/h50zCovMUtn+bj7Q b6IRuuN1sf+8fv55Ly12G7rZ6J7wrrbK99WTWDm3+FAUX5bO5t/b333YIcn397tgjuDaR33h VZz+BQyK/5vs2R+cqZq7qvDDn9RGgZibExMPvLrV5uPFs0foHtcWJZbijERDLeai4kQAW91m w74CAAA= X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20160920085603eucas1p2b2df024c50eea0b9edca04018d29e2e9 X-Msg-Generator: CA X-Sender-IP: 182.198.249.179 X-Local-Sender: =?UTF-8?B?SmFjZWsgQW5hc3pld3NraRtTUlBPTC1TeXN0ZW0gRlcgIChN?= =?UTF-8?B?Qikb7IK87ISx7KCE7J6QG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Global-Sender: =?UTF-8?B?SmFjZWsgQW5hc3pld3NraRtTUlBPTC1TeXN0ZW0gRlcgIChN?= =?UTF-8?B?QikbU2Ftc3VuZyBFbGVjdHJvbmljcxtTZW5pb3IgU29mdHdhcmUgRW5naW5l?= =?UTF-8?B?ZXI=?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjc1MjY=?= CMS-TYPE: 201P X-HopCount: 7 X-CMS-RootMailID: 20160916191750eucas1p2437e0fa04cc99964b79cb774ef482e5a X-RootMTR: 20160916191750eucas1p2437e0fa04cc99964b79cb774ef482e5a References: <1474053410-24387-1-git-send-email-david@lechnology.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi David, Thanks for applying the remarks. Since it is close to the merge window now, I'm applying the patch set to the for-4.10 branch of linux-leds.git. Thanks, Jacek Anaszewski On 09/16/2016 09:16 PM, David Lechner wrote: > v2 changes: > > * sort #includes > * fix typo in Kconfig > * Add Documentation text file > > v3 changes: > > * fix typos in docs > * rename "leds class" to "LED class" in docs > * rebase on linux-leds/for-next > > v4 changes: > > * Use devm_led_classdev_register() instead of led_classdev_register() > * Clarified how to create multiple devices in documentation > * uledmon.c now uses blocking reads instead of poll() > * Add some sanity checking on user-provided device name to make sure it is not > a directory name > * Reading from /dev/uleds allows any size read buffer - still only returns one > byte regardless of size > * Reading from /dev/uleds blocks until the brightness is changed > * LEDS_MAX_NAME_SIZE is reduced to 64 to match existing name size limit > * New patch to use LEDS_MAX_NAME_SIZE in drivers/leds/led-class.c > * Moved example code to tool/leds/uledmon.c (new patch with Makefile) > > David Lechner (3): > leds: Introduce userspace leds driver > leds: Use macro for max device node name size > tools/leds: Add uledmon program for monitoring userspace LEDs > > Documentation/leds/uleds.txt | 36 +++++++ > drivers/leds/Kconfig | 8 ++ > drivers/leds/Makefile | 3 + > drivers/leds/led-class.c | 3 +- > drivers/leds/uleds.c | 230 +++++++++++++++++++++++++++++++++++++++++++ > include/uapi/linux/Kbuild | 1 + > include/uapi/linux/uleds.h | 23 +++++ > tools/Makefile | 7 +- > tools/leds/.gitignore | 1 + > tools/leds/Makefile | 13 +++ > tools/leds/uledmon.c | 62 ++++++++++++ > 11 files changed, 383 insertions(+), 4 deletions(-) > create mode 100644 Documentation/leds/uleds.txt > create mode 100644 drivers/leds/uleds.c > create mode 100644 include/uapi/linux/uleds.h > create mode 100644 tools/leds/.gitignore > create mode 100644 tools/leds/Makefile > create mode 100644 tools/leds/uledmon.c >