From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758421AbcHYNIl (ORCPT ); Thu, 25 Aug 2016 09:08:41 -0400 Received: from smtp121.iad3a.emailsrvr.com ([173.203.187.121]:43183 "EHLO smtp121.iad3a.emailsrvr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754537AbcHYNIj (ORCPT ); Thu, 25 Aug 2016 09:08:39 -0400 X-SMTPDoctor-Processed: csmtpprox beta X-Auth-ID: markh@compro.net X-Sender-Id: markh@compro.net Reply-To: markh@compro.net Subject: Re: [PATCH 4.7 146/186] floppy: fix open(O_ACCMODE) for ioctl-only open References: <20160818135932.219369981@linuxfoundation.org> <20160818135938.484441980@linuxfoundation.org> <0df64efc-85fe-1de7-f15f-233f1e5fdad8@compro.net> <20160824201701.GB2133@kroah.com> To: Jiri Kosina , Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Wim Osterholt , Jens Axboe From: Mark Hounschell Organization: Compro Computer Svcs. Message-ID: <6b0f11af-84a4-ef0c-0033-7a10de189813@compro.net> Date: Thu, 25 Aug 2016 09:08:37 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/24/2016 05:11 PM, Jiri Kosina wrote: > On Wed, 24 Aug 2016, Greg Kroah-Hartman wrote: > >>> I have a problem with this patch. It only fixes one of the regressions >>> caused by the original change to the floppy driver. It does not address the >>> user land breakage of removing the NODELAY flag checks. >> >> Does the same problem also happen in Linus's tree? If not, any hints on >> the patch that might have fixed it there? > Yes, it does. IMHO the entire patch (between 4.4 and 4.5 that broke user land multiple ways) should be reverted and a fix for what ever obscure BUG was supposed to be fixed should be "retried". > That's still an unresolved issue, and it's on my list to things to look > into. > > This particular patch though fixes a different issue, and should be > applied to -stable. > This patch fixes a bug that was introduced to fix "some other obscure BUG" that has nothing to do whatever with the "physical floppy" device. And it broke user land in at least 2 ways. All this patch does is revert part of the original patch so that it is only broke in 1 way to user land. It should revert the whole thing IMHO. Regards Mark > Thanks, >