From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1516D290F; Sun, 17 Aug 2025 14:57:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755442679; cv=none; b=Nr5pDttDF7K0FZx32YsF4YWR7mLuKk9N7EZ4rcodN3R4B6KrkBXRbekybA4EpHEj8TuaAE03Ef74NiIj45V/SmCvfAPWT9cmZw4bqJY17UFC15kOhqQeqz8h1jgMCGJchLSW6EGoU3nQpMFFFAwTrb/XdjIh4GHIoIebRB+Nr9s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755442679; c=relaxed/simple; bh=fAvFlJJqYOWnNyPSnXRIgCcz2MA0GUGCioFGwWtR8f0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=PfWbsm41C8NFNxTfmxDaemDJ2vIiHgVjgbfb1z9d3uWwl30jg8DCleF9FMmpPIASqj95u7Vx41o7GuqE1RqGaSdBWCSCT2kQEOX2YdjefBl8WavZvnQJWUdWGkabyR/EwkOJAueeZEKXqYv6xMrTM7Lz6K/YziI6S6WO6blvflk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=O9gOwle/; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="O9gOwle/" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=/s3HWwswGJVbhetzqyV9rkWjvELllA0/5aDo3OGOunY=; b=O9gOwle/E/dlKqhO3XqolD3KJw E3ResiTjiiSb8PrsTBWunk70onEyeRzuw315IoztouabqAUBdtpUFJ+eINW1w8VX4GOKVPRrj5z6A 0k0KfoZI6wtqNwLEsbIR6KNnggVkFwV3vtqaugERsbjT2lRt6M5f7E/Wb9183PSxAo64=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1unep3-004y9j-Jd; Sun, 17 Aug 2025 16:57:25 +0200 Date: Sun, 17 Aug 2025 16:57:25 +0200 From: Andrew Lunn To: Daniel Golle Cc: Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Hauke Mehrtens , Simon Horman , Russell King , Florian Fainelli , Arkadi Sharshevsky , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Andreas Schirm , Lukas Stockmann , Alexander Sverdlin , Peter Christen , Avinash Jayaraman , Bing tao Xu , Liang Xu , Juraj Povazanec , "Fanni (Fang-Yi) Chan" , "Benny (Ying-Tsan) Weng" , "Livia M. Rosu" , John Crispin Subject: Re: [PATCH RFC net-next 02/23] net: dsa: lantiq_gswip: deduplicate dsa_switch_ops Message-ID: <6b110e80-85b9-4a5e-96b9-282ba75b24d1@lunn.ch> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Sat, Aug 16, 2025 at 08:51:13PM +0100, Daniel Golle wrote: > The two instances of struct dsa_switch_ops differ only by their > .phylink_get_caps op. Instead of having two instances of dsa_switch_ops, > rather just have a pointer to the phylink_get_caps function in > struct gswip_hw_info. > > Signed-off-by: Daniel Golle Reviewed-by: Andrew Lunn Andrew